Skip to content

rework tcp option handling

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7parser: merge sack-perm/sack-permitted and maxseg/mssdoc/payload-expression.txt src/parser_bison.y src/scanner.l +4 more+27 -282 replies
2/7tcpopts: clean up parser -> tcpopt.c plumbingdoc/payload-expression.txt include/tcpopt.h src/parser_bison.y +3 more+76 -960 replies
3/7tcpopt: rename noop to nopdoc/payload-expression.txt src/tcpopt.c tests/py/any/tcpopt.t +2 more+7 -210 replies
4/7tcpopt: split tcpopt_hdr_fields into per-option enuminclude/tcpopt.h src/evaluate.c src/exthdr.c +6 more+139 -1050 replies
5/7tcpopt: allow to check for presence of any tcp optioninclude/expression.h src/exthdr.c src/ipopt.c +5 more+65 -574 replies
6/7tcp: add raw tcp option match supportdoc/payload-expression.txt src/exthdr.c src/parser_bison.y +3 more+31 -40 replies
7/7json: tcp: add raw tcp option match supportsrc/json.c src/parser_json.c tests/py/any/tcpopt.t.json+82 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nft 0/7] rework tcp option handling

This reworks how tcp options are handled in nft internally. First patches refactor and condense code.

In particular, it removes the duplication of 'sack-perm'/permitted maxseg/mss lexer keys -- synproxy and tcp option used different tokens, leading to confusing sytax errors when using the 'wrong' word in the 'wrong' place.

patch 5 is the first one with a new feature: it allows to check for presence of any tcp option kind, i.e. 'tcp option $number'. patch 6 and 7 add 'raw' payload matching for tcp options to allow testing for tcp options that do not have an internal template.