rework tcp option handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | parser: merge sack-perm/sack-permitted and maxseg/mssdoc/ src/ src/ +4 more | +27 | 2 replies | |
| 2/7 | tcpopts: clean up parser -> tcpopt.c plumbingdoc/ include/ src/ +3 more | +76 | 0 replies | |
| 3/7 | tcpopt: rename noop to nopdoc/ src/ tests/ +2 more | +7 | 0 replies | |
| 4/7 | tcpopt: split tcpopt_hdr_fields into per-option enuminclude/ src/ src/ +6 more | +139 | 0 replies | |
| 5/7 | tcpopt: allow to check for presence of any tcp optioninclude/ src/ src/ +5 more | +65 | 4 replies | |
| 6/7 | tcp: add raw tcp option match supportdoc/ src/ src/ +3 more | +31 | 0 replies | |
| 7/7 | json: tcp: add raw tcp option match supportsrc/ src/ tests/ | +82 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH nft 0/7] rework tcp option handling
This reworks how tcp options are handled in nft internally. First patches refactor and condense code.
In particular, it removes the duplication of 'sack-perm'/permitted maxseg/mss lexer keys -- synproxy and tcp option used different tokens, leading to confusing sytax errors when using the 'wrong' word in the 'wrong' place.
patch 5 is the first one with a new feature: it allows to check for presence of any tcp option kind, i.e. 'tcp option $number'. patch 6 and 7 add 'raw' payload matching for tcp options to allow testing for tcp options that do not have an internal template.