Skip to content

RFC Topdown parser

Ian Rogers linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12perf topdown-parser: Add a simple logging API.tools/perf/pmu-events/topdown-parser/logging.h+25 -00 replies
2/12perf topdown-parser: Add utility functions.tools/perf/pmu-events/topdown-parser/general_utils.cpp tools/perf/pmu-events/topdown-parser/general_utils.h+304 -00 replies
3/12perf topdown-paser: Add a CSV file reader.tools/perf/pmu-events/topdown-parser/csvreader.cpp tools/perf/pmu-events/topdown-parser/csvreader.h+100 -00 replies
4/12perf topdown-parser: Add a json file reader.tools/perf/pmu-events/topdown-parser/jsmn_extras.cpp tools/perf/pmu-events/topdown-parser/jsmn_extras.h+241 -00 replies
5/12perf topdown-parser: Add a configuration.tools/perf/pmu-events/topdown-parser/configuration.cpp tools/perf/pmu-events/topdown-parser/configuration.h tools/perf/pmu-events/topdown-parser/configuration.json+451 -00 replies
6/12perf topdown-parser: Interface for TMA_Metrics.csv.tools/perf/pmu-events/topdown-parser/dependence_dag_utils.cpp tools/perf/pmu-events/topdown-parser/dependence_dag_utils.h+1162 -00 replies
7/12perf topdown-parser: Metric expression parser.tools/perf/pmu-events/topdown-parser/expr_parser.y+224 -00 replies
8/12perf topdown-parser: Add event interface.tools/perf/pmu-events/topdown-parser/event_info.cpp tools/perf/pmu-events/topdown-parser/event_info.h+557 -00 replies
9/12perf topdown-paser: Add code generation API.tools/perf/pmu-events/topdown-parser/code_gen_target.cpp tools/perf/pmu-events/topdown-parser/code_gen_target.h+128 -00 replies
10/12perf topdown-parser: Add json metric code generation.tools/perf/pmu-events/topdown-parser/code_gen_target_perf_json.cpp tools/perf/pmu-events/topdown-parser/code_gen_target_perf_json.h+571 -00 replies
11/12perf topdown-parser: Main driver.tools/perf/pmu-events/topdown-parser/README tools/perf/pmu-events/topdown-parser/topdown_parser_main.cpp+160 -00 replies
12/12perf pmu-events: Topdown parser tooltools/perf/Makefile.perf tools/perf/pmu-events/Build+58 -50 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by.

PatchIan RogersStephane Eranian
1/12
2/12Co-authored-by
3/12Co-authored-by
4/12Co-authored-by
5/12Co-authored-by
6/12Co-authored-by
7/12Co-authored-by
8/12Co-authored-by
9/12Co-authored-by
10/12
11/12Co-authored-by Co-authored-by
12/12Co-authored-by Co-authored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/12] Topdown parser

This RFC is for a new tool that reads TMA_Metrics.csv as found on download.01.org/perfmon and generates metrics and metric groups from it. To show the functionality the TMA_Metrics.csv is downloaded, but an accepted change would most likely include a copy of this file from Intel. With this tool rather than just level 1 topdown metrics, a full set of topdown metrics to level 4 are generated.

This change was:

Sandeep Dasgupta (12):
perf topdown-parser: Add a simple logging API. perf topdown-parser: Add utility functions. perf topdown-paser: Add a CSV file reader. perf topdown-parser: Add a json file reader. perf topdown-parser: Add a configuration. perf topdown-parser: Interface for TMA_Metrics.csv. perf topdown-parser: Metric expression parser. perf topdown-parser: Add event interface. perf topdown-paser: Add code generation API. perf topdown-parser: Add json metric code generation. perf topdown-parser: Main driver.
perf pmu-events: Topdown parser tool

 tools/perf/Makefile.perf                      |  13 +-
 tools/perf/pmu-events/Build                   |  50 +-
 tools/perf/pmu-events/topdown-parser/README   |   5 +
 .../topdown-parser/code_gen_target.cpp        |  51 +
 .../topdown-parser/code_gen_target.h          |  77 ++
 .../code_gen_target_perf_json.cpp             | 546 ++++++++++
 .../code_gen_target_perf_json.h               |  25 +
 .../topdown-parser/configuration.cpp          | 198 ++++
 .../pmu-events/topdown-parser/configuration.h | 181 ++++
 .../topdown-parser/configuration.json         |  72 ++
 .../pmu-events/topdown-parser/csvreader.cpp   |  49 +
 .../pmu-events/topdown-parser/csvreader.h     |  51 +
 .../topdown-parser/dependence_dag_utils.cpp   | 984 ++++++++++++++++++
 .../topdown-parser/dependence_dag_utils.h     | 178 ++++
 .../pmu-events/topdown-parser/event_info.cpp  | 443 ++++++++
 .../pmu-events/topdown-parser/event_info.h    | 114 ++
 .../pmu-events/topdown-parser/expr_parser.y   | 224 ++++
 .../topdown-parser/general_utils.cpp          | 173 +++
 .../pmu-events/topdown-parser/general_utils.h | 131 +++
 .../pmu-events/topdown-parser/jsmn_extras.cpp | 199 ++++
 .../pmu-events/topdown-parser/jsmn_extras.h   |  42 +
 .../perf/pmu-events/topdown-parser/logging.h  |  25 +
 .../topdown-parser/topdown_parser_main.cpp    | 155 +++
 23 files changed, 3981 insertions(+), 5 deletions(-)
 create mode 100644 tools/perf/pmu-events/topdown-parser/README
 create mode 100644 tools/perf/pmu-events/topdown-parser/code_gen_target.cpp
 create mode 100644 tools/perf/pmu-events/topdown-parser/code_gen_target.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/code_gen_target_perf_json.cpp
 create mode 100644 tools/perf/pmu-events/topdown-parser/code_gen_target_perf_json.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/configuration.cpp
 create mode 100644 tools/perf/pmu-events/topdown-parser/configuration.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/configuration.json
 create mode 100644 tools/perf/pmu-events/topdown-parser/csvreader.cpp
 create mode 100644 tools/perf/pmu-events/topdown-parser/csvreader.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/dependence_dag_utils.cpp
 create mode 100644 tools/perf/pmu-events/topdown-parser/dependence_dag_utils.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/event_info.cpp
 create mode 100644 tools/perf/pmu-events/topdown-parser/event_info.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/expr_parser.y
 create mode 100644 tools/perf/pmu-events/topdown-parser/general_utils.cpp
 create mode 100644 tools/perf/pmu-events/topdown-parser/general_utils.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/jsmn_extras.cpp
 create mode 100644 tools/perf/pmu-events/topdown-parser/jsmn_extras.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/logging.h
 create mode 100644 tools/perf/pmu-events/topdown-parser/topdown_parser_main.cpp
Signature · 1 line
2.29.2.222.g5d2a92d10f8-goog