Skip to content

KVM: selftests: Cleanups, take 2

Andrew Jones kvm 4 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyApplied
  2. v34 patches 12 repliesSuperseded
  3. v211 patches 22 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches6 repliesSuperseded

Changes in v4 from the cover letter

- dropped "KVM: selftests: dirty_log_test: Remove create_vm" patch
- Rebased on latest kvm/queue (patches applied cleanly)
- Ensured dirty-ring was enabled on x86 when testing

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3KVM: selftests: Factor out guest mode codetools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c +3 more+189 -2570 replies
2/3KVM: selftests: Use vm_create_with_vcpus in create_vmtools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c tools/testing/selftests/kvm/include/kvm_util.h +2 more+21 -470 replies
3/3KVM: selftests: Implement perf_test_util more conventionallytools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c +3 more+166 -1460 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBen GardonPeter Xu
1/3R-b R-b
2/3R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] KVM: selftests: Cleanups, take 2

This series attempts to clean up demand_paging_test, dirty_log_perf_test, and dirty_log_test by factoring out common code, creating some new API along the way. It also splits include/perf_test_util.h into a more conventional header and source pair.

I've tested on x86 and AArch64 (one config each), but not s390x.

v4:
- dropped "KVM: selftests: dirty_log_test: Remove create_vm" patch
- Rebased on latest kvm/queue (patches applied cleanly)
- Ensured dirty-ring was enabled on x86 when testing

v3:
- Rebased remaining four patches from v2 onto kvm/queue
- Picked up r-b's from Peter and Ben

v2: https://www.spinics.net/lists/kvm/msg228711.html

Thanks,
drew

Andrew Jones (3):
KVM: selftests: Factor out guest mode code
KVM: selftests: Use vm_create_with_vcpus in create_vm
KVM: selftests: Implement perf_test_util more conventionally

 tools/testing/selftests/kvm/Makefile          |   2 +-
 .../selftests/kvm/demand_paging_test.c        | 118 ++++---------
 .../selftests/kvm/dirty_log_perf_test.c       | 145 +++++----------
 tools/testing/selftests/kvm/dirty_log_test.c  | 125 ++++---------
 .../selftests/kvm/include/guest_modes.h       |  21 +++
 .../testing/selftests/kvm/include/kvm_util.h  |   9 +
 .../selftests/kvm/include/perf_test_util.h    | 167 ++----------------
 tools/testing/selftests/kvm/lib/guest_modes.c |  70 ++++++++
 tools/testing/selftests/kvm/lib/kvm_util.c    |   9 +-
 .../selftests/kvm/lib/perf_test_util.c        | 134 ++++++++++++++
 10 files changed, 363 insertions(+), 437 deletions(-)
 create mode 100644 tools/testing/selftests/kvm/include/guest_modes.h
 create mode 100644 tools/testing/selftests/kvm/lib/guest_modes.c
 create mode 100644 tools/testing/selftests/kvm/lib/perf_test_util.c
Signature · 1 line
2.26.2