Stateless H.264 de-staging
Status from this message: Nack.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest14 patches 2 repliesNAK
- v413 patches 6 repliesSuperseded
- v313 patches 7 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 9 patches | 10 replies | Superseded | |
| v1 | 5 patches | 2 replies | Superseded |
Changes in v5 from the cover letter
* Pick class g-ext-ctrls.rst patch from Hans.
* Document V4L2_CTRL_CLASS_CODEC_STATELESS and H264 stateless fields in vidioc-g-ext-ctrls.rst.
* Add videodev2 replace symbol for V4L2_CTRL_TYPE_H264_PRED_WEIGHTS.
* Drop profile-idc macros and add a comment for it.
* Fix old mpeg_video names in the new documentation.
Patches in v5
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | media: vidioc-g-ext-ctrls.rst: document V4L2_CTRL_CLASS_DETECTDocumentation/ | +4 | 0 replies | |
| 2/14 | media: controls: Add validate failure debug messagedrivers/ | +6 | 0 replies | |
| 3/14 | media: rkvdec: h264: Support profile and level controlsdrivers/ | +13 | 0 replies | |
| 4/14 | media: cedrus: h264: Support profile controlsdrivers/ | +19 | 0 replies | |
| 5/14 | media: Rename stateful codec control macrosDocumentation/ Documentation/ Documentation/ +11 more | +242 | 0 replies | |
| 6/14 | media: Clean stateless control includesdrivers/ include/ | +2 | 0 replies | |
| 7/14 | media: controls: Validate H264 stateless controlsdrivers/ include/ | +143 | 0 replies | |
| 8/14 | media: controls: Add the stateless codec control classDocumentation/ drivers/ include/ | +16 | 0 replies | |
| 9/14 | media: uapi: Move parsed H264 pixel format out of staginginclude/ include/ | +1 | 0 replies | |
| 10/14 | media: doc: Replace symbol for V4L2_CTRL_TYPE_H264_PRED_WEIGHTSDocumentation/ | +1 | 0 replies | |
| 11/14 | media: uapi: Move the H264 stateless control types out of staginginclude/ include/ | +7 | 0 replies | |
| 12/14 | media: controls: Log H264 stateless controls in .std_logdrivers/ | +18 | 0 replies | |
| 13/14 | media: uapi: move H264 stateless controls out of stagingdrivers/ drivers/ drivers/ +8 more | +457 | 2 replies | |
| 14/14 | media: docs: Move the H264 stateless codec uAPIDocumentation/ Documentation/ Documentation/ +2 more | +709 | 0 replies |
Reviews trailers per patch
1 of 14 patches has a Reviewed-by or Acked-by.
| Patch | Jernej Skrabec |
|---|---|
| 1/14 | |
| 2/14 | |
| 3/14 | |
| 4/14 | R-b T-b |
| 5/14 | T-b |
| 6/14 | T-b |
| 7/14 | T-b |
| 8/14 | T-b |
| 9/14 | T-b |
| 10/14 | |
| 11/14 | T-b |
| 12/14 | |
| 13/14 | T-b |
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 00/14] Stateless H.264 de-staging
Another iteration, hoping we nailed it this time!
The git-diff difference between v4 and v5: http://ix.io/2Fwj.
v5:
* Pick class g-ext-ctrls.rst patch from Hans.
* Document V4L2_CTRL_CLASS_CODEC_STATELESS and H264 stateless fields in vidioc-g-ext-ctrls.rst.
* Add videodev2 replace symbol for V4L2_CTRL_TYPE_H264_PRED_WEIGHTS.
* Drop profile-idc macros and add a comment for it.
* Fix old mpeg_video names in the new documentation.
v4:
* Minor documentation fixes.
* Remove media/h264-ctrls.h, which was missing before.
* Thanks to feedback from Jernej, std_validation_compound
is now more complete, initializing non-present syntax elements.
v3:
* Dropped level control from Cedrus, as agreed.
* Add support for H264 stateless controls in std_log and std_validate_compound.
* Added a ctrl debug error message, to help debug validation issues.
* Style minor fixes as requested by Hans.
v2:
* Split destage changes in several patches so it's easier to review.
* Added missing changes to drivers/media/v4l2-core/v4l2-ctrls.c.
* Renamed V4L2_CID_CODEC_CX2341X_ and V4L2_CID_MPEG_MFC51_
* Moved the compatibility macros for MPEG to the end of the header.
Ezequiel Garcia (12):
media: controls: Add validate failure debug message
media: cedrus: h264: Support profile controls
media: Rename stateful codec control macros
media: Clean stateless control includes
media: controls: Validate H264 stateless controls
media: controls: Add the stateless codec control class
media: uapi: Move parsed H264 pixel format out of staging
media: doc: Replace symbol for V4L2_CTRL_TYPE_H264_PRED_WEIGHTS
media: uapi: Move the H264 stateless control types out of staging
media: controls: Log H264 stateless controls in .std_log
media: uapi: move H264 stateless controls out of staging
media: docs: Move the H264 stateless codec uAPI
Hans Verkuil (1):
media: vidioc-g-ext-ctrls.rst: document V4L2_CTRL_CLASS_DETECT
Jonas Karlman (1):
media: rkvdec: h264: Support profile and level controls
.../userspace-api/media/v4l/common.rst | 1 + .../userspace-api/media/v4l/dev-mem2mem.rst | 2 +- .../media/v4l/ext-ctrls-codec-stateless.rst | 674 +++++++++++++++ .../media/v4l/ext-ctrls-codec.rst | 696 +-------------- .../media/v4l/extended-controls.rst | 8 +- .../media/v4l/pixfmt-compressed.rst | 25 +- .../media/v4l/vidioc-g-ext-ctrls.rst | 38 +- .../media/videodev2.h.rst.exceptions | 1 + drivers/media/common/cx2341x.c | 4 +- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 2 +- drivers/media/v4l2-core/v4l2-ctrls.c | 204 ++++- drivers/staging/media/hantro/hantro_drv.c | 26 +- drivers/staging/media/hantro/hantro_h264.c | 8 +- drivers/staging/media/hantro/hantro_hw.h | 4 +- drivers/staging/media/rkvdec/rkvdec-h264.c | 8 +- drivers/staging/media/rkvdec/rkvdec.c | 39 +- drivers/staging/media/sunxi/cedrus/cedrus.c | 43 +- .../staging/media/sunxi/cedrus/cedrus_dec.c | 12 +- include/media/fwht-ctrls.h | 2 +- include/media/h264-ctrls.h | 406 --------- include/media/hevc-ctrls.h | 10 +- include/media/mpeg2-ctrls.h | 4 +- include/media/v4l2-ctrls.h | 1 - include/media/v4l2-h264.h | 2 +- include/media/vp8-ctrls.h | 2 +- include/uapi/linux/v4l2-controls.h | 797 +++++++++++++----- include/uapi/linux/videodev2.h | 14 + 28 files changed, 1621 insertions(+), 1414 deletions(-) create mode 100644 Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst delete mode 100644 include/media/h264-ctrls.h
Signature · 1 line
2.27.0