Skip to content

Chipping away at qerror.h

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10qerror: Drop unused QERR_ macrosinclude/qapi/qmp/qerror.h+0 -61 reply
2/10qerror: Eliminate QERR_ macros used in just one placeinclude/qapi/qmp/qerror.h monitor/misc.c net/net.c+5 -140 replies
3/10block: Improve some block-commit, block-stream error messagesblockdev.c include/qapi/qmp/qerror.h tests/qemu-iotests/040+15 -141 reply
4/10ui: Improve some set_passwd, expire_password error messagesinclude/qapi/qmp/qerror.h monitor/qmp-cmds.c+15 -260 replies
5/10ui: Improve a client_migrate_info error messageinclude/qapi/qmp/qerror.h monitor/misc.c+1 -40 replies
6/10ui: Tweak a client_migrate_info error messagemonitor/misc.c+1 -10 replies
7/10qga: Replace an unreachable error by abort()qga/commands-win32.c+1 -20 replies
8/10qga: Tweak a guest-shutdown error messageqga/commands-win32.c+1 -10 replies
9/10qom: Improve {qom, device}-list-properties error messagesqom/qom-qmp-cmds.c+6 -112 replies
10/10Tweak a few "Parameter 'NAME' expects THING" error messageblock/quorum.c blockdev.c chardev/char.c +2 more+6 -60 replies

Reviews trailers per patch

2 of 10 patches have a Reviewed-by or Acked-by.

PatchMax ReitzPhilippe Mathieu-Daudé
1/10R-b
2/10
3/10R-b
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] Chipping away at qerror.h

Obviously not for 5.2. Please review anyway.

Markus Armbruster (10):
qerror: Drop unused QERR_ macros
qerror: Eliminate QERR_ macros used in just one place
block: Improve some block-commit, block-stream error messages
ui: Improve some set_passwd, expire_password error messages
ui: Improve a client_migrate_info error message
ui: Tweak a client_migrate_info error message
qga: Replace an unreachable error by abort()
qga: Tweak a guest-shutdown error message
qom: Improve {qom,device}-list-properties error messages Tweak a few "Parameter 'NAME' expects THING" error message

 include/qapi/qmp/qerror.h        | 23 -------------------
 block/quorum.c                   |  2 +-
 blockdev.c                       | 17 ++++++++------
 chardev/char.c                   |  2 +-
 hw/core/qdev-properties-system.c |  2 +-
 monitor/misc.c                   | 12 +++++-----
 monitor/qmp-cmds.c               | 38 +++++++++++++-------------------
 net/net.c                        |  2 +-
 qga/commands-win32.c             |  5 ++---
 qom/qom-qmp-cmds.c               | 17 +++++---------
 softmmu/qdev-monitor.c           |  4 ++--
 tests/qemu-iotests/040           | 12 +++++-----
 12 files changed, 51 insertions(+), 85 deletions(-)
Signature · 1 line
2.26.2