Skip to content

perf/mm: Fix PERF_SAMPLE_*_PAGE_SIZE

Peter Zijlstra linux-arch linuxppc-dev lkml sparclinux 2 versions – Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 10 repliesApplied
  2. v15 patches 13 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6mm/gup: Provide gup_get_pte() more genericinclude/linux/pgtable.h mm/gup.c+56 -572 replies
2/6mm: Introduce pXX_leaf_size()include/linux/pgtable.h+16 -01 reply
3/6perf/core: Fix arch_perf_get_page_size()kernel/events/core.c+38 -655 replies
4/6arm64/mm: Implement pXX_leaf_size() supportarch/arm64/include/asm/pgtable.h+3 -02 replies
5/6sparc64/mm: Implement pXX_leaf_size() supportarch/sparc/include/asm/pgtable_64.h arch/sparc/mm/hugetlbpage.c+26 -60 replies
6/6powerpc/8xx: Implement pXX_leaf_size() supportarch/powerpc/include/asm/nohash/32/pte-8xx.h+23 -00 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchKan LiangMatthew Wilcox (Oracle)Will Deacon
1/6
2/6R-b
3/6T-b T-b
4/6A-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] perf/mm: Fix PERF_SAMPLE_*_PAGE_SIZE

Hi,

These patches provide generic infrastructure to determine TLB page size from page table entries alone. Perf will use this (for either data or code address) to aid in profiling TLB issues.

While most architectures only have page table aligned large pages, some (notably ARM64, Sparc64 and Power) provide non page table aligned large pages and need to provide their own implementation of these functions.

I've provided (completely untested) implementations for ARM64, Sparc64 and Power/8xxx (it looks like I'm still missing Power/Book3s64/hash support).

Changes since -v1:

- Changed wording to reflect these are page-table sizes; actual TLB sizes might vary.
- added Power/8xx

Barring any objections I'll queue these in tip/perf/core, as these patches fix the code that's currently in there.