Skip to content

RFC vdpa: generalize vdpa simulator and add block device

Stefano Garzarella lkml oe-kbuild oe-kbuild-all virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 53 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12vhost-vdpa: add support for vDPA blk devicesdrivers/vhost/vdpa.c+8 -32 replies
2/12vdpa: split vdpasim to core and net modulesdrivers/vdpa/Kconfig drivers/vdpa/vdpa_sim/Makefile drivers/vdpa/vdpa_sim/vdpa_sim.c +2 more+329 -22711 replies
3/12vdpa_sim: remove hard-coded virtq countdrivers/vdpa/vdpa_sim/vdpa_sim.c drivers/vdpa/vdpa_sim/vdpa_sim.h drivers/vdpa/vdpa_sim/vdpa_sim_net.c+17 -51 reply
4/12vdpa: add vdpa simulator for block devicedrivers/vdpa/Kconfig drivers/vdpa/vdpa_sim/Makefile drivers/vdpa/vdpa_sim/vdpa_sim_blk.c+134 -08 replies
5/12vdpa_sim: remove the limit of IOTLB entriesdrivers/vdpa/vdpa_sim/vdpa_sim.c+1 -12 replies
6/12vdpa_sim: add struct vdpasim_device to store device propertiesdrivers/vdpa/vdpa_sim/vdpa_sim.c drivers/vdpa/vdpa_sim/vdpa_sim.h drivers/vdpa/vdpa_sim/vdpa_sim_blk.c +1 more+38 -294 replies
7/12vdpa_sim: move config management outside of the coredrivers/vdpa/vdpa_sim/vdpa_sim.c drivers/vdpa/vdpa_sim/vdpa_sim.h drivers/vdpa/vdpa_sim/vdpa_sim_blk.c +1 more+37 -362 replies
8/12vdpa_sim: use kvmalloc to allocate vdpasim->bufferdrivers/vdpa/vdpa_sim/vdpa_sim.c+2 -21 reply
9/12vdpa_sim: make vdpasim->buffer size configurabledrivers/vdpa/vdpa_sim/vdpa_sim.c drivers/vdpa/vdpa_sim/vdpa_sim.h drivers/vdpa/vdpa_sim/vdpa_sim_blk.c +1 more+4 -11 reply
10/12vdpa_sim: split vdpasim_virtqueue's iov field in riov and wiovdrivers/vdpa/vdpa_sim/vdpa_sim.h drivers/vdpa/vdpa_sim/vdpa_sim_blk.c drivers/vdpa/vdpa_sim/vdpa_sim_net.c+9 -83 replies
11/12vringh: allow vringh_iov_xfer() to skip bytes when ptr is NULLdrivers/vhost/vringh.c+11 -52 replies
12/12vdpa_sim_blk: implement ramdisk behaviourdrivers/vdpa/vdpa_sim/vdpa_sim_blk.c+133 -186 replies

Reviews trailers per patch

5 of 12 patches have a Reviewed-by or Acked-by.

PatchJason Wang
1/12R-b
2/12
3/12
4/12
5/12A-b
6/12
7/12
8/12A-b
9/12A-b
10/12A-b
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device

Thanks to Max that started this work!
I took his patches, and extended the block simulator a bit.

This series moves the network device simulator in a new module (vdpa_sim_net) and leaves the generic functions in the vdpa_sim core module, allowing the possibility to add new vDPA device simulators. Then we added a new vdpa_sim_blk module to simulate a block device.

I'm not sure about patch 11 ("vringh: allow vringh_iov_xfer() to skip bytes when ptr is NULL"), maybe we can add a new functions instead of modify vringh_iov_xfer().

As Max reported, I'm also seeing errors with vdpa_sim_blk related to iotlb and vringh when there is high load, these are some of the error messages I can see randomly:

vringh: Failed to access avail idx at 00000000e8deb2cc
vringh: Failed to read head: idx 6289 address 00000000e1ad1d50
vringh: Failed to get flags at 000000006635d7a3

virtio_vdpa vdpa0: vringh_iov_push_iotlb() error: -14 offset: 0x2840000 len: 0x20000 virtio_vdpa vdpa0: vringh_iov_pull_iotlb() error: -14 offset: 0x58ee000 len: 0x3000

These errors should all be related to the fact that iotlb_translate() fails with -EINVAL, so it seems that we miss some mapping.

I'll debug more carefully, in the meantime can you give a first review?

Thanks,
Stefano

Max Gurtovoy (4):
vhost-vdpa: add support for vDPA blk devices
vdpa: split vdpasim to core and net modules
vdpa_sim: remove hard-coded virtq count
vdpa: add vdpa simulator for block device

Stefano Garzarella (8):
vdpa_sim: remove the limit of IOTLB entries
vdpa_sim: add struct vdpasim_device to store device properties
vdpa_sim: move config management outside of the core
vdpa_sim: use kvmalloc to allocate vdpasim->buffer
vdpa_sim: make vdpasim->buffer size configurable
vdpa_sim: split vdpasim_virtqueue's iov field in riov and wiov
vringh: allow vringh_iov_xfer() to skip bytes when ptr is NULL
vdpa_sim_blk: implement ramdisk behaviour

 drivers/vdpa/vdpa_sim/vdpa_sim.h     | 117 +++++++++++
 drivers/vdpa/vdpa_sim/vdpa_sim.c     | 283 +++++----------------------
 drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 251 ++++++++++++++++++++++++
 drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 172 ++++++++++++++++
 drivers/vhost/vdpa.c                 |  11 +-
 drivers/vhost/vringh.c               |  16 +-
 drivers/vdpa/Kconfig                 |  16 +-
 drivers/vdpa/vdpa_sim/Makefile       |   2 +
 8 files changed, 628 insertions(+), 240 deletions(-)
 create mode 100644 drivers/vdpa/vdpa_sim/vdpa_sim.h
 create mode 100644 drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
 create mode 100644 drivers/vdpa/vdpa_sim/vdpa_sim_net.c
Signature · 1 line
2.26.2