Skip to content

vc4: Convert to drm_atomic_helper_commit

Maxime Ripard dri-devel linux-arm-kernel linux-devicetree oe-kbuild-all 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 5 repliesApplied
  2. v18 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- Addressed the comments from Dave and Thomas on the documentation
- s/last_user/pending_commit/
- Check that the commit is not NULL before waiting on it
- Fixed a compilation error on an intermediate patch
- Drop the assigned_channels variable redundant with the in_use variable

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7drm: Introduce an atomic_commit_setup functiondrivers/gpu/drm/drm_atomic_helper.c include/drm/drm_modeset_helper_vtables.h+30 -01 reply
2/7drm: Document use-after-free gotcha with private objectsinclude/drm/drm_atomic.h+20 -00 replies
3/7drm/vc4: Simplify a bit the global atomic_checkdrivers/gpu/drm/vc4/vc4_kms.c+6 -70 replies
4/7drm/vc4: kms: Wait on previous FIFO users before a commitdrivers/gpu/drm/vc4/vc4_kms.c+122 -11 reply
5/7drm/vc4: kms: Remove unassigned_channels from the HVS statedrivers/gpu/drm/vc4/vc4_kms.c+7 -72 replies
6/7drm/vc4: kms: Remove async modeset semaphoredrivers/gpu/drm/vc4/vc4_crtc.c drivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_kms.c+2 -370 replies
7/7drm/vc4: kms: Convert to atomic helpersdrivers/gpu/drm/vc4/vc4_kms.c+3 -1070 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchDaniel VetterThomas Zimmermann
1/7
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] vc4: Convert to drm_atomic_helper_commit

Hi,

Here's a conversion of vc4 to remove the hand-rolled atomic_commit helper from vc4 in favour of the generic one.

This requires some rework of vc4, but also a new hook and some documentation for corner-cases in the DRM core that have been reported and explained by Daniel recently.

Let me know what you think,
Maxime

Changes from v1:
- Addressed the comments from Dave and Thomas on the documentation
- s/last_user/pending_commit/
- Check that the commit is not NULL before waiting on it
- Fixed a compilation error on an intermediate patch
- Drop the assigned_channels variable redundant with the in_use variable

Maxime Ripard (7):
drm: Introduce an atomic_commit_setup function
drm: Document use-after-free gotcha with private objects drm/vc4: Simplify a bit the global atomic_check drm/vc4: kms: Wait on previous FIFO users before a commit drm/vc4: kms: Remove unassigned_channels from the HVS state drm/vc4: kms: Remove async modeset semaphore drm/vc4: kms: Convert to atomic helpers

 drivers/gpu/drm/drm_atomic_helper.c      |   9 +
 drivers/gpu/drm/vc4/vc4_crtc.c           |  13 --
 drivers/gpu/drm/vc4/vc4_drv.h            |   2 -
 drivers/gpu/drm/vc4/vc4_kms.c            | 248 +++++++++++------------
 include/drm/drm_atomic.h                 |  20 ++
 include/drm/drm_modeset_helper_vtables.h |  21 ++
 6 files changed, 172 insertions(+), 141 deletions(-)
Signature · 1 line
2.28.0