Skip to content

quorum: Require WRITE perm with rewrite-corrupted

Max Reitz qemu-devel 1 version Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3quorum: Require WRITE perm with rewrite-corruptedblock/quorum.c+5 -01 reply
2/3iotests/081: Filter image format after testdirtests/qemu-iotests/081+4 -30 replies
3/3iotests/081: Test rewrite-corrupted without WRITEtests/qemu-iotests/081 tests/qemu-iotests/081.out+81 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchAlberto Garcia
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] quorum: Require WRITE perm with rewrite-corrupted

Hi,

While reviewing Berto’s block-status/write-zeroes series for quorum, I wondered how quorum’s permission code handles rewrite-corrupted. It turns out it doesn’t, and so qemu with a read-only rewrite-corrupted quorum node simply crashes once there is a mismatch that leads to a rewrite.

It looks to me like this bug has existed for quite some time, so I don’t think this series must go into 5.2. OTOH, it’s a simple bug fix, so I suppose it might as well.

Max Reitz (3):
quorum: Require WRITE perm with rewrite-corrupted iotests/081: Filter image format after testdir iotests/081: Test rewrite-corrupted without WRITE

 block/quorum.c             |  5 ++++
 tests/qemu-iotests/081     | 61 ++++++++++++++++++++++++++++++++++++--
 tests/qemu-iotests/081.out | 27 +++++++++++++++++
 3 files changed, 90 insertions(+), 3 deletions(-)
Signature · 1 line
2.28.0