PPC: Fix -Wimplicit-fallthrough for clang
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 2 repliesIn review
- v13 patches 18 repliesSuperseded
Changes in v2 from the cover letter
* collect tags via b4 (fix Gustavo's tag as per Miguel in patch 2/3).
* reword commit message of patch 1/3 as per Arvind.
* reformat patch 2/3 as per kernel test robot and Gustavo.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | powerpc: boot: include compiler_attributes.harch/ arch/ | +1 | 1 reply | |
| 2/3 | Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"lib/ lib/ lib/ +13 more | +74 | 0 replies | |
| 3/3 | powerpc: fix -Wimplicit-fallthrougharch/ arch/ arch/ | +3 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Nathan Chancellor | Gustavo A. R. Silva | Miguel Ojeda | Michael Ellerman |
|---|---|---|---|---|
| 1/3 | T-b R-b | A-b | A-b | A-b |
| 2/3 | T-b R-b | R-b | R-b | |
| 3/3 | T-b R-b | R-b | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/3] PPC: Fix -Wimplicit-fallthrough for clang
While cleaning up the last few -Wimplicit-fallthrough warnings in tree for Clang, I noticed
commit 6a9dc5fd6170d ("lib: Revert use of fallthrough pseudo-keyword in lib/") which seemed to undo a bunch of fixes in lib/ due to breakage in arch/powerpc/boot/ not including compiler_types.h. We don't need compiler_types.h for the definition of fallthrough, simply compiler_attributes.h. Include that, revert the revert to lib/, and fix the last remaining cases I observed for powernv_defconfig.
Changes V1->V2:
* collect tags via b4 (fix Gustavo's tag as per Miguel in patch 2/3).
* reword commit message of patch 1/3 as per Arvind.
* reformat patch 2/3 as per kernel test robot and Gustavo.
Nick Desaulniers (3):
powerpc: boot: include compiler_attributes.h
Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"
powerpc: fix -Wimplicit-fallthrough
arch/powerpc/boot/Makefile | 1 + arch/powerpc/boot/decompress.c | 1 - arch/powerpc/kernel/prom_init.c | 1 + arch/powerpc/kernel/uprobes.c | 1 + arch/powerpc/perf/imc-pmu.c | 1 + lib/asn1_decoder.c | 4 ++-- lib/assoc_array.c | 2 +- lib/bootconfig.c | 4 ++-- lib/cmdline.c | 10 ++++----- lib/dim/net_dim.c | 2 +- lib/dim/rdma_dim.c | 4 ++-- lib/glob.c | 2 +- lib/siphash.c | 36 ++++++++++++++++----------------- lib/ts_fsm.c | 2 +- lib/vsprintf.c | 14 ++++++------- lib/xz/xz_dec_lzma2.c | 4 ++-- lib/xz/xz_dec_stream.c | 16 +++++++-------- lib/zstd/bitstream.h | 10 ++++----- lib/zstd/compress.c | 2 +- lib/zstd/decompress.c | 12 +++++------ lib/zstd/huf_compress.c | 17 +++++++++++----- 21 files changed, 78 insertions(+), 68 deletions(-)
Signature · 1 line
2.29.2.299.gdc1121823c-goog