Skip to content

io_uring: add mkdir and [sym]linkat support

Dmitry Kadashev io-uring linux-fsdevel 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest11 patches 5 repliesIn review
  2. v811 patches 6 repliesSuperseded
  3. v710 patches 2 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v69 patches4 repliesSuperseded
v510 patches42 repliesSuperseded
v46 patches4 repliesSuperseded
v32 patches12 repliesSuperseded
v22 patches4 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v9 from the cover letter

- reorder commits to keep io_uring ones nicely grouped at the end
- change 'fs:' to 'namei:' in related commit subjects, since this is what seems to be usually used in such cases

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11namei: ignore ERR/NULL names in putname()fs/namei.c+5 -40 replies
2/11namei: change filename_parentat() calling conventionsfs/namei.c+53 -550 replies
3/11namei: make do_mkdirat() take struct filenamefs/internal.h fs/namei.c+20 -70 replies
4/11namei: make do_mknodat() take struct filenamefs/namei.c+11 -80 replies
5/11namei: make do_symlinkat() take struct filenamefs/namei.c+12 -110 replies
6/11namei: add getname_uflags()fs/exec.c fs/namei.c include/linux/fs.h+11 -60 replies
7/11namei: make do_linkat() take struct filenamefs/namei.c+29 -160 replies
8/11namei: update do_*() helpers to return intsfs/internal.h fs/namei.c+8 -80 replies
9/11io_uring: add support for IORING_OP_MKDIRATfs/io_uring.c include/uapi/linux/io_uring.h+60 -00 replies
10/11io_uring: add support for IORING_OP_SYMLINKATfs/internal.h fs/io_uring.c fs/namei.c +1 more+69 -20 replies
11/11io_uring: add support for IORING_OP_LINKATfs/internal.h fs/io_uring.c fs/namei.c +1 more+76 -10 replies

Reviews trailers per patch

9 of 11 patches have a Reviewed-by or Acked-by.

PatchChristian Brauner
1/11
2/11
3/11A-b
4/11A-b
5/11A-b
6/11A-b
7/11A-b
8/11A-b
9/11A-b
10/11A-b
11/11A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 00/11] io_uring: add mkdir and [sym]linkat support

This started out as an attempt to add mkdirat support to io_uring which is heavily based on renameat() / unlinkat() support.

During the review process more operations were added (linkat, symlinkat, mknodat) mainly to keep things uniform internally (in namei.c), and with things changed in namei.c adding support for these operations to io_uring is trivial, so that was done too (except for mknodat). See
https://lore.kernel.org/io-uring/20210514145259.wtl4xcsp52woi6ab@wittgenstein/

The first patch makes putname() ignore IS_ERR_OR_NULL names and converts a couple of places where the check was already implemented in the callers. No functional changes.

The second one splits filename_lookup() that used to consume the passed struct filename * on error but not on the success (returning it) into
two: filename_lookup(), that always consumes the name and __filename_lookup() that never does. This is a preparation change to enable the subsequent changes to filename_create and filename_lookup. No functional changes.

The third patch is preparation with no functional changes, makes do_mkdirat accept struct filename pointer rather than the user string.

4-7 just convert other similar do_* functions in namei.c to accept struct filename, for uniformity with do_mkdirat, do_renameat and do_unlinkat. No functional changes there.

8 changes do_* helpers in namei.c to return ints rather than some of them returning ints and some longs.

9-11 leverages the previous changes to add mkdirat, symlinkat and linkat support to io_uring correspondingly

Based on for-5.14/io_uring.

v9:
- reorder commits to keep io_uring ones nicely grouped at the end
- change 'fs:' to 'namei:' in related commit subjects, since this is what seems to be usually used in such cases

v8:
- update filename_parentat() calling conventions to be uniform with the ones followed by (changed in subsequent patches) filename_create() and filename_lookup()

v7:
- rebase
- make putname() ignore IS_ERR_OR_NULL names, remove conditional calls to it from the callers

v6:

- rebase
- add safety checks for IOPOLL mode
- add safety checks for unused sqe parts
- drop mknodat support from io_uring as requested by Jens
- add Christian's Acked-by

v5:
- rebase
- add symlinkat, linkat and mknodat support to io_uring

v4:
- update do_mknodat, do_symlinkat and do_linkat to accept struct filename for uniformity with do_mkdirat, do_renameat and do_unlinkat;

v3:
- rebase;

v2:
- do not mess with struct filename's refcount in do_mkdirat, instead add and use __filename_create() that does not drop the name on success;

Dmitry Kadashev (11):
namei: ignore ERR/NULL names in putname()
namei: change filename_parentat() calling conventions
namei: make do_mkdirat() take struct filename
namei: make do_mknodat() take struct filename
namei: make do_symlinkat() take struct filename
namei: add getname_uflags()
namei: make do_linkat() take struct filename
namei: update do_*() helpers to return ints
io_uring: add support for IORING_OP_MKDIRAT
io_uring: add support for IORING_OP_SYMLINKAT
io_uring: add support for IORING_OP_LINKAT

 fs/exec.c                     |   8 +-
 fs/internal.h                 |   8 +-
 fs/io_uring.c                 | 196 ++++++++++++++++++++++++++++
 fs/namei.c                    | 239 +++++++++++++++++++---------------
 include/linux/fs.h            |   1 +
 include/uapi/linux/io_uring.h |   4 +
 6 files changed, 346 insertions(+), 110 deletions(-)
Signature · 1 line
2.30.2