USB: serial: cp210x: clean up termios handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | USB: serial: cp210x: return early on unchanged termiosdrivers/ | +12 | 0 replies | |
| 2/6 | USB: serial: cp210x: clean up line-control handlingdrivers/ | +41 | 0 replies | |
| 3/6 | USB: serial: cp210x: set terminal settings on opendrivers/ | +6 | 0 replies | |
| 4/6 | USB: serial: cp210x: drop flow-control debuggingdrivers/ | +1 | 0 replies | |
| 5/6 | USB: serial: cp210x: refactor flow-control handlingdrivers/ | +47 | 0 replies | |
| 6/6 | USB: serial: cp210x: clean up dts_rtsdrivers/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] USB: serial: cp210x: clean up termios handling
Unlike other drivers cp210x have been retrieving the current terminal settings from the device on open and reflecting those in termios.
Due to how set_termios() was implemented this saved a few control requests on open but has instead caused problems like broken flow control and has required adding workarounds for swapped line-control in cp2108 and line-speed initialisation on cp2104.
This unusual implementation also complicates adding new features for no good reason.
Rip out the corresponding code and the above mentioned workarounds and instead initialise the terminal settings unconditionally on open.
Johan
Johan Hovold (6):
USB: serial: cp210x: return early on unchanged termios
USB: serial: cp210x: clean up line-control handling
USB: serial: cp210x: set terminal settings on open
USB: serial: cp210x: drop flow-control debugging
USB: serial: cp210x: refactor flow-control handling
USB: serial: cp210x: clean up dts_rts
drivers/usb/serial/cp210x.c | 499 ++++++++---------------------------- 1 file changed, 104 insertions(+), 395 deletions(-)
Signature · 1 line
2.26.2