Skip to content

drm/fb-helper: Various fixes and cleanups

Thomas Zimmermann dri-devel lkml virtualization 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 15 repliesIn review
  2. v110 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/fb-helper: Call dirty helper after writing to fbdevdrivers/gpu/drm/drm_fb_helper.c+3 -01 reply
2/10drm/fb-helper: Unmap client buffer during shutdowndrivers/gpu/drm/drm_fb_helper.c+9 -41 reply
3/10drm/client: Depend on GEM object kmap ref-countingdrivers/gpu/drm/drm_client.c+0 -40 replies
4/10drm/fb-helper: Rename dirty worker to damage workerdrivers/gpu/drm/drm_fb_helper.c include/drm/drm_fb_helper.h+36 -431 reply
5/10drm/fb-helper: Return early in dirty workerdrivers/gpu/drm/drm_fb_helper.c+15 -162 replies
6/10drm/fb-helper: Separate shadow-buffer flushing and calling dirty callbackdrivers/gpu/drm/drm_fb_helper.c+1 -31 reply
7/10drm/fb-helper: Move damage blit code and its setup into separate routinedrivers/gpu/drm/drm_fb_helper.c+21 -65 replies
8/10drm/fb-helper: Restore damage area upon errorsdrivers/gpu/drm/drm_fb_helper.c+20 -31 reply
9/10drm/fb-helper: Copy dma-buf map before flushing shadow fbdrivers/gpu/drm/drm_fb_helper.c+3 -21 reply
10/10drm/fb-helper: Acquire modeset lock around shadow-buffer flushingdrivers/gpu/drm/drm_fb_helper.c+18 -21 reply

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSam RavnborgMaxime Ripard
SeriesA-b
1/10A-b
2/10R-b
3/10
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10A-b
9/10A-b
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] drm/fb-helper: Various fixes and cleanups

Here's a number of fb-helper patches that have been piling up recently.

Patches 1 to 3 fix bugs that I spotted while going through the code. Because of the way the fbdev code works, they have been avoided so far.

Patches 4 to 10 cleanup damage handling for fbdev's shadow buffer and fix a few issues.

Specifically, the final patch adds locking to the code that flushes the shadow framebuffer into BO memory. During the conversion of radeon to generic fbdev, the question came up about interference with concurrent modesets. If fbdev has the BO pinned in system memory for flushing while the modeset wants to pin it to VRAM for scanout, the modeset would most likely fail. We haven't seen that so far, but it's possible at least. Acquiring the fb-helper lock during the flush operation prevents concurrent modesets from taking place.

The code has been tested with SHMEM and TTM BOs; with atomic and non- atomic modesetting.

[1] https://patchwork.freedesktop.org/patch/400054/?series=83765&rev=1

Thomas Zimmermann (10):
drm/fb-helper: Call dirty helper after writing to fbdev drm/fb-helper: Unmap client buffer during shutdown drm/client: Depend on GEM object kmap ref-counting drm/fb-helper: Rename dirty worker to damage worker drm/fb-helper: Return early in dirty worker drm/fb-helper: Separate shadow-buffer flushing and calling dirty
callback
drm/fb-helper: Move damage blit code and its setup into separate
routine
drm/fb-helper: Restore damage area upon errors drm/fb-helper: Copy dma-buf map before flushing shadow fb drm/fb-helper: Acquire modeset lock around shadow-buffer flushing

 drivers/gpu/drm/drm_client.c    |   4 -
 drivers/gpu/drm/drm_fb_helper.c | 155 +++++++++++++++++++++-----------
 include/drm/drm_fb_helper.h     |  14 +--
 3 files changed, 108 insertions(+), 65 deletions(-)

--
2.29.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel