Skip to content

Add libfsverity_enable() and default params

Eric Biggers linux-fscrypt 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 5 repliesIn review

Changes in v2 from the cover letter

- Moved the default hash algorithm and block size handling into libfsverity.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4programs/fsverity: change default block size from PAGE_SIZE to 4096programs/cmd_digest.c programs/cmd_enable.c programs/cmd_sign.c +2 more+3 -181 reply
2/4lib/compute_digest: add default hash_algorithm and block_sizeinclude/libfsverity.h lib/compute_digest.c lib/lib_private.h +3 more+71 -441 reply
3/4lib: add libfsverity_enable() and libfsverity_enable_with_sig()include/libfsverity.h lib/enable.c programs/cmd_enable.c +1 more+95 -171 reply
4/4programs/fsverity: share code to parse tree parametersprograms/cmd_digest.c programs/cmd_enable.c programs/cmd_sign.c +2 more+46 -680 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchLuca Boccassi
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [fsverity-utils PATCH v2 0/4] Add libfsverity_enable() and default params

This patchset adds wrappers around FS_IOC_ENABLE_VERITY to libfsverity, makes libfsverity (rather than just the fsverity program) default to SHA-256 and 4096-byte blocks, and makes the fsverity commands share code to parse the libfsverity_merkle_tree_params.

This is my proposed alternative to Luca's patch
https://lkml.kernel.org/linux-fscrypt/[email protected]

Changed since v1:
- Moved the default hash algorithm and block size handling into libfsverity.

Eric Biggers (4):
programs/fsverity: change default block size from PAGE_SIZE to 4096 lib/compute_digest: add default hash_algorithm and block_size
lib: add libfsverity_enable() and libfsverity_enable_with_sig() programs/fsverity: share code to parse tree parameters

 include/libfsverity.h          | 83 +++++++++++++++++++++++++++++-----
 lib/compute_digest.c           | 27 ++++++-----
 lib/enable.c                   | 47 +++++++++++++++++++
 lib/lib_private.h              |  6 +++
 programs/cmd_digest.c          | 31 ++-----------
 programs/cmd_enable.c          | 34 +++-----------
 programs/cmd_sign.c            | 32 ++-----------
 programs/fsverity.c            | 35 ++++++++------
 programs/fsverity.h            | 21 ++++++---
 programs/test_compute_digest.c | 18 +++++---
 10 files changed, 201 insertions(+), 133 deletions(-)
 create mode 100644 lib/enable.c
Signature · 1 line
2.29.2