Skip to content

s390x: Add SIE library and simple tests

Janosch Frank kvm linux-s390 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 20 repliesIn review
  2. v38 patches 26 repliesSuperseded
  3. v27 patches 12 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches10 repliesSuperseded

Changes in v4 from the cover letter

* Removed asm directory and moved all asm files into s390x/ (I changed my view)
* Review fixes
* Removed a stray newline in the asm offsets file

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9s390x: Add test_bit to librarylib/s390x/asm/bitops.h lib/s390x/asm/facility.h s390x/uv-guest.c+31 -41 reply
2/9s390x: Consolidate sclp read infolib/s390x/io.c lib/s390x/sclp.c lib/s390x/sclp.h +1 more+40 -221 reply
3/9s390x: SCLP feature checkinglib/s390x/io.c lib/s390x/sclp.c lib/s390x/sclp.h+38 -12 replies
4/9s390x: Split assembly into multiple filess390x/Makefile s390x/cstart64.S s390x/lib.S +1 more+149 -1184 replies
5/9s390x: sie: Add SIE to liblib/s390x/asm-offsets.c lib/s390x/asm/arch_def.h lib/s390x/interrupt.c +2 more+280 -04 replies
6/9s390x: sie: Add first SIE tests390x/Makefile s390x/sie.c s390x/unittests.cfg+117 -00 replies
7/9s390x: Add diag318 intercept testlib/s390x/sclp.c lib/s390x/sclp.h s390x/intercept.c+25 -11 reply
8/9s390x: Fix sclp.h style issueslib/s390x/sclp.h+86 -860 replies
9/9s390x: sclp: Add CPU entry offset commentlib/s390x/sclp.h+4 -16 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchCornelia HuckThomas HuthClaudio Imbrenda
1/9R-b R-b R-b
2/9R-b A-b R-b
3/9R-b R-b R-b
4/9A-b A-b A-b
5/9A-b R-b
6/9R-b R-b R-b
7/9R-b R-b R-b
8/9R-b A-b R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [kvm-unit-tests PATCH v4 0/9] s390x: Add SIE library and simple tests

This is the absolute minimum needed to run VMs inside the KVM Unit Tests. It's more of a base for other tests that I can't (yet) publish than an addition of tests that check KVM functionality. However, I wanted to decrease the number of WIP patches in my private branch. Once the library is available maybe others will come and extend the SIE test itself.

Yes, I have added VM management functionality like VM create/destroy, etc but as it is not needed right now, I'd like to exclude it from this patch set for now.

v4:
* Removed asm directory and moved all asm files into s390x/ (I changed my view)
* Review fixes
* Removed a stray newline in the asm offsets file

v3:
* Rebased on re-license patches
* Split assembly
* Now using ICPT_* constants
* Added read_info asserts
* Fixed missing spin_lock() in smp.c lib
* Replaced duplicated code in sie test with generic intercept test
* Replaced uv-guest.x bit testing with test_bit_inv()
* Some other minor cleanups

Gitlab:
https://gitlab.com/frankja/kvm-unit-tests/-/tree/sie

CI:
https://gitlab.com/frankja/kvm-unit-tests/-/pipelines/240506525

Janosch Frank (9):
s390x: Add test_bit to library
s390x: Consolidate sclp read info
s390x: SCLP feature checking
s390x: Split assembly into multiple files
s390x: sie: Add SIE to lib
s390x: sie: Add first SIE test
s390x: Add diag318 intercept test
s390x: Fix sclp.h style issues
s390x: sclp: Add CPU entry offset comment

 lib/s390x/asm-offsets.c  |  11 +++
 lib/s390x/asm/arch_def.h |   9 ++
 lib/s390x/asm/bitops.h   |  26 ++++++
 lib/s390x/asm/facility.h |   3 +-
 lib/s390x/interrupt.c    |   7 ++
 lib/s390x/io.c           |   2 +
 lib/s390x/sclp.c         |  57 +++++++++--
 lib/s390x/sclp.h         | 181 +++++++++++++++++++----------------
 lib/s390x/sie.h          | 197 +++++++++++++++++++++++++++++++++++++++
 lib/s390x/smp.c          |  27 +++---
 s390x/Makefile           |   7 +-
 s390x/cstart64.S         | 119 +----------------------
 s390x/intercept.c        |  19 ++++
 s390x/lib.S              | 121 ++++++++++++++++++++++++
 s390x/macros.S           |  77 +++++++++++++++
 s390x/sie.c              | 113 ++++++++++++++++++++++
 s390x/unittests.cfg      |   3 +
 s390x/uv-guest.c         |   6 +-
 18 files changed, 761 insertions(+), 224 deletions(-)
 create mode 100644 lib/s390x/sie.h
 create mode 100644 s390x/lib.S
 create mode 100644 s390x/macros.S
 create mode 100644 s390x/sie.c
Signature · 1 line
2.25.1