Virtio net failover fixes
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest27 patches 30 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/27 | migration: Network Failover can't work with a paused guestmigration/ | +13 | 26 replies | |
| 2/27 | failover: fix indentantionhw/ softmmu/ | +17 | 0 replies | |
| 3/27 | failover: Use always atomics for primary_should_be_hiddenhw/ | +1 | 0 replies | |
| 4/27 | failover: primary bus is only used once, and where it is sethw/ include/ | +4 | 0 replies | |
| 5/27 | failover: Remove unused parameterhw/ | +3 | 0 replies | |
| 6/27 | failover: Remove external partially_hotplugged propertyhw/ | +0 | 0 replies | |
| 7/27 | failover: qdev_device_add() returns err or dev sethw/ | +0 | 0 replies | |
| 8/27 | failover: Rename bool to failover_primary_hiddenhw/ include/ | +9 | 0 replies | |
| 9/27 | failover: g_strcmp0() knows how to handle NULLhw/ | +1 | 0 replies | |
| 10/27 | failover: Remove primary_device_optshw/ include/ | +5 | 0 replies | |
| 11/27 | failover: remove standby_id variablehw/ include/ | +3 | 0 replies | |
| 12/27 | failover: Remove primary_device_dicthw/ include/ | +4 | 0 replies | |
| 13/27 | failover: Remove memory leakhw/ | +1 | 0 replies | |
| 14/27 | failover: simplify virtio_net_find_primary()hw/ | +3 | 0 replies | |
| 15/27 | failover: should_be_hidden() should take a boolhw/ hw/ include/ | +13 | 0 replies | |
| 16/27 | failover: Rename function to hide_device()hw/ hw/ include/ | +20 | 0 replies | |
| 17/27 | failover: virtio_net_connect_failover_devices() does nothinghw/ | +2 | 0 replies | |
| 18/27 | failover: Rename to failover_find_primary_device()hw/ | +9 | 0 replies | |
| 19/27 | failover: simplify qdev_device_add() failover casesoftmmu/ | +8 | 0 replies | |
| 20/27 | failover: simplify qdev_device_add()softmmu/ | +6 | 0 replies | |
| 21/27 | failover: make sure that id always existhw/ softmmu/ | +4 | 0 replies | |
| 22/27 | failover: remove failover_find_primary_device() error parameterhw/ | +3 | 0 replies | |
| 23/27 | failover: split failover_find_primary_device_id()hw/ | +47 | 0 replies | |
| 24/27 | failover: We don't need to cache primary_device_id anymorehw/ include/ | +10 | 0 replies | |
| 25/27 | failover: Caller of this two functions already have primary_devhw/ | +14 | 0 replies | |
| 26/27 | failover: simplify failover_unplug_primaryhw/ | +10 | 0 replies | |
| 27/27 | failover: Remove primary_dev memberhw/ include/ | +24 | 0 replies |
Reviews trailers per patch
1 of 27 patches has a Reviewed-by or Acked-by.
| Patch | Dr. David Alan Gilbert |
|---|---|
| 1/27 | R-b |
| 2/27 | |
| 3/27 | |
| 4/27 | |
| 5/27 | |
| 6/27 | |
| 7/27 | |
| 8/27 | |
| 9/27 | |
| 10/27 | |
| 11/27 | |
| 12/27 | |
| 13/27 | |
| 14/27 | |
| 15/27 | |
| 16/27 | |
| 17/27 | |
| 18/27 | |
| 19/27 | |
| 20/27 | |
| 21/27 | |
| 22/27 | |
| 23/27 | |
| 24/27 | |
| 25/27 | |
| 26/27 | |
| 27/27 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/27] Virtio net failover fixes
Hi
This is a big rework of the network failover setup. General idea is:
* We don't cache the name of the primary/standby devices
We have several problems there with stale pointers
* After this:
- We can always remove either the primary/standby devices without trouble
- Pluggin/unplugging works
- We go to device opts to see what the failover device are. Notice that we are plugging/unplugging the device, so it is not critical.
- Once there, I "fixed" managedsave for libvirt (now gives an error instead o= f just hanging)
* Fields not cached anymore:
- primary_device_dict
- primary_device_opts
- standby_id
- primary_device_id
- primary_dev
* I renamed the should_be_hidden() callback to hide device, but if people preffer the old name I can leave it.
* Add (some) doc to some functions
* Remove almost 100 lines of code while fixing things.
Please review.
Later, Juan.
Juan Quintela (27):
migration: Network Failover can't work with a paused guest
failover: fix indentantion
failover: Use always atomics for primary_should_be_hidden
failover: primary bus is only used once, and where it is set
failover: Remove unused parameter
failover: Remove external partially_hotplugged property
failover: qdev_device_add() returns err or dev set
failover: Rename bool to failover_primary_hidden
failover: g_strcmp0() knows how to handle NULL
failover: Remove primary_device_opts
failover: remove standby_id variable
failover: Remove primary_device_dict
failover: Remove memory leak
failover: simplify virtio_net_find_primary()
failover: should_be_hidden() should take a bool
failover: Rename function to hide_device()
failover: virtio_net_connect_failover_devices() does nothing
failover: Rename to failover_find_primary_device()
failover: simplify qdev_device_add() failover case
failover: simplify qdev_device_add()
failover: make sure that id always exist
failover: remove failover_find_primary_device() error parameter
failover: split failover_find_primary_device_id()
failover: We don't need to cache primary_device_id anymore
failover: Caller of this two functions already have primary_dev
failover: simplify failover_unplug_primary
failover: Remove primary_dev member
include/hw/qdev-core.h | 28 ++-- include/hw/virtio/virtio-net.h | 9 +- hw/core/qdev.c | 19 +-- hw/net/virtio-net.c | 298 +++++++++++++-------------------- migration/migration.c | 13 ++ softmmu/qdev-monitor.c | 43 ++--- 6 files changed, 167 insertions(+), 243 deletions(-)
--=20
2.26.2