Skip to content

Linux CCS driver preparation

Sakari Ailus linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest29 patches 2 repliesIn review
  2. v129 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Fix the SPDX tag in mk-ccs-regs script

- Add support for producing kernel definitions including use of BIT macro and kernel types in mk-ccs-regs (was C99 only)

- Add MAINTAINERS entry for the documentation in the first documentation patch.

- Fix compilation issues due to ccs-limits.o missing from Makefile in a few patches early in the set.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29ccs: Add the generator for CCS register definitions and limitsDocumentation/driver-api/media/drivers/ccs/ccs-regs.txt Documentation/driver-api/media/drivers/ccs/mk-ccs-regs MAINTAINERS+1475 -02 replies
2/29Documentation: ccs: Add CCS driver documentationDocumentation/driver-api/media/drivers/ccs/ccs.rst Documentation/driver-api/media/drivers/index.rst+83 -00 replies
3/29smiapp: Import CCS definitionsdrivers/media/i2c/smiapp/ccs-limits.c drivers/media/i2c/smiapp/ccs-limits.h drivers/media/i2c/smiapp/ccs-regs.h+1452 -00 replies
4/29smiapp: Use CCS register flagsdrivers/media/i2c/smiapp/smiapp-reg-defs.h drivers/media/i2c/smiapp/smiapp-regs.c drivers/media/i2c/smiapp/smiapp-regs.h+21 -200 replies
5/29smiapp: Calculate CCS limit offsets and limit buffer sizedrivers/media/i2c/smiapp/Makefile drivers/media/i2c/smiapp/smiapp-core.c+40 -20 replies
6/29smiapp: Remove macros for defining registers, merge definitionsdrivers/media/i2c/smiapp/smiapp-quirk.c drivers/media/i2c/smiapp/smiapp-reg-defs.h drivers/media/i2c/smiapp/smiapp-reg.h +1 more+570 -5960 replies
7/29smiapp: Add macros for accessing CCS registersdrivers/media/i2c/smiapp/smiapp-regs.h+6 -00 replies
8/29smiapp: Use MIPI CCS version and manufacturer ID informationdrivers/media/i2c/smiapp/smiapp-core.c drivers/media/i2c/smiapp/smiapp.h+68 -280 replies
9/29smiapp: Read CCS limit valuesdrivers/media/i2c/smiapp/smiapp-core.c drivers/media/i2c/smiapp/smiapp.h+176 -50 replies
10/29smiapp: Switch to CCS limitsdrivers/media/i2c/smiapp/Makefile drivers/media/i2c/smiapp/smiapp-core.c drivers/media/i2c/smiapp/smiapp-limits.c +4 more+113 -4140 replies
11/29smiapp: Obtain frame descriptor from CCS limitsdrivers/media/i2c/smiapp/smiapp-core.c+30 -400 replies
12/29smiapp: Use CCS limits in reading data format descriptorsdrivers/media/i2c/smiapp/smiapp-core.c+9 -130 replies
13/29smiapp: Use CCS limits in reading binning capabilitiesdrivers/media/i2c/smiapp/smiapp-core.c+9 -180 replies
14/29smiapp: Use CCS registersdrivers/media/i2c/smiapp/smiapp-core.c drivers/media/i2c/smiapp/smiapp.h+118 -1580 replies
15/29smiapp: Remove quirk function for writing a single 8-bit registerdrivers/media/i2c/smiapp/smiapp-quirk.c+5 -100 replies
16/29smiapp: Rename register access functionsdrivers/media/i2c/smiapp/smiapp-core.c drivers/media/i2c/smiapp/smiapp-quirk.c drivers/media/i2c/smiapp/smiapp-regs.c +1 more+76 -740 replies
17/29smiapp: Internal rename to CCSdrivers/media/i2c/smiapp/Makefile drivers/media/i2c/smiapp/ccs-core.c drivers/media/i2c/smiapp/ccs-quirk.c +4 more+576 -5860 replies
18/29smiapp: Differentiate CCS sensors from SMIA in subdev namingdrivers/media/i2c/smiapp/ccs-core.c+5 -40 replies
19/29smiapp: Rename as "ccs"MAINTAINERS drivers/media/i2c/Kconfig drivers/media/i2c/Makefile +12 more+39 -300 replies
20/29ccs: Remove profile conceptdrivers/media/i2c/ccs/ccs-core.c drivers/media/i2c/ccs/ccs.h+6 -190 replies
21/29ccs: Give all subdevs a functiondrivers/media/i2c/ccs/ccs-core.c+8 -60 replies
22/29dt-bindings: nokia,smia: Fix link-frequencies documentationDocumentation/devicetree/bindings/media/i2c/nokia,smia.txt+5 -30 replies
23/29dt-bindings: nokia,smia: Make vana-supply optionalDocumentation/devicetree/bindings/media/i2c/nokia,smia.txt+2 -20 replies
24/29dt-bindings: nokia,smia: Remove nokia,nvm-size propertyDocumentation/devicetree/bindings/media/i2c/nokia,smia.txt+0 -10 replies
25/29dt-bindings: nokia,smia: Convert to YAMLDocumentation/devicetree/bindings/media/i2c/nokia,smia.txt Documentation/devicetree/bindings/media/i2c/nokia,smia.yaml MAINTAINERS+107 -680 replies
26/29dt-bindings: nokia,smia: Use better active polarity for resetDocumentation/devicetree/bindings/media/i2c/nokia,smia.yaml+3 -10 replies
27/29dt-bindings: nokia,smia: Amend SMIA bindings with MIPI CCS supportDocumentation/devicetree/bindings/media/i2c/mipi-ccs.yaml MAINTAINERS+18 -70 replies
28/29dt-bindings: mipi-ccs: Add bus-type for C-PHY supportDocumentation/devicetree/bindings/media/i2c/mipi-ccs.yaml+9 -00 replies
29/29ccs: Request for "reset" GPIOdrivers/media/i2c/ccs/ccs-core.c drivers/media/i2c/ccs/ccs.h+13 -20 replies

Reviews trailers per patch

7 of 29 patches have a Reviewed-by or Acked-by.

PatchRob Herring
1/29
2/29
3/29
4/29
5/29
6/29
7/29
8/29
9/29
10/29
11/29
12/29
13/29
14/29
15/29
16/29
17/29
18/29
19/29
20/29
21/29
22/29A-b
23/29A-b
24/29A-b
25/29R-b
26/29A-b
27/29R-b
28/29R-b
29/29

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/29] Linux CCS driver preparation

Hello everyone,

Here's a set of patches that turn the existing SMIA driver into a MIPI CCS driver while maintaining SMIA support. A number of bugs in the existing code are fixed in this set, too.

The changes at this point are primarily focused on dealing with new mandatory driver features related to PLL configuration (as CCS allows for much more variation there) and things such as integer conversion from U16.U16 format instead of float. There are some other new features as well such as digital gain and support for getting device specific analogue gain coefficients.

A new feature in CCS is CCS static data which makes it possible to obtain sensor's capabilities and limits from a file chosen based on sensor identification. CCS static data is used also for storing MSR registers so supporting new, CCS compliant devices requires no driver changes.

Note that the library as well as the register definitions are dual licensed under GNU GPL v2 OR BSD 3-clause licenses for use outside the Linux kernel.

Also DT bindings are updated accordingly and converted to YAML format.

More information on MIPI CCS can be found here:

<URL:https://www.mipi.org/specifications/camera-command-set>

Comments are welcome.

since v1:

- Fix the SPDX tag in mk-ccs-regs script

- Add support for producing kernel definitions including use of BIT macro and kernel types in mk-ccs-regs (was C99 only)

- Add MAINTAINERS entry for the documentation in the first documentation patch.

- Fix compilation issues due to ccs-limits.o missing from Makefile in a few patches early in the set.

since the big, big patchset (v2):

- Split into more easily reviewable chunks (this is the first of maybe three). The cover page describes the entire big set. This set contains mostly cleanups for the smiapp driver that prepare for support for additional features as well as DT bindings, as well as using CCS limits.

- Fix SPDX tags. Some were left accidentally with BSD-3-Clause license only.

- Fix bus-type alignment in DT bindings.

- Add CCS driver documentation

- Add -u option to the CCS register definition generator.

- Add static keyword for ccs_limit_offset array.

- Add generated CCS register definitions, and do not generate the definitions as part of the build process.

- Remove ccs-os.h header.

Sakari Ailus (29):
ccs: Add the generator for CCS register definitions and limits
Documentation: ccs: Add CCS driver documentation
smiapp: Import CCS definitions
smiapp: Use CCS register flags
smiapp: Calculate CCS limit offsets and limit buffer size
smiapp: Remove macros for defining registers, merge definitions
smiapp: Add macros for accessing CCS registers
smiapp: Use MIPI CCS version and manufacturer ID information
smiapp: Read CCS limit values
smiapp: Switch to CCS limits
smiapp: Obtain frame descriptor from CCS limits
smiapp: Use CCS limits in reading data format descriptors
smiapp: Use CCS limits in reading binning capabilities
smiapp: Use CCS registers
smiapp: Remove quirk function for writing a single 8-bit register
smiapp: Rename register access functions
smiapp: Internal rename to CCS
smiapp: Differentiate CCS sensors from SMIA in subdev naming
smiapp: Rename as "ccs"
ccs: Remove profile concept
ccs: Give all subdevs a function
dt-bindings: nokia,smia: Fix link-frequencies documentation
dt-bindings: nokia,smia: Make vana-supply optional
dt-bindings: nokia,smia: Remove nokia,nvm-size property
dt-bindings: nokia,smia: Convert to YAML
dt-bindings: nokia,smia: Use better active polarity for reset
dt-bindings: nokia,smia: Amend SMIA bindings with MIPI CCS support
dt-bindings: mipi-ccs: Add bus-type for C-PHY support
ccs: Request for "reset" GPIO

 .../bindings/media/i2c/mipi-ccs.yaml          |  128 ++
 .../bindings/media/i2c/nokia,smia.txt         |   66 -
 .../driver-api/media/drivers/ccs/ccs-regs.txt | 1041 ++++++++++
 .../driver-api/media/drivers/ccs/ccs.rst      |   82 +
 .../driver-api/media/drivers/ccs/mk-ccs-regs  |  433 ++++
 .../driver-api/media/drivers/index.rst        |    1 +
 MAINTAINERS                                   |   21 +-
 drivers/media/i2c/Kconfig                     |    2 +-
 drivers/media/i2c/Makefile                    |    2 +-
 drivers/media/i2c/{smiapp => ccs}/Kconfig     |    7 +-
 drivers/media/i2c/ccs/Makefile                |    6 +
 .../{smiapp/smiapp-core.c => ccs/ccs-core.c}  | 1828 +++++++++--------
 drivers/media/i2c/ccs/ccs-limits.c            |  239 +++
 drivers/media/i2c/ccs/ccs-limits.h            |  259 +++
 .../smiapp-quirk.c => ccs/ccs-quirk.c}        |   92 +-
 .../smiapp-quirk.h => ccs/ccs-quirk.h}        |   52 +-
 .../smiapp-regs.c => ccs/ccs-reg-access.c}    |   85 +-
 drivers/media/i2c/ccs/ccs-reg-access.h        |   38 +
 drivers/media/i2c/ccs/ccs-regs.h              |  954 +++++++++
 .../media/i2c/{smiapp/smiapp.h => ccs/ccs.h}  |  164 +-
 drivers/media/i2c/ccs/smiapp-reg-defs.h       |  580 ++++++
 drivers/media/i2c/smiapp/Makefile             |    6 -
 drivers/media/i2c/smiapp/smiapp-limits.c      |  118 --
 drivers/media/i2c/smiapp/smiapp-limits.h      |  114 -
 drivers/media/i2c/smiapp/smiapp-reg-defs.h    |  489 -----
 drivers/media/i2c/smiapp/smiapp-reg.h         |  116 --
 drivers/media/i2c/smiapp/smiapp-regs.h        |   36 -
 27 files changed, 4947 insertions(+), 2012 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/nokia,smia.txt
 create mode 100644 Documentation/driver-api/media/drivers/ccs/ccs-regs.txt
 create mode 100644 Documentation/driver-api/media/drivers/ccs/ccs.rst
 create mode 100755 Documentation/driver-api/media/drivers/ccs/mk-ccs-regs
 rename drivers/media/i2c/{smiapp => ccs}/Kconfig (55%)
 create mode 100644 drivers/media/i2c/ccs/Makefile
 rename drivers/media/i2c/{smiapp/smiapp-core.c => ccs/ccs-core.c} (53%)
 create mode 100644 drivers/media/i2c/ccs/ccs-limits.c
 create mode 100644 drivers/media/i2c/ccs/ccs-limits.h
 rename drivers/media/i2c/{smiapp/smiapp-quirk.c => ccs/ccs-quirk.c} (66%)
 rename drivers/media/i2c/{smiapp/smiapp-quirk.h => ccs/ccs-quirk.h} (55%)
 rename drivers/media/i2c/{smiapp/smiapp-regs.c => ccs/ccs-reg-access.c} (66%)
 create mode 100644 drivers/media/i2c/ccs/ccs-reg-access.h
 create mode 100644 drivers/media/i2c/ccs/ccs-regs.h
 rename drivers/media/i2c/{smiapp/smiapp.h => ccs/ccs.h} (57%)
 create mode 100644 drivers/media/i2c/ccs/smiapp-reg-defs.h
 delete mode 100644 drivers/media/i2c/smiapp/Makefile
 delete mode 100644 drivers/media/i2c/smiapp/smiapp-limits.c
 delete mode 100644 drivers/media/i2c/smiapp/smiapp-limits.h
 delete mode 100644 drivers/media/i2c/smiapp/smiapp-reg-defs.h
 delete mode 100644 drivers/media/i2c/smiapp/smiapp-reg.h
 delete mode 100644 drivers/media/i2c/smiapp/smiapp-regs.h
Signature · 1 line
2.27.0