Skip to content

RFC usb: typec: Product Type time

Heikki Krogerus linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3usb: pd: DFP product typesinclude/linux/usb/pd_vdo.h+13 -30 replies
2/3usb: typec: Add product_type sysfs attribute file for partners and cablesDocumentation/ABI/testing/sysfs-class-typec drivers/usb/typec/class.c+180 -77 replies
3/3usb: typec: Expose Product Type VDOs via sysfsdrivers/usb/typec/class.c+41 -02 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchPrashant Malani
1/3
2/3T-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/3] usb: typec: Product Type time

Hi Prashant,

The original discussion [1].

This proposal is in practice a compromise. I came to the conclusion that we probable should expose the product type separately after all. The reason for that is because we may in some cases actually know the product type even when we don't have access to the Discover Identity response. UCSI for example in practice gives us at least the cable product type even though it does not let us know the response to the Discover Identity command.

So my proposal here is that we add an attribute for the product type itself, showing the product type as a string. Then we also add the attribute for the product type specific VDOs which we place under the identity directory more or less the way you originally proposed.

Note. I have not tested these at all.

[1] https://lore.kernel.org/linux-usb/[email protected]/

Heikki Krogerus (2):
usb: pd: DFP product types
usb: typec: Add product_type sysfs attribute file for partners and
cables

Prashant Malani (1):
usb: typec: Expose Product Type VDOs via sysfs

 Documentation/ABI/testing/sysfs-class-typec |  55 +++++++
 drivers/usb/typec/class.c                   | 173 +++++++++++++++++++-
 include/linux/usb/pd_vdo.h                  |  16 +-
 3 files changed, 234 insertions(+), 10 deletions(-)
Signature · 1 line
2.29.2