Skip to content

MediaTek IOMMU improve tlb flush performance in map/unmap

Yong Wu linux-arm-kernel linux-iommu linux-mediatek lkml 3 versions – Applied

Status from this message: Applied to will (for-joerg/mtk), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 7 repliesApplied
  2. v37 patches 15 repliesSuperseded
  3. v26 patches 6 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/7iommu: Move iotlb_sync_map out from __iommu_mapdrivers/iommu/iommu.c+18 -51 reply
2/7iommu: Add iova and size as parameters in iotlb_sync_mapdrivers/iommu/iommu.c drivers/iommu/tegra-gart.c include/linux/iommu.h+9 -50 replies
3/7iommu/mediatek: Add iotlb_sync_map to sync whole the iova rangedrivers/iommu/mtk_iommu.c+9 -10 replies
4/7iommu: Switch gather->end to the inclusive enddrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c drivers/iommu/mtk_iommu.c drivers/iommu/tegra-gart.c +1 more+5 -51 reply
5/7iommu/io-pgtable: Allow io_pgtable_tlb ops optionalinclude/linux/io-pgtable.h+5 -31 reply
6/7iommu/mediatek: Gather iova in iommu_unmap to achieve tlb sync oncedrivers/iommu/mtk_iommu.c+5 -31 reply
7/7iommu/mediatek: Remove the tlb-ops for v7sdrivers/iommu/mtk_iommu.c+4 -231 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRobin MurphyWill Deacon
SeriesA-b
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] MediaTek IOMMU improve tlb flush performance in map/unmap

This patchset is to improve tlb flushing performance in iommu_map/unmap for MediaTek IOMMU.

For iommu_map, currently MediaTek IOMMU use IO_PGTABLE_QUIRK_TLBI_ON_MAP to do tlb_flush for each a memory chunk. this is so unnecessary. we could improve it by tlb flushing one time at the end of iommu_map.

For iommu_unmap, currently we have already improve this performance by gather. But the current gather should take care its granule size. if the granule size is different, it will do tlb flush and gather again. Our HW don't care about granule size. thus I gather the range in our file.

After this patchset, we could achieve only tlb flushing once in iommu_map and iommu_unmap.

Regardless of sg, for each a segment, I did a simple test:

  size = 20 * SZ_1M;
  /* the worst case, all are 4k mapping. */
  ret = iommu_map(domain, 0x5bb02000, 0x123f1000, size, IOMMU_READ);
  iommu_unmap(domain, 0x5bb02000, size);

This is the comparing time(unit is us):
original-time after-improve

   map-20M    59943           2347
   unmap-20M  264             36

This patchset also flush tlb once in the iommu_map_sg case.

patch [1/7][2/7][3/7] are for map while the others are for unmap.

change note:
v4: a. base on v5.11-rc1.
b. Add a little helper _iommu_map.
c. Fix a build fail for tegra-gart.c. I didn't notice there is another place call gart_iommu_sync_map.
d. Switch gather->end to the read end address("start + end - 1").

v3: https://lore.kernel.org/linux-iommu/[email protected]/#r
Refactor the unmap flow suggested by Robin.

v2: https://lore.kernel.org/linux-iommu/[email protected]/
Refactor all the code.
base on v5.10-rc1.

Yong Wu (7):
iommu: Move iotlb_sync_map out from __iommu_map
iommu: Add iova and size as parameters in iotlb_sync_map iommu/mediatek: Add iotlb_sync_map to sync whole the iova range
iommu: Switch gather->end to the inclusive end iommu/io-pgtable: Allow io_pgtable_tlb ops optional iommu/mediatek: Gather iova in iommu_unmap to achieve tlb sync once iommu/mediatek: Remove the tlb-ops for v7s

 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |  2 +-
 drivers/iommu/iommu.c                       | 23 +++++++---
 drivers/iommu/mtk_iommu.c                   | 47 +++++++++------------
 drivers/iommu/tegra-gart.c                  |  7 ++-
 include/linux/io-pgtable.h                  |  8 ++--
 include/linux/iommu.h                       |  7 +--
 6 files changed, 52 insertions(+), 42 deletions(-)
Signature · 7 lines
2.18.0


_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu