Skip to content

RFC fix tracing for modules

Gerd Hoffmann qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 RFC Latest13 patches 10 repliesIn review
  2. v3 RFC8 patches 25 repliesSuperseded
  3. v2 RFC4 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC4 patches16 repliesSuperseded

Changes in v4 from the cover letter

- rebase to latest master.
- fix systemtap tracing.
- also cover virtio-gpu modules.
- pick up some review tags.
- misc minor tweaks.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful.scripts/qemu-trace-stap+4 -102 replies
2/13trace: iter init tweaksmonitor/misc.c trace/control-target.c trace/control.c +3 more+31 -160 replies
3/13trace: add trace_event_iter_init_grouptrace/control.c trace/control.h+29 -30 replies
4/13trace/simple: pass iter to st_write_event_mappingtrace/simple.c+5 -50 replies
5/13trace/simple: add st_init_grouptrace/control.c trace/simple.c trace/simple.h+17 -00 replies
6/13meson: add trace_events_config[]meson.build trace/meson.build+16 -30 replies
7/13meson: move up hw subdir (specifically before trace subdir)meson.build+4 -11 reply
8/13meson: add module_trace & module_trace_srcmeson.build trace/meson.build+16 -60 replies
9/13trace/stap: build stap files for modulesmeson.build trace/meson.build+35 -21 reply
10/13meson: move qxl trace events to separate filehw/display/meson.build hw/display/qxl-render.c hw/display/qxl.c +3 more+73 -690 replies
11/13virtio-gpu: split trace pointshw/display/trace-events hw/display/virtio-gpu-virgl.c+43 -351 reply
12/13meson: move virtio trace events to separate filehw/display/meson.build hw/display/trace-events hw/display/trace-events-virtio +3 more+23 -191 reply
13/13meson: move virtio-gl trace events to separate filehw/display/meson.build hw/display/trace-events hw/display/trace-events-virtio-gl +2 more+24 -201 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchStefan HajnocziDaniel P. Berrangé
1/13R-b R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/13] [RfC] fix tracing for modules

First version that actually works. Only qxl covered for this RfC, other modules will follow once the basics are hashed out.

v4:
- rebase to latest master.
- fix systemtap tracing.
- also cover virtio-gpu modules.
- pick up some review tags.
- misc minor tweaks.

v3:
- handle initialization of modular tracepoints.

TODO:
Enabling modular tracepoints via -trace cmd line doesn't work yet. Guess we need to store the list somewhere for later re-processing. Error handling is tricky, specifically the "tracepoint doesn't exist" error. Suggestions / ideas are welcome.

More context:
https://bugzilla.redhat.com/show_bug.cgi?id=1898700
https://bugzilla.redhat.com/show_bug.cgi?id=1869642

take care,
Gerd

Gerd Hoffmann (13):
qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful.
trace: iter init tweaks
trace: add trace_event_iter_init_group
trace/simple: pass iter to st_write_event_mapping trace/simple: add st_init_group
meson: add trace_events_config[]
meson: move up hw subdir (specifically before trace subdir)
meson: add module_trace & module_trace_src trace/stap: build stap files for modules
meson: move qxl trace events to separate file
virtio-gpu: split trace points
meson: move virtio trace events to separate file
meson: move virtio-gl trace events to separate file

 hw/display/trace-qxl.h            |  1 +
 hw/display/trace-virtio-gl.h      |  1 +
 hw/display/trace-virtio.h         |  1 +
 trace/control.h                   | 30 ++++++++--
 trace/simple.h                    |  1 +
 hw/display/qxl-render.c           |  2 +-
 hw/display/qxl.c                  |  2 +-
 hw/display/virtio-gpu-base.c      |  2 +-
 hw/display/virtio-gpu-virgl.c     | 50 ++++++++--------
 hw/display/virtio-gpu.c           |  2 +-
 monitor/misc.c                    |  4 +-
 trace/control-target.c            |  2 +-
 trace/control.c                   | 39 ++++++++++---
 trace/qmp.c                       |  6 +-
 trace/simple.c                    | 22 +++++--
 hw/display/meson.build            | 12 ++++
 hw/display/trace-events           | 95 -------------------------------
 hw/display/trace-events-qxl       | 66 +++++++++++++++++++++
 hw/display/trace-events-virtio    | 16 ++++++
 hw/display/trace-events-virtio-gl | 18 ++++++
 meson.build                       | 43 +++++++++++++-
 scripts/qemu-trace-stap           | 14 ++---
 trace/meson.build                 | 36 +++++++++---
 23 files changed, 298 insertions(+), 167 deletions(-)
 create mode 100644 hw/display/trace-qxl.h
 create mode 100644 hw/display/trace-virtio-gl.h
 create mode 100644 hw/display/trace-virtio.h
 create mode 100644 hw/display/trace-events-qxl
 create mode 100644 hw/display/trace-events-virtio
 create mode 100644 hw/display/trace-events-virtio-gl
Signature · 1 line
2.31.1