RFC fix tracing for modules
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 RFC Latest13 patches 10 repliesIn review
- v3 RFC8 patches 25 repliesSuperseded
- v2 RFC4 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 4 patches | 16 replies | Superseded |
Changes in v4 from the cover letter
- rebase to latest master.
- fix systemtap tracing.
- also cover virtio-gpu modules.
- pick up some review tags.
- misc minor tweaks.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful.scripts/ | +4 | 2 replies | |
| 2/13 | trace: iter init tweaksmonitor/ trace/ trace/ +3 more | +31 | 0 replies | |
| 3/13 | trace: add trace_event_iter_init_grouptrace/ trace/ | +29 | 0 replies | |
| 4/13 | trace/simple: pass iter to st_write_event_mappingtrace/ | +5 | 0 replies | |
| 5/13 | trace/simple: add st_init_grouptrace/ trace/ trace/ | +17 | 0 replies | |
| 6/13 | meson: add trace_events_config[]meson.build trace/ | +16 | 0 replies | |
| 7/13 | meson: move up hw subdir (specifically before trace subdir)meson.build | +4 | 1 reply | |
| 8/13 | meson: add module_trace & module_trace_srcmeson.build trace/ | +16 | 0 replies | |
| 9/13 | trace/stap: build stap files for modulesmeson.build trace/ | +35 | 1 reply | |
| 10/13 | meson: move qxl trace events to separate filehw/ hw/ hw/ +3 more | +73 | 0 replies | |
| 11/13 | virtio-gpu: split trace pointshw/ hw/ | +43 | 1 reply | |
| 12/13 | meson: move virtio trace events to separate filehw/ hw/ hw/ +3 more | +23 | 1 reply | |
| 13/13 | meson: move virtio-gl trace events to separate filehw/ hw/ hw/ +2 more | +24 | 1 reply |
Reviews trailers per patch
All 13 patches have a Reviewed-by or Acked-by.
| Patch | Stefan Hajnoczi | Daniel P. Berrangé |
|---|---|---|
| 1/13 | R-b | R-b |
| 2/13 | R-b | |
| 3/13 | R-b | |
| 4/13 | R-b | |
| 5/13 | R-b | |
| 6/13 | R-b | |
| 7/13 | R-b | |
| 8/13 | R-b | |
| 9/13 | R-b | |
| 10/13 | R-b | |
| 11/13 | R-b | |
| 12/13 | R-b | |
| 13/13 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/13] [RfC] fix tracing for modules
First version that actually works. Only qxl covered for this RfC, other modules will follow once the basics are hashed out.
v4:
- rebase to latest master.
- fix systemtap tracing.
- also cover virtio-gpu modules.
- pick up some review tags.
- misc minor tweaks.
v3:
- handle initialization of modular tracepoints.
TODO:
Enabling modular tracepoints via -trace cmd line doesn't work yet. Guess we need to store the list somewhere for later re-processing. Error handling is tricky, specifically the "tracepoint doesn't exist" error. Suggestions / ideas are welcome.
More context:
https://bugzilla.redhat.com/show_bug.cgi?id=1898700
https://bugzilla.redhat.com/show_bug.cgi?id=1869642
take care,
Gerd
Gerd Hoffmann (13):
qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful.
trace: iter init tweaks
trace: add trace_event_iter_init_group
trace/simple: pass iter to st_write_event_mapping trace/simple: add st_init_group
meson: add trace_events_config[]
meson: move up hw subdir (specifically before trace subdir)
meson: add module_trace & module_trace_src trace/stap: build stap files for modules
meson: move qxl trace events to separate file
virtio-gpu: split trace points
meson: move virtio trace events to separate file
meson: move virtio-gl trace events to separate file
hw/display/trace-qxl.h | 1 + hw/display/trace-virtio-gl.h | 1 + hw/display/trace-virtio.h | 1 + trace/control.h | 30 ++++++++-- trace/simple.h | 1 + hw/display/qxl-render.c | 2 +- hw/display/qxl.c | 2 +- hw/display/virtio-gpu-base.c | 2 +- hw/display/virtio-gpu-virgl.c | 50 ++++++++-------- hw/display/virtio-gpu.c | 2 +- monitor/misc.c | 4 +- trace/control-target.c | 2 +- trace/control.c | 39 ++++++++++--- trace/qmp.c | 6 +- trace/simple.c | 22 +++++-- hw/display/meson.build | 12 ++++ hw/display/trace-events | 95 ------------------------------- hw/display/trace-events-qxl | 66 +++++++++++++++++++++ hw/display/trace-events-virtio | 16 ++++++ hw/display/trace-events-virtio-gl | 18 ++++++ meson.build | 43 +++++++++++++- scripts/qemu-trace-stap | 14 ++--- trace/meson.build | 36 +++++++++--- 23 files changed, 298 insertions(+), 167 deletions(-) create mode 100644 hw/display/trace-qxl.h create mode 100644 hw/display/trace-virtio-gl.h create mode 100644 hw/display/trace-virtio.h create mode 100644 hw/display/trace-events-qxl create mode 100644 hw/display/trace-events-virtio create mode 100644 hw/display/trace-events-virtio-gl
Signature · 1 line
2.31.1