Skip to content

Add function to dump block layer for debugging

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4block: bdrv_get_xdbg_block_graph() drop unused errp argumentblock.c blockdev.c include/block/block.h+3 -30 replies
2/4blockjob: add block_jobs_info_list()blockdev.c blockjob.c include/block/blockjob.h+37 -250 replies
3/4block: add dbg_dump_block_layer()block.c include/block/block.h qapi/block-core.json+66 -11 reply
4/4scripts/render_block_graph.py: add ability to parse json filesMAINTAINERS scripts/render_block_graph.py+39 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Add function to dump block layer for debugging

Hi all!

Here is a new function dbg_dump_block_layer() to help with block layer code debugging.

Usage:

1. Add dbg_dump_block_layer("/path/to/dump.json") call in some place were you are trying to understand the relations in block graph and run your test. Or just call dbg_dump_block_layer("/path/to/dump.json") from gdb session if attached to running Qemu.

2. Convert json to png image:

.scripts/render_block_graph.py --json /path/to/dump.json /path/to/out

And get your /path/to/out dot file and /path/to/out.png image.

Vladimir Sementsov-Ogievskiy (4):
block: bdrv_get_xdbg_block_graph() drop unused errp argument
blockjob: add block_jobs_info_list()
block: add dbg_dump_block_layer() scripts/render_block_graph.py: add ability to parse json files

 qapi/block-core.json          | 13 +++++++++
 include/block/block.h         |  5 +++-
 include/block/blockjob.h      |  7 +++++
 block.c                       | 53 +++++++++++++++++++++++++++++++++--
 blockdev.c                    | 28 ++----------------
 blockjob.c                    | 29 +++++++++++++++++++
 MAINTAINERS                   |  5 ++++
 scripts/render_block_graph.py | 53 ++++++++++++++++++++++-------------
 8 files changed, 145 insertions(+), 48 deletions(-)
Signature · 1 line
2.21.3