pc-bios/s390 fixes for reboot-to-vfio-ccw
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 4 repliesIn review
- v12 patches 9 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | pc-bios: s390x: Ensure Read IPL memory is cleanpc-bios/ | +3 | 0 replies | |
| 2/2 | pc-bios: s390x: Clear out leftover S390EP stringpc-bios/ pc-bios/ pc-bios/ | +10 | 4 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Jason J. Herne | Christian Borntraeger | Janosch Frank | Cornelia Huck |
|---|---|---|---|---|
| 1/2 | R-b | A-b | R-b | A-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/2] pc-bios/s390 fixes for reboot-to-vfio-ccw
Thomas, Conny,
Here is the updated series for the re-IPL fixes mentioned yesterday [1]
I've updated the reviews/acks to Patch 1 (Thank you Conny, Janosch!), and implemented Thomas' suggestion to clear out the memory where S390EP exists early in our processing. This both preserves the delicate balance we have today, and fixes the scenario I've been wrestling with.
For this second patch, I opted to #define the address x10008 and use it in both the new memset and existing memcmp, rather than having the address used directly in two places. I put this definition in s390-arch.h as it's shared by both files, even though it's not strictly an "s390 architecture" thing. Considering its importance, it seems like a reasonable fit.
Tested with my permutations of virtio/vfio/chreipl/install things, but surely missing some others that I don't have readily configured.
[1] https://lore.kernel.org/qemu-devel/[email protected]/
Eric Farman (2):
pc-bios: s390x: Ensure Read IPL memory is clean
pc-bios: s390x: Clear out leftover S390EP string
pc-bios/s390-ccw/dasd-ipl.c | 3 +++ pc-bios/s390-ccw/jump2ipl.c | 2 +- pc-bios/s390-ccw/main.c | 6 ++++++ pc-bios/s390-ccw/s390-arch.h | 3 +++ 4 files changed, 13 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1