Skip to content

net: ipa: add a driver shutdown callback

Alex Elder lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesApplied 6/6

Patches in v1 All 6 applied

#Subject and filesSizeRepliesApplied
1/6net: ipa: print channel/event ring number on errordrivers/net/ipa/gsi.c+32 -220 repliesApplied
2/6net: ipa: don't reset an ALLOCATED channeldrivers/net/ipa/gsi.c+4 -20 repliesApplied
3/6net: ipa: ignore CHANNEL_NOT_RUNNING errorsdrivers/net/ipa/gsi.c+23 -10 repliesApplied
4/6net: ipa: support retries on generic GSI commandsdrivers/net/ipa/gsi.c drivers/net/ipa/gsi.h+20 -23 repliesApplied
5/6net: ipa: retry modem stop if busydrivers/net/ipa/ipa_main.c+5 -00 repliesApplied
6/6net: ipa: add driver shutdown callbackdrivers/net/ipa/ipa_main.c+12 -20 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/6] net: ipa: add a driver shutdown callback

The final patch in this series adds a driver shutdown callback for the IPA driver. The patches leading up to that address some issues encountered while ensuring that callback worked as expected:
- The first just reports a little more information when channels or event rings are in unexpected states
- The second patch recognizes a condition where an as-yet-unused channel does not require a reset during teardown
- The third patch explicitly ignores a certain error condition, because it can't be avoided, and is harmless if it occurs
- The fourth properly handles requests to retry a channel HALT request
- The fifth makes a second attempt to stop modem activity during shutdown if it's busy

The shutdown callback is implemented by calling the existing remove callback function (reporting if that returns an error).

-Alex

Alex Elder (6):
net: ipa: print channel/event ring number on error
net: ipa: don't reset an ALLOCATED channel
net: ipa: ignore CHANNEL_NOT_RUNNING errors
net: ipa: support retries on generic GSI commands
net: ipa: retry modem stop if busy
net: ipa: add driver shutdown callback

 drivers/net/ipa/gsi.c      | 101 ++++++++++++++++++++++++++++---------
 drivers/net/ipa/gsi.h      |   1 +
 drivers/net/ipa/ipa_main.c |  19 ++++++-
 3 files changed, 94 insertions(+), 27 deletions(-)
Signature · 1 line
2.20.1