Skip to content

More meson HDMI fixes

Marc Zyngier dri-devel linux-amlogic linux-arm-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/meson: dw-hdmi: Disable clocks on driver teardowndrivers/gpu/drm/meson/meson_dw_hdmi.c+29 -143 replies
2/2drm/meson: dw-hdmi: Enable the iahb clock early enoughdrivers/gpu/drm/meson/meson_dw_hdmi.c+6 -24 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchGuillaume TuckerNeil Armstrong
1/2R-b
2/2T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] More meson HDMI fixes

Guillaume reported that my earlier fixes for the meson HDMI driver broke another set of machines which are now exploding (clock not enabled).

I have thus reconsidered the approach and came up with an alternative fix (enable a missing clock), which Guillaume confirmed to be working. Jerome pointed out that this driver is leaking clock references like a sieve, so that needed addressing too.

The first patch start by fixing the clock leakage using a devm facility.

The second patch addresses the earlier crash by reusing the infrastructure put together in the first patch.

Tested on VIM3l.

Marc Zyngier (2):
drm/meson: dw-hdmi: Disable clocks on driver teardown drm/meson: dw-hdmi: Enable the iahb clock early enough

 drivers/gpu/drm/meson/meson_dw_hdmi.c | 51 ++++++++++++++++++---------
 1 file changed, 35 insertions(+), 16 deletions(-)
Signature · 6 lines
2.28.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel