Skip to content

Upgrade the OpenGL wrapper for KernelShark v2.0

Yordan Karadzhov (VMware) linux-trace-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4kernel-shark: Add support for drawing textCMakeLists.txt Documentation/doxygen/dox_config src/CMakeLists.txt +3 more+5312 -114 replies
2/4kernel-shark: Make GLUT optional dependencybuild/deff.h.cmake src/CMakeLists.txt src/libkshark-plot.c +1 more+23 -150 replies
3/4kernel-shark: Add ksplot_draw_polyline()src/libkshark-plot.c src/libkshark-plot.h+31 -60 replies
4/4kernel-shark: Optimize ksplot_draw_polygon()src/libkshark-plot.c+1 -100 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchYordan Karadzhov (VMware)
1/4
2/4Signen-off-by
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Upgrade the OpenGL wrapper for KernelShark v2.0

This patch-sets contains one major improvement to the OpenGL wrapping interface used by KernelShark, that is the capability to draw text to the OpenGL canvas. In the same patch-sets we do few other independent small improvements and optimizations.

Steven,
Please review carefully the first patch. Check the new code in src/libkshark-plot.c, but also think if the addition of the public domain header file stb_truetype.h can bring some licensing issues. Also, is the reference to the original project good enough?

Yordan Karadzhov (VMware) (4):
kernel-shark: Add support for drawing text
kernel-shark: Make GLUT optional dependency
kernel-shark: Add ksplot_draw_polyline()
kernel-shark: Optimize ksplot_draw_polygon()

 CMakeLists.txt                   |    6 +-
 Documentation/doxygen/dox_config |    1 +
 build/deff.h.cmake               |    3 +
 src/CMakeLists.txt               |    8 +-
 src/libkshark-plot.c             |  305 +-
 src/libkshark-plot.h             |   73 +
 src/stb_truetype.h               | 5011 ++++++++++++++++++++++++++++++
 7 files changed, 5366 insertions(+), 41 deletions(-)
 create mode 100644 src/stb_truetype.h
Signature · 1 line
2.25.1