Skip to content

spl: atf: add support for LOAD_IMAGE_V2

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20201120144248.GS32272@bill-the-cat

Versions newest first

  1. v2 Latest9 patches 0 repliesNew

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9treewide: use CONFIG_IS_ENABLED() for ARMV8_SEC_FIRMWARE_SUPPORT+0 -00 replies
2/9spl: atf: move storage for bl31_params into function+0 -00 replies
3/9spl: atf: provide a bl2_plat_get_bl31_params_default()+0 -00 replies
4/9spl: atf: remove helper structure from common header+0 -00 replies
5/9spl: atf: add support for LOAD_IMAGE_V2+0 -00 replies
6/9armv8: layerscape: don't initialize GIC in SPL+0 -00 replies
7/9board: sl28: remove u-boot from loadable DT node+0 -00 replies
7/9board: sl28: remove u-boot from loadable DT node+0 -00 replies
8/9board: sl28: add ATF support (bl31)+0 -00 replies
9/9board: sl28: add OP-TEE Trusted OS support (bl32)+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/9] spl: atf: add support for LOAD_IMAGE_V2
Quoted 80 lines · Michal Simek
Quoted 77 lines · Michael Walle

Am 2020-11-20 14:16, schrieb Michal Simek:

Quoted 63 lines · Michael Walle
Quoted 62 lines

Am 2020-11-20 12:15, schrieb Michal Simek:

Quoted 61 lines · Michael Walle
Quoted 59 lines

Am 2020-11-20 11:14, schrieb Michal Simek:

Quoted 24 lines

Hi,

Quoted 10 lines · Michael Walle

Newer TF-A versions provide a new image loading protocol. This is used on
(newer?) NXP's SoCs. Normally, the bootflow is bl1 -> bl2 -> bl31 -> u-boot. With this series it is possible that U-Boot SPL loads the bl31
directly and thus replacing bl1 and bl2 from the TF-A.

This was tested on the Kontron sl28 board using NXPs bl31 and the upstream
version of the OP-TEE Trusted OS.

I still have some questions about this.

As I see from TFA previous image format has been removed in 2018 by

commit ed51b51f7a9163a7fc48289c5ed97a3fe4fe504f Author:???? Roberto Vargas <[email protected]>
AuthorDate: Mon Sep 24 17:20:48 2018 +0100 Commit:???? Antonio Nino Diaz <[email protected]>
CommitDate: Fri Sep 28 15:31:52 2018 +0100

Quoted 9 lines

??? Remove build option LOAD_IMAGE_V2

??? The code of LOAD_IMAGE_V2=0 has been removed.

??? Change-Id: Iea03e5bebb90c66889bdb23f85c07d0c9717fffe ??? Co-authored-by: Antonio Nino Diaz <[email protected]> ??? Signed-off-by: Antonio Nino Diaz <[email protected]>

DOH! Lol, I'm using just one non-upstream part for the whole board and of course it is doing something miserable. I wasn't aware of this.

Quoted 6 lines

On Xilinx ZynqMP I use SPL->bl31 loading but not using that TFA structure because xilinx is using own format.

But I am curious if V2 was removed in 2018 who is really using previous
one and also if current implemenation is origin or also not full v2.

NXP,
https://source.codeaurora.org/external/qoriq/qoriq-components/atf/tree/plat/nxp/common/common.mk#n55

The last non-nxp commit there was from around March 2018..

Quoted 2 lines

And these patches are not breaking boot on zynqmp that's why not big deal for me.

I was looking at porting TFA to upstream for this board but there is such a huge gap. Therefore, it seemed to be easier to just use the vendor version for now.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Please get this reviewed by people who are using current blX code.

What do you mean by blX code? Nobody is using this flow for now, i.e. ? spl -> bl31 -> u-boot

As I said I am not quite sure about it. I see that rockchip guys are using ATF and they also call that code in ATF. They should know which version the use.

NXP imx8 also uses u-boot -> bl31 as far as I know.

Quoted 1 line

Definitely check with them to ack your patches.

Quoted 8 lines
Quoted 4 lines

I've put Kever (who did the initial patches for rockchip) on CC for this. But again they are using the old method. So lets assume they will ignore this series (for whatever reason), won't it be accepted then? I mean this series doesn't touch the old behavior, just adding a new one.

up to Priyanka or Tom.
I have no problem with your patches because we are not using this method and your patches doesn't break our SPL boot flow.

FWIW, I've currently assigned this to myself in patchwork with the notion that baring further changes, I'll pick this up and put it in -next, when it's around that time.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201120/981dfce9/attachment.sig>