Skip to content

Fix various issues in the SUNRPC xdr code

[email protected] linux-nfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 8 repliesIn review
  2. v18 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Clean up the handling of page padding in rpc_prepare_reply_pages()
- Fix up the initial read_plus() page alignment

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9NFSv4: Fix the alignment of page data in the getdeviceinfo replyfs/nfs/nfs4xdr.c+7 -30 replies
2/9SUNRPC: Fix up typo in xdr_init_decode()net/sunrpc/xdr.c+1 -10 replies
3/9SUNRPC: Clean up helpers xdr_set_iov() and xdr_set_page_base()net/sunrpc/xdr.c+19 -170 replies
4/9SUNRPC: Fix up xdr_read_pages() to take arbitrary object lengthsnet/sunrpc/xdr.c+15 -260 replies
5/9SUNRPC: Clean up the handling of page padding in rpc_prepare_reply_pages()fs/nfs/nfs2xdr.c fs/nfs/nfs3xdr.c fs/nfs/nfs4xdr.c +2 more+46 -463 replies
6/9SUNRPC: Fix up xdr_set_page()net/sunrpc/xdr.c+12 -90 replies
7/9SUNRPC: Fix open coded xdr_stream_remaining()net/sunrpc/xdr.c+2 -20 replies
8/9NFSv4: Fix open coded xdr_stream_remaining()fs/nfs/nfs4xdr.c+3 -30 replies
9/9NFSv4.2: Fix up read_plus() page alignmentfs/nfs/nfs42xdr.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/9] Fix various issues in the SUNRPC xdr code

From: Trond Myklebust <[email protected]>

When looking at the issues raised by Tigran's testing of the NFS client updates, I noticed a couple of things in the generic SUNRPC xdr code that want to be fixed. This patch series replaces an earlier series that attempted to just fix the XDR padding in the NFS code.

This series fixes up a number of issues w.r.t. bounds checking in the xdr_stream code. It corrects the behaviour of xdr_read_pages() for the case where the XDR object size is larger than the buffer page array length and simplifies the code.

v2:
- Clean up the handling of page padding in rpc_prepare_reply_pages()
- Fix up the initial read_plus() page alignment

Trond Myklebust (9):
NFSv4: Fix the alignment of page data in the getdeviceinfo reply
SUNRPC: Fix up typo in xdr_init_decode()
SUNRPC: Clean up helpers xdr_set_iov() and xdr_set_page_base()
SUNRPC: Fix up xdr_read_pages() to take arbitrary object lengths
SUNRPC: Clean up the handling of page padding in
rpc_prepare_reply_pages()
SUNRPC: Fix up xdr_set_page()
SUNRPC: Fix open coded xdr_stream_remaining()
NFSv4: Fix open coded xdr_stream_remaining()
NFSv4.2: Fix up read_plus() page alignment

 fs/nfs/nfs2xdr.c  |  19 ++++-----
 fs/nfs/nfs3xdr.c  |  29 +++++++------
 fs/nfs/nfs42xdr.c |   4 +-
 fs/nfs/nfs4xdr.c  |  48 ++++++++++++----------
 net/sunrpc/clnt.c |   5 +--
 net/sunrpc/xdr.c  | 101 +++++++++++++++++++++-------------------------
 6 files changed, 103 insertions(+), 103 deletions(-)
Signature · 1 line
2.28.0