Skip to content

hw/block/nvme: allow cmb and pmr to coexist

Klaus Jensen qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/block/nvme: indicate CMB support through controller capabilities registerhw/block/nvme.c include/block/nvme.h+8 -30 replies
2/3hw/block/nvme: move msix table and pba to BAR 0hw/block/nvme.c hw/block/nvme.h+23 -20 replies
3/3hw/block/nvme: allow cmb and pmr to coexisthw/block/nvme.c+8 -90 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMaxim Levitsky
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] hw/block/nvme: allow cmb and pmr to coexist

From: Klaus Jensen <[email protected]>

This is a resurrection of Andrzej's series[1] from back July.

Andrzej's main patch basically moved the the CMB from BAR 2 into an offset in BAR 4 (located after the MSI-X table and PBA). Having an offset on the CMB causes a bunch of calculations related to address mapping to change.

So, since I couldn't get the patch to apply cleanly I took a stab at implementing the suggestion I originally came up with: simply move the MSI-X table and PBA from BAR 4 into BAR 0 (up-aligned to a 4 KiB boundary, after the main NVMe controller registers). This way we can keep the CMB at offset zero in its own BAR and free up BAR 4 for use by PMR. This makes the patch simpler and does not impact any of the existing address mapping code.

Andrzej, I would prefer an Ack from you, since I pretty much voided your main patch.

[1]: https://lore.kernel.org/qemu-devel/[email protected]/

CC Andrzej Jakowski <[email protected]>

Andrzej Jakowski (1):
hw/block/nvme: indicate CMB support through controller capabilities
register

Klaus Jensen (2):
hw/block/nvme: move msix table and pba to BAR 0
hw/block/nvme: allow cmb and pmr to coexist

 hw/block/nvme.h      |  1 +
 include/block/nvme.h | 10 +++++++---
 hw/block/nvme.c      | 42 +++++++++++++++++++++++++++++++-----------
 3 files changed, 39 insertions(+), 14 deletions(-)
Signature · 1 line
2.29.2