Skip to content

USB audio refactoring for better implicit feedback support

Takashi Iwai alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest41 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/41ALSA: usb-audio: Handle discrete rates properly in hw constraintssound/usb/card.h sound/usb/pcm.c sound/usb/stream.c+15 -600 replies
2/41ALSA: usb-audio: Don't call usb_set_interface() at trigger callbacksound/usb/pcm.c+13 -150 replies
3/41ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3sound/usb/clock.c sound/usb/clock.h sound/usb/format.c+158 -450 replies
4/41ALSA: usb-audio: Check implicit feedback EP generically for UAC2sound/usb/pcm.c+66 -170 replies
5/41ALSA: usb-audio: Add snd_usb_get_endpoint() helpersound/usb/endpoint.c sound/usb/endpoint.h+31 -90 replies
6/41ALSA: usb-audio: Set and clear sync EP link properlysound/usb/pcm.c+11 -190 replies
7/41ALSA: usb-audio: Improve some debug printssound/usb/endpoint.c sound/usb/pcm.c+12 -70 replies
8/41ALSA: usb-audio: Track implicit fb sync endpoint in audioformat listsound/usb/card.h sound/usb/pcm.c sound/usb/pcm.h +1 more+100 -570 replies
9/41ALSA: usb-audio: Move snd_usb_autoresume() call out of setup_hw_info()sound/usb/pcm.c+9 -60 replies
10/41ALSA: usb-audio: Add hw constraint for implicit fb syncsound/usb/card.h sound/usb/endpoint.c sound/usb/pcm.c+175 -540 replies
11/41ALSA: usb-audio: Simplify hw_params rulessound/usb/pcm.c+38 -720 replies
12/41ALSA: usb-audio: Drop debug.hsound/usb/card.c sound/usb/debug.h sound/usb/format.c +1 more+13 -200 replies
13/41ALSA: usb-audio: Avoid doubly initialization for implicit fbsound/usb/pcm.c+20 -90 replies
14/41ALSA: usb-audio: Create endpoint objects at parsing phasesound/usb/endpoint.c sound/usb/endpoint.h sound/usb/pcm.c +1 more+67 -739 replies
15/41ALSA: usb-audio: Drop keep_interface flag againsound/usb/mixer.c sound/usb/pcm.c sound/usb/usbaudio.h+7 -590 replies
16/41ALSA: usb-audio: Add snd_usb_get_host_interface() helpersound/usb/helper.c sound/usb/helper.h sound/usb/pcm.c+24 -270 replies
17/41ALSA: usb-audio: Don't set altsetting before initializing sample ratesound/usb/stream.c+2 -10 replies
18/41ALSA: usb-audio: Pass snd_usb_audio object to quirk functionssound/usb/clock.c sound/usb/pcm.c sound/usb/quirks.c +1 more+17 -180 replies
19/41ALSA: usb-audio: Simplify snd_usb_init_sample_rate() argumentssound/usb/clock.c sound/usb/clock.h sound/usb/pcm.c +2 more+18 -200 replies
20/41ALSA: usb-audio: Simplify snd_usb_init_pitch() argumentssound/usb/pcm.c sound/usb/pcm.h sound/usb/quirks.c +1 more+12 -180 replies
21/41ALSA: usb-audio: Stop both endpoints properly at errorsound/usb/endpoint.c sound/usb/pcm.c+23 -220 replies
22/41ALSA: usb-audio: Set callbacks via snd_usb_endpoint_set_callback()sound/usb/endpoint.c sound/usb/endpoint.h sound/usb/pcm.c+66 -340 replies
23/41ALSA: usb-audio: Always set up the parameters after resumesound/usb/pcm.c sound/usb/quirks-table.h sound/usb/quirks.c +1 more+6 -340 replies
24/41ALSA: usb-audio: Fix EP matching for continuous ratessound/usb/pcm.c+13 -240 replies
25/41ALSA: usb-audio: Refactor endpoint managementsound/usb/card.c sound/usb/card.h sound/usb/clock.c +3 more+616 -7340 replies
26/41ALSA: usb-audio: Fix possible stall of implicit fb packet ring-buffersound/usb/card.h sound/usb/endpoint.c+63 -250 replies
27/41ALSA: usb-audio: Constify audioformat pointer referencessound/usb/card.h sound/usb/clock.c sound/usb/clock.h +6 more+39 -380 replies
28/41ALSA: usb-audio: Use atomic_t for endpoint use_countsound/usb/card.h sound/usb/endpoint.c+15 -130 replies
29/41ALSA: usb-audio: Refactoring endpoint URB deactivationsound/usb/endpoint.c+23 -180 replies
30/41ALSA: usb-audio: Drop unneeded snd_usb_substream fieldssound/usb/card.c sound/usb/card.h sound/usb/pcm.c +2 more+24 -380 replies
31/41ALSA: usb-audio: Unify the code for the next packet size calculationsound/usb/endpoint.c sound/usb/endpoint.h sound/usb/pcm.c+27 -250 replies
32/41ALSA: usb-audio: Simplify rate_min/max and rates set upsound/usb/format.c+24 -290 replies
33/41ALSA: usb-audio: Replace slave/master termssound/usb/card.h sound/usb/endpoint.c+16 -160 replies
34/41ALSA: usb-audio: Use unsigned char for iface and altsettings fieldssound/usb/card.h sound/usb/endpoint.c+8 -50 replies
35/41ALSA: usb-audio: Show sync endpoint information in proc outputssound/usb/proc.c+15 -10 replies
36/41ALSA: usb-audio: Quirk for BOSS GT-001sound/usb/pcm.c+31 -00 replies
37/41ALSA: usb-audio: Factor out the implicit feedback quirk codesound/usb/Makefile sound/usb/implicit.c sound/usb/implicit.h +1 more+376 -3060 replies
38/41ALSA: usb-audio: Add generic implicit fb parsingsound/usb/implicit.c+54 -50 replies
39/41ALSA: usb-audio: Add implicit_fb module optionDocumentation/sound/alsa-configuration.rst sound/usb/card.c sound/usb/implicit.c +1 more+14 -01 reply
40/41ALSA: usb-audio: Fix quirks for other BOSS devicessound/usb/implicit.c+6 -30 replies
41/41ALSA: usb-audio: Fix MOTU M-Series quirkssound/usb/implicit.c sound/usb/quirks.c+0 -170 replies

Reviews trailers per patch

None of the 41 patches has a Reviewed-by or Acked-by.

PatchKeith MilnerDylan Robinson
1/41T-b T-b
2/41T-b T-b
3/41T-b T-b
4/41T-b T-b
5/41T-b T-b
6/41T-b T-b
7/41T-b T-b
8/41T-b T-b
9/41T-b T-b
10/41T-b T-b
11/41T-b T-b
12/41T-b T-b
13/41T-b T-b
14/41T-b T-b
15/41T-b T-b
16/41T-b T-b
17/41T-b T-b
18/41T-b T-b
19/41T-b T-b
20/41T-b T-b
21/41T-b T-b
22/41T-b T-b
23/41T-b T-b
24/41T-b T-b
25/41T-b T-b
26/41T-b T-b
27/41T-b T-b
28/41T-b T-b
29/41T-b T-b
30/41T-b T-b
31/41T-b T-b
32/41T-b T-b
33/41T-b T-b
34/41T-b T-b
35/41T-b T-b
36/41T-b T-b
37/41T-b T-b
38/41T-b T-b
39/41T-b T-b
40/41Reported-and-tested-by
41/41T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/41] USB audio refactoring for better implicit feedback support

Hi,

here is a largish patch set for USB-audio. Its main goal is to address the long-standing issues wrt the implicit feedback mode. With the current driver, when the implicit fb is used, the full duplex doesn't work properly unless you start both streams *very* carefully. This patch set tries to ease such the configuration mismatch and fix many other bugs.

In short, with this patch set applied, USB-audio driver will try to restrict the hw_params to match with the already opened counter-part stream automatically. So individual aplay and arecord invocation should work now, as well as PulseAudio.

Also, the patch set includes more fixes, e.g. the generic detection of the implicit feedback mode on UAC2/3, and the fix for the sample rate selection on UAC2/3, as well as a few more quirks to follow the new implicit fb model.

The latest patches are available in topic/usb-audio-refactoring branch.

I specially thank Keith Milner and Dylan Robinson for their time spent for lots of testing. Without their patient help, I couldn't finish those patches, as I myself don't own such devices.

Takashi

===

Dylan Robinson (1):
ALSA: usb-audio: Fix MOTU M-Series quirks

Takashi Iwai (40):
ALSA: usb-audio: Handle discrete rates properly in hw constraints
ALSA: usb-audio: Don't call usb_set_interface() at trigger callback
ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3
ALSA: usb-audio: Check implicit feedback EP generically for UAC2
ALSA: usb-audio: Add snd_usb_get_endpoint() helper
ALSA: usb-audio: Set and clear sync EP link properly
ALSA: usb-audio: Improve some debug prints
ALSA: usb-audio: Track implicit fb sync endpoint in audioformat list
ALSA: usb-audio: Move snd_usb_autoresume() call out of setup_hw_info()
ALSA: usb-audio: Add hw constraint for implicit fb sync
ALSA: usb-audio: Simplify hw_params rules
ALSA: usb-audio: Drop debug.h
ALSA: usb-audio: Avoid doubly initialization for implicit fb
ALSA: usb-audio: Create endpoint objects at parsing phase
ALSA: usb-audio: Drop keep_interface flag again
ALSA: usb-audio: Add snd_usb_get_host_interface() helper
ALSA: usb-audio: Don't set altsetting before initializing sample rate
ALSA: usb-audio: Pass snd_usb_audio object to quirk functions
ALSA: usb-audio: Simplify snd_usb_init_sample_rate() arguments
ALSA: usb-audio: Simplify snd_usb_init_pitch() arguments
ALSA: usb-audio: Stop both endpoints properly at error
ALSA: usb-audio: Set callbacks via snd_usb_endpoint_set_callback()
ALSA: usb-audio: Always set up the parameters after resume
ALSA: usb-audio: Fix EP matching for continuous rates
ALSA: usb-audio: Refactor endpoint management
ALSA: usb-audio: Fix possible stall of implicit fb packet ring-buffer
ALSA: usb-audio: Constify audioformat pointer references
ALSA: usb-audio: Use atomic_t for endpoint use_count
ALSA: usb-audio: Refactoring endpoint URB deactivation
ALSA: usb-audio: Drop unneeded snd_usb_substream fields
ALSA: usb-audio: Unify the code for the next packet size calculation
ALSA: usb-audio: Simplify rate_min/max and rates set up
ALSA: usb-audio: Replace slave/master terms
ALSA: usb-audio: Use unsigned char for iface and altsettings fields
ALSA: usb-audio: Show sync endpoint information in proc outputs
ALSA: usb-audio: Quirk for BOSS GT-001
ALSA: usb-audio: Factor out the implicit feedback quirk code
ALSA: usb-audio: Add generic implicit fb parsing
ALSA: usb-audio: Add implicit_fb module option
ALSA: usb-audio: Fix quirks for other BOSS devices

 Documentation/sound/alsa-configuration.rst |    5 +
 sound/usb/Makefile                         |    1 +
 sound/usb/card.c                           |   14 +-
 sound/usb/card.h                           |   53 +-
 sound/usb/clock.c                          |  152 ++--
 sound/usb/clock.h                          |   11 +-
 sound/usb/debug.h                          |   16 -
 sound/usb/endpoint.c                       |  943 +++++++++++++----------
 sound/usb/endpoint.h                       |   57 +-
 sound/usb/format.c                         |  125 +++-
 sound/usb/helper.c                         |   10 +
 sound/usb/helper.h                         |    3 +
 sound/usb/implicit.c                       |  402 ++++++++++
 sound/usb/implicit.h                       |   14 +
 sound/usb/mixer.c                          |   46 --
 sound/usb/pcm.c                            | 1117 ++++++++++------------------
 sound/usb/pcm.h                            |    7 +-
 sound/usb/proc.c                           |   35 +-
 sound/usb/quirks-table.h                   |    8 -
 sound/usb/quirks.c                         |   60 +-
 sound/usb/quirks.h                         |   10 +-
 sound/usb/stream.c                         |   24 +-
 sound/usb/usbaudio.h                       |    5 +-
 23 files changed, 1696 insertions(+), 1422 deletions(-)
 delete mode 100644 sound/usb/debug.h
 create mode 100644 sound/usb/implicit.c
 create mode 100644 sound/usb/implicit.h
Signature · 1 line
2.16.4