Skip to content

block: update graph permissions update

Vladimir Sementsov-Ogievskiy qemu-devel 4 versions – Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest35 of 36 patches 3 repliesApplied
  2. v335 of 36 patches 24 repliesSuperseded
  3. v235 of 36 patches 69 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC21 patches1 replySuperseded

Changes in v4 from the cover letter

git: https://src.openvz.org/scm/~vsementsov/qemu.git
tag: up-block-topologic-perm-v4

35 of 36 patches are in this archive. The cover letter announces 36.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/36tests/test-bdrv-graph-mod: add test_parallel_exclusive_writetests/unit/test-bdrv-graph-mod.c+69 -10 replies
2/36tests/test-bdrv-graph-mod: add test_parallel_perm_updatetests/unit/test-bdrv-graph-mod.c+116 -00 replies
3/36tests/test-bdrv-graph-mod: add test_append_greedy_filtertests/unit/test-bdrv-graph-mod.c+33 -00 replies
4/36block: bdrv_append(): don't consume referenceblock.c block/backup-top.c block/commit.c +4 more+8 -310 replies
5/36block: BdrvChildClass: add .get_parent_aio_context handlerblock.c block/block-backend.c blockjob.c +2 more+34 -00 replies
6/36block: drop ctx argument from bdrv_root_attach_childblock.c block/block-backend.c blockjob.c +1 more+8 -80 replies
8/36util: add transactions.cMAINTAINERS include/qemu/transactions.h util/meson.build +1 more+166 -00 replies
9/36block: bdrv_refresh_perms: check for parents permissions conflictblock.c+54 -90 replies
10/36block: refactor bdrv_child* permission functionsblock.c+59 -200 replies
11/36block: rewrite bdrv_child_try_set_perm() using bdrv_refresh_perms()block.c+8 -60 replies
12/36block: inline bdrv_child_*() permission functions callsblock.c+17 -420 replies
13/36block: use topological sort for permission updateblock.c tests/qemu-iotests/283.out tests/unit/test-bdrv-graph-mod.c+99 -230 replies
14/36block: add bdrv_drv_set_perm transaction actionblock.c+54 -160 replies
15/36block: add bdrv_list_* permission update functionsblock.c+71 -350 replies
16/36block: add bdrv_replace_child_safe() transaction actionblock.c+54 -00 replies
17/36block: fix bdrv_replace_node_commonblock.c tests/unit/test-bdrv-graph-mod.c+20 -270 replies
18/36block: add bdrv_attach_child_common() transaction actionblock.c tests/qemu-iotests/tests/qsd-jobs.out+137 -550 replies
19/36block: add bdrv_attach_child_noperm() transaction actionblock.c+58 -130 replies
20/36block: split out bdrv_replace_node_noperm()block.c+31 -190 replies
21/36block: adapt bdrv_append() for inserting filtersblock.c tests/unit/test-bdrv-graph-mod.c+22 -220 replies
22/36block: add bdrv_remove_filter_or_cow transaction actionblock.c+82 -20 replies
23/36block: introduce bdrv_drop_filter()block.c include/block/block.h+40 -40 replies
24/36block/backup-top: drop .activeblock/backup-top.c tests/qemu-iotests/283.out+2 -470 replies
25/36block: drop ignore_children for permission update functionsblock.c+11 -270 replies
26/36block: make bdrv_unset_inherits_from to be a transaction actionblock.c+42 -40 replies
27/36block: make bdrv_refresh_limits() to be a transaction actionblock.c block/io.c include/block/block.h+35 -80 replies
28/36block: add bdrv_set_backing_noperm() transaction actionblock.c+37 -170 replies
29/36block: bdrv_reopen_multiple(): move bdrv_flush to separate pre-prepareblock.c+8 -60 replies
30/36block: bdrv_reopen_multiple: refresh permissions on updated graphblock.c block/file-posix.c include/block/block.h+84 -1970 replies
31/36block: drop unused permission update functionsblock.c+0 -1030 replies
32/36block: inline bdrv_check_perm_common()block.c+3 -290 replies
33/36block: inline bdrv_replace_child()block.c+18 -830 replies
34/36block: refactor bdrv_child_set_perm_safe() transaction actionblock.c include/block/block_int.h+22 -460 replies
35/36block: rename bdrv_replace_child_safe() to bdrv_replace_child()block.c+5 -50 replies
36/36block: refactor bdrv_node_check_perm()block.c tests/qemu-iotests/245+12 -280 replies

Reviews trailers per patch

34 of 35 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKevin WolfAlberto Garcia
SeriesR-b R-b
1/36R-b
2/36R-b
3/36R-b
4/36R-b
5/36R-b R-b
6/36R-b R-b
8/36R-b
9/36R-b R-b
10/36R-b
11/36R-b
12/36R-b R-b
13/36R-b
14/36R-b
15/36R-b
16/36R-b
17/36R-b
18/36
19/36R-b
20/36R-b
21/36R-b
22/36R-b
23/36R-b
24/36R-b
25/36R-b
26/36R-b
27/36R-b
28/36R-b
29/36R-b
30/36R-b
31/36R-b
32/36R-b
33/36R-b
34/36R-b
35/36R-b
36/36R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/36] block: update graph permissions update

Hi all!

And here is v4.

v4:
git: https://src.openvz.org/scm/~vsementsov/qemu.git
tag: up-block-topologic-perm-v4

01: drop misleading comment
04: add missed bdrv_unref to new bdrv_append() caller
08: s/Than/Then/ in comment
18: add missed ".clean = g_free" to bdrv_attach_child_common_drv
fix typo in comment
qsd-jobs test output updated
22: rewrite comment. I've changed your last wording, be free to return
it back if you like it more.

05,06,09: Add Alberto's r-b

all patches except for 18, for new test output: Add Kevin's r-b

===

The main point of the series is fixing some permission update problems (see patches 01-03 as examples), that in turn makes possible more clean inserting and removing of filters (see patch 26 where .active field is dropped finally from backup-top filter, we don't need a workaround anymore).

The series brings util/transactions.c (patch 10) and use of it in block.c, which allows clean block graph change transactions, with possibility of reverting all modifications (movement and removement of children, changing aio context, changing permissions) in reverse order on failure path.

The series also helps Alberto's "Allow changing bs->file on reopen" which we want to merge prior dropping x- prefix from blockdev-reopen command.

Vladimir Sementsov-Ogievskiy (36):
tests/test-bdrv-graph-mod: add test_parallel_exclusive_write tests/test-bdrv-graph-mod: add test_parallel_perm_update tests/test-bdrv-graph-mod: add test_append_greedy_filter
block: bdrv_append(): don't consume reference
block: BdrvChildClass: add .get_parent_aio_context handler
block: drop ctx argument from bdrv_root_attach_child
block: make bdrv_reopen_{prepare,commit,abort} private
util: add transactions.c
block: bdrv_refresh_perms: check for parents permissions conflict
block: refactor bdrv_child* permission functions
block: rewrite bdrv_child_try_set_perm() using bdrv_refresh_perms()
block: inline bdrv_child_*() permission functions calls
block: use topological sort for permission update
block: add bdrv_drv_set_perm transaction action
block: add bdrv_list_* permission update functions
block: add bdrv_replace_child_safe() transaction action
block: fix bdrv_replace_node_common
block: add bdrv_attach_child_common() transaction action
block: add bdrv_attach_child_noperm() transaction action
block: split out bdrv_replace_node_noperm()
block: adapt bdrv_append() for inserting filters
block: add bdrv_remove_filter_or_cow transaction action
block: introduce bdrv_drop_filter()
block/backup-top: drop .active
block: drop ignore_children for permission update functions
block: make bdrv_unset_inherits_from to be a transaction action
block: make bdrv_refresh_limits() to be a transaction action
block: add bdrv_set_backing_noperm() transaction action
block: bdrv_reopen_multiple(): move bdrv_flush to separate pre-prepare
block: bdrv_reopen_multiple: refresh permissions on updated graph
block: drop unused permission update functions
block: inline bdrv_check_perm_common()
block: inline bdrv_replace_child()
block: refactor bdrv_child_set_perm_safe() transaction action
block: rename bdrv_replace_child_safe() to bdrv_replace_child()
block: refactor bdrv_node_check_perm()

 include/block/block.h                 |   13 +-
 include/block/block_int.h             |    8 +-
 include/qemu/transactions.h           |   63 ++
 block.c                               | 1329 +++++++++++++++----------
 block/backup-top.c                    |   48 +-
 block/block-backend.c                 |   13 +-
 block/commit.c                        |    1 +
 block/file-posix.c                    |   91 +-
 block/io.c                            |   31 +-
 block/mirror.c                        |    3 -
 blockdev.c                            |    4 -
 blockjob.c                            |   11 +-
 tests/unit/test-bdrv-drain.c          |    2 +-
 tests/unit/test-bdrv-graph-mod.c      |  209 +++-
 util/transactions.c                   |   96 ++
 MAINTAINERS                           |    6 +
 tests/qemu-iotests/245                |    2 +-
 tests/qemu-iotests/283.out            |    2 +-
 tests/qemu-iotests/tests/qsd-jobs.out |    2 +-
 util/meson.build                      |    1 +
 20 files changed, 1261 insertions(+), 674 deletions(-)
 create mode 100644 include/qemu/transactions.h
 create mode 100644 util/transactions.c
Signature · 1 line
2.29.2