Skip to content

mptcp: add fastclose option

Florian Westphal mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mptcp: hold mptcp socket before calling tcp_donenet/mptcp/subflow.c+6 -10 replies
2/3tcp: parse mptcp options contained in reset packetsinclude/net/tcp.h net/ipv4/tcp_input.c net/ipv4/tcp_minisocks.c+10 -70 replies
3/3mptcp: parse and act on incoming FASTCLOSE optionnet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h+52 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [PATCH mptcp-next 0/3] mptcp: add fastclose option

This series adds receive side support for fastclose processing. First patch is needed to avoid UAF after enabling option processing for tcp resets. Second patch calls mptcp option parsing also for reset patckets so fastclose-on-tcp-reset is handled.

Last patch adds fastclose handling.

I've submitted a pull request vs. packetdrill to add test cases for
this: https://github.com/multipath-tcp/packetdrill/pull/25

Those are the three test cases i posted earlier to this list plus a 4th test to also cover the 'two subflows closed via fastclose+reset' case.

I would send the fastclose tx side next.

I plan to hold the MPTCP reset patches back for the time being until netlink + mptcpd are aware of its existence.

 include/net/tcp.h        |    2 +-
 net/ipv4/tcp_input.c     |   13 ++++++++-----
 net/ipv4/tcp_minisocks.c |    2 +-
 net/mptcp/options.c      |   15 +++++++++++++++
 net/mptcp/protocol.c     |   33 +++++++++++++++++++++++++++++++++
 net/mptcp/protocol.h     |    4 ++++
 net/mptcp/subflow.c      |    7 ++++++-
 7 files changed, 68 insertions(+), 8 deletions(-)