ibmvfc: initial MQ development/enablement
Status from this message: Applied to 5.12/scsi-staging, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest21 patches 5 repliesApplied
- v421 patches 10 repliesSuperseded
- v318 patches 8 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 17 patches | 18 replies | Superseded | |
| v1 | 13 patches | 19 replies | Superseded |
Changes in v5 from the cover letter
* Addressed comments from brking in following patches:
* Patch 18: Drop queue lock in loop after sending cancel event Remove cancel event from list after completion Return -EIO on unknown failure
* Patch 21: Removed can_queue rebase artifact and range check user supplied nr_scsi_hw_queue value
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | ibmvfc: add vhost fields and defaults for MQ enablementdrivers/ drivers/ | +17 | 0 replies | |
| 2/21 | ibmvfc: move event pool init/free routinesdrivers/ | +76 | 0 replies | |
| 3/21 | ibmvfc: init/free event pool during queue allocation/freedrivers/ | +8 | 0 replies | |
| 4/21 | ibmvfc: add size parameter to ibmvfc_init_event_pooldrivers/ | +16 | 0 replies | |
| 5/21 | ibmvfc: define hcall wrapper for registering a Sub-CRQdrivers/ | +14 | 0 replies | |
| 6/21 | ibmvfc: add Subordinate CRQ definitionsdrivers/ | +21 | 0 replies | |
| 7/21 | ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channelsdrivers/ drivers/ | +126 | 0 replies | |
| 8/21 | ibmvfc: add Sub-CRQ IRQ enable/disable routinedrivers/ | +20 | 0 replies | |
| 9/21 | ibmvfc: add handlers to drain and complete Sub-CRQ responsesdrivers/ | +86 | 0 replies | |
| 10/21 | ibmvfc: define Sub-CRQ interrupt handler routinedrivers/ | +10 | 0 replies | |
| 11/21 | ibmvfc: map/request irq and register Sub-CRQ interrupt handlerdrivers/ | +25 | 0 replies | |
| 12/21 | ibmvfc: implement channel enquiry and setup commandsdrivers/ drivers/ | +136 | 0 replies | |
| 13/21 | ibmvfc: advertise client support for using hardware channelsdrivers/ | +4 | 0 replies | |
| 14/21 | ibmvfc: set and track hw queue in ibmvfc_event structdrivers/ drivers/ | +6 | 0 replies | |
| 15/21 | ibmvfc: send commands down HW Sub-CRQ when channelizeddrivers/ | +33 | 0 replies | |
| 16/21 | ibmvfc: register Sub-CRQ handles with VIOS during channel setupdrivers/ | +31 | 0 replies | |
| 17/21 | ibmvfc: add cancel mad initialization helperdrivers/ | +40 | 0 replies | |
| 18/21 | ibmvfc: send Cancel MAD down each hw scsi channeldrivers/ drivers/ | +100 | 1 reply | |
| 19/21 | ibmvfc: purge scsi channels after transport loss/resetdrivers/ | +16 | 0 replies | |
| 20/21 | ibmvfc: enable MQ and set reasonable defaultsdrivers/ | +3 | 0 replies | |
| 21/21 | ibmvfc: provide modules parameters for MQ settingsdrivers/ drivers/ | +67 | 1 reply |
Reviews trailers per patch
All 21 patches have a Reviewed-by or Acked-by.
| Patch | Brian King |
|---|---|
| 1/21 | R-b |
| 2/21 | R-b |
| 3/21 | R-b |
| 4/21 | R-b |
| 5/21 | R-b |
| 6/21 | R-b |
| 7/21 | R-b |
| 8/21 | R-b |
| 9/21 | R-b |
| 10/21 | R-b |
| 11/21 | R-b |
| 12/21 | R-b |
| 13/21 | R-b |
| 14/21 | R-b |
| 15/21 | R-b |
| 16/21 | R-b |
| 17/21 | R-b |
| 18/21 | R-b |
| 19/21 | R-b |
| 20/21 | R-b |
| 21/21 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 00/21] ibmvfc: initial MQ development/enablement
Recent updates in pHyp Firmware and VIOS releases provide new infrastructure towards enabling Subordinate Command Response Queues (Sub-CRQs) such that each Sub-CRQ is a channel backed by an actual hardware queue in the FC stack on the partner VIOS. Sub-CRQs are registered with the firmware via hypercalls and then negotiated with the VIOS via new Management Datagrams (MADs) for channel setup.
This initial implementation adds the necessary Sub-CRQ framework and implements the new MADs for negotiating and assigning a set of Sub-CRQs to associated VIOS HW backed channels.
This latest series is completely rebased and reimplemented on top of the recent ("ibmvfc: MQ prepartory locking work") series. [1]
[1] https://lore.kernel.org/linux-scsi/[email protected]/
changes in v5:
* Addressed comments from brking in following patches:
* Patch 18: Drop queue lock in loop after sending cancel event Remove cancel event from list after completion Return -EIO on unknown failure
* Patch 21: Removed can_queue rebase artifact and range check user supplied nr_scsi_hw_queue value
changes in v4:
* Series rebased and reworked on top of previous ibmvfc locking series
* Dropped all previous Reviewed-by tags
changes in v3:
* Patch 4: changed firmware support logging to dev_warn_once
* Patch 6: adjusted locking
* Patch 15: dropped logging verbosity, moved cancel event tracking into subqueue
* Patch 17: removed write permission for migration module parameters drive hard reset after update to num of scsi channels
changes in v2:
* Patch 4: NULL'd scsi_scrq reference after deallocation
* Patch 6: Added switch case to handle XPORT event
* Patch 9: fixed ibmvfc_event leak and double free
* added support for cancel command with MQ
* added parameter toggles for MQ settings
Tyrel Datwyler (21):
ibmvfc: add vhost fields and defaults for MQ enablement
ibmvfc: move event pool init/free routines
ibmvfc: init/free event pool during queue allocation/free
ibmvfc: add size parameter to ibmvfc_init_event_pool
ibmvfc: define hcall wrapper for registering a Sub-CRQ
ibmvfc: add Subordinate CRQ definitions
ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels
ibmvfc: add Sub-CRQ IRQ enable/disable routine
ibmvfc: add handlers to drain and complete Sub-CRQ responses
ibmvfc: define Sub-CRQ interrupt handler routine
ibmvfc: map/request irq and register Sub-CRQ interrupt handler
ibmvfc: implement channel enquiry and setup commands
ibmvfc: advertise client support for using hardware channels
ibmvfc: set and track hw queue in ibmvfc_event struct
ibmvfc: send commands down HW Sub-CRQ when channelized
ibmvfc: register Sub-CRQ handles with VIOS during channel setup
ibmvfc: add cancel mad initialization helper
ibmvfc: send Cancel MAD down each hw scsi channel
ibmvfc: purge scsi channels after transport loss/reset
ibmvfc: enable MQ and set reasonable defaults
ibmvfc: provide modules parameters for MQ settings
drivers/scsi/ibmvscsi/ibmvfc.c | 917 ++++++++++++++++++++++++++++----- drivers/scsi/ibmvscsi/ibmvfc.h | 39 ++ 2 files changed, 828 insertions(+), 128 deletions(-)
Signature · 1 line
2.27.0