Skip to content

ibmvfc: initial MQ development/enablement

Tyrel Datwyler linux-scsi linuxppc-dev lkml 5 versions – Applied

Status from this message: Applied to 5.12/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest21 patches 5 repliesApplied
  2. v421 patches 10 repliesSuperseded
  3. v318 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v217 patches18 repliesSuperseded
v113 patches19 repliesSuperseded

Changes in v5 from the cover letter

* Addressed comments from brking in following patches:
* Patch 18: Drop queue lock in loop after sending cancel event Remove cancel event from list after completion Return -EIO on unknown failure
* Patch 21: Removed can_queue rebase artifact and range check user supplied nr_scsi_hw_queue value

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/21ibmvfc: add vhost fields and defaults for MQ enablementdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+17 -00 replies
2/21ibmvfc: move event pool init/free routinesdrivers/scsi/ibmvscsi/ibmvfc.c+76 -750 replies
3/21ibmvfc: init/free event pool during queue allocation/freedrivers/scsi/ibmvscsi/ibmvfc.c+8 -100 replies
4/21ibmvfc: add size parameter to ibmvfc_init_event_pooldrivers/scsi/ibmvscsi/ibmvfc.c+16 -90 replies
5/21ibmvfc: define hcall wrapper for registering a Sub-CRQdrivers/scsi/ibmvscsi/ibmvfc.c+14 -00 replies
6/21ibmvfc: add Subordinate CRQ definitionsdrivers/scsi/ibmvscsi/ibmvfc.h+21 -00 replies
7/21ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channelsdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+126 -00 replies
8/21ibmvfc: add Sub-CRQ IRQ enable/disable routinedrivers/scsi/ibmvscsi/ibmvfc.c+20 -00 replies
9/21ibmvfc: add handlers to drain and complete Sub-CRQ responsesdrivers/scsi/ibmvscsi/ibmvfc.c+86 -00 replies
10/21ibmvfc: define Sub-CRQ interrupt handler routinedrivers/scsi/ibmvscsi/ibmvfc.c+10 -00 replies
11/21ibmvfc: map/request irq and register Sub-CRQ interrupt handlerdrivers/scsi/ibmvscsi/ibmvfc.c+25 -00 replies
12/21ibmvfc: implement channel enquiry and setup commandsdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+136 -20 replies
13/21ibmvfc: advertise client support for using hardware channelsdrivers/scsi/ibmvscsi/ibmvfc.c+4 -00 replies
14/21ibmvfc: set and track hw queue in ibmvfc_event structdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+6 -00 replies
15/21ibmvfc: send commands down HW Sub-CRQ when channelizeddrivers/scsi/ibmvscsi/ibmvfc.c+33 -60 replies
16/21ibmvfc: register Sub-CRQ handles with VIOS during channel setupdrivers/scsi/ibmvscsi/ibmvfc.c+31 -10 replies
17/21ibmvfc: add cancel mad initialization helperdrivers/scsi/ibmvscsi/ibmvfc.c+40 -280 replies
18/21ibmvfc: send Cancel MAD down each hw scsi channeldrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+100 -121 reply
19/21ibmvfc: purge scsi channels after transport loss/resetdrivers/scsi/ibmvscsi/ibmvfc.c+16 -00 replies
20/21ibmvfc: enable MQ and set reasonable defaultsdrivers/scsi/ibmvscsi/ibmvfc.h+3 -30 replies
21/21ibmvfc: provide modules parameters for MQ settingsdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+67 -91 reply

Reviews trailers per patch

All 21 patches have a Reviewed-by or Acked-by.

PatchBrian King
1/21R-b
2/21R-b
3/21R-b
4/21R-b
5/21R-b
6/21R-b
7/21R-b
8/21R-b
9/21R-b
10/21R-b
11/21R-b
12/21R-b
13/21R-b
14/21R-b
15/21R-b
16/21R-b
17/21R-b
18/21R-b
19/21R-b
20/21R-b
21/21R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/21] ibmvfc: initial MQ development/enablement

Recent updates in pHyp Firmware and VIOS releases provide new infrastructure towards enabling Subordinate Command Response Queues (Sub-CRQs) such that each Sub-CRQ is a channel backed by an actual hardware queue in the FC stack on the partner VIOS. Sub-CRQs are registered with the firmware via hypercalls and then negotiated with the VIOS via new Management Datagrams (MADs) for channel setup.

This initial implementation adds the necessary Sub-CRQ framework and implements the new MADs for negotiating and assigning a set of Sub-CRQs to associated VIOS HW backed channels.

This latest series is completely rebased and reimplemented on top of the recent ("ibmvfc: MQ prepartory locking work") series. [1]

[1] https://lore.kernel.org/linux-scsi/[email protected]/

changes in v5:
* Addressed comments from brking in following patches:
* Patch 18: Drop queue lock in loop after sending cancel event Remove cancel event from list after completion Return -EIO on unknown failure
* Patch 21: Removed can_queue rebase artifact and range check user supplied nr_scsi_hw_queue value

changes in v4:
* Series rebased and reworked on top of previous ibmvfc locking series
* Dropped all previous Reviewed-by tags

changes in v3:
* Patch 4: changed firmware support logging to dev_warn_once
* Patch 6: adjusted locking
* Patch 15: dropped logging verbosity, moved cancel event tracking into subqueue
* Patch 17: removed write permission for migration module parameters drive hard reset after update to num of scsi channels

changes in v2:
* Patch 4: NULL'd scsi_scrq reference after deallocation
* Patch 6: Added switch case to handle XPORT event
* Patch 9: fixed ibmvfc_event leak and double free
* added support for cancel command with MQ
* added parameter toggles for MQ settings

Tyrel Datwyler (21):
ibmvfc: add vhost fields and defaults for MQ enablement
ibmvfc: move event pool init/free routines
ibmvfc: init/free event pool during queue allocation/free
ibmvfc: add size parameter to ibmvfc_init_event_pool
ibmvfc: define hcall wrapper for registering a Sub-CRQ
ibmvfc: add Subordinate CRQ definitions
ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels
ibmvfc: add Sub-CRQ IRQ enable/disable routine
ibmvfc: add handlers to drain and complete Sub-CRQ responses
ibmvfc: define Sub-CRQ interrupt handler routine
ibmvfc: map/request irq and register Sub-CRQ interrupt handler
ibmvfc: implement channel enquiry and setup commands
ibmvfc: advertise client support for using hardware channels
ibmvfc: set and track hw queue in ibmvfc_event struct
ibmvfc: send commands down HW Sub-CRQ when channelized
ibmvfc: register Sub-CRQ handles with VIOS during channel setup
ibmvfc: add cancel mad initialization helper
ibmvfc: send Cancel MAD down each hw scsi channel
ibmvfc: purge scsi channels after transport loss/reset
ibmvfc: enable MQ and set reasonable defaults
ibmvfc: provide modules parameters for MQ settings

 drivers/scsi/ibmvscsi/ibmvfc.c | 917 ++++++++++++++++++++++++++++-----
 drivers/scsi/ibmvscsi/ibmvfc.h |  39 ++
 2 files changed, 828 insertions(+), 128 deletions(-)
Signature · 1 line
2.27.0