pwm-fan: Refactor and convert to recommended API
Status from this message: Applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 2 repliesApplied
- v12 patches 2 repliesSuperseded
Changes in v2 from the cover letter
* Addressed review comment from Guenter: Simplify pwm_fan_write, return -ENOTSUPP from pwm_fan_read if the wrong type is given, use devm_kcalloc instead of devm_kzalloc to ensure multiplication is safe.
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | hwmon: pwm-fan: Refactor pwm_fan_probedrivers/ | +33 | 1 reply | |
| 2/2 | hwmon: pwm-fan: Convert to hwmon_device_register_with_info APIdrivers/ | +71 | 1 reply |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Guenter Roeck |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] pwm-fan: Refactor and convert to recommended API
This series includes the first patch from my previous series adding support for multiple fan tachometers [1] which Guenter has already reviewed, plus a second patch to convert the driver to use the hwmon_device_register_with_info API as requested.
These patches have been tested on a SanCloud BeagleBone Enhanced using an oscilloscope to check the PWM output and a signal generator to simulate the fan tachometer signals. I've tested both with and without a fan tachometer input defined in the device tree.
There shouldn't be any functional change to the driver after these patches, it just puts us in a much better place for further development.
These changes can also be pulled from:
https://gitlab.com/pbarker.dev/staging/linux.git
tag: for-hwmon/pwm-fan-refactor-v2_2020-11-28
Changes from v1:
* Addressed review comment from Guenter: Simplify pwm_fan_write, return -ENOTSUPP from pwm_fan_read if the wrong type is given, use devm_kcalloc instead of devm_kzalloc to ensure multiplication is safe.
Paul Barker (2):
hwmon: pwm-fan: Refactor pwm_fan_probe
hwmon: pwm-fan: Convert to hwmon_device_register_with_info API
drivers/hwmon/pwm-fan.c | 164 +++++++++++++++++++++++++--------------- 1 file changed, 104 insertions(+), 60 deletions(-)
base-commit: e6e2c18f63c62df778ce484945fccad088594533
Signature · 1 line
2.26.2