Skip to content

Nokia RX-51: Fix USB TTY console and enable it

Pali Rohár u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13serial: usbtty: Fix puts functiondrivers/serial/usbtty.c+2 -21 reply
2/13usb: musb: Fix compilation of gadget codeMakefile+1 -01 reply
2/13usb: musb: Fix compilation of gadget code+0 -00 replies
3/13usb: musb: Always clear the data toggle bit when configuring epdrivers/usb/musb/musb_core.c+0 -41 reply
4/13usb: musb: Fix configuring FIFO for endpointsdrivers/usb/musb/musb_core.c+3 -32 replies
5/13usb: musb: Read value of PERI_RXCSR to 16bit variabledrivers/usb/musb/musb_udc.c+1 -11 reply
6/13usb: musb: Fix transmission of bigger buffersdrivers/usb/musb/musb_udc.c+6 -111 reply
7/13usb: gadget: Do not export usbd_device_* arraysdrivers/usb/gadget/core.c drivers/usb/gadget/ep0.c include/usbdevice.h+39 -452 replies
8/13usb: gadget: Use dbg_ep0() macro instead of serial_printf()drivers/usb/gadget/ep0.c+8 -81 reply
9/13arm: omap3: Compile lowlevel_init() function only when it is usedarch/arm/mach-omap2/omap3/lowlevel_init.S+5 -11 reply
10/13arm: omap3: Compile s_init() function only when it is usedarch/arm/mach-omap2/omap3/board.c+3 -01 reply
11/13Nokia RX-51: Remove function set_muxconf_regs()board/nokia/rx51/rx51.c board/nokia/rx51/rx51.h+0 -3570 replies
12/13Nokia RX-51: Move content of rx51.h to rx51.cboard/nokia/rx51/rx51.c board/nokia/rx51/rx51.h+16 -320 replies
13/13Nokia RX-51: Enable usbtty serial console by defaultconfigs/nokia_rx51_defconfig doc/README.nokia_rx51 include/configs/nokia_rx51.h+8 -2913 replies
13/13Nokia RX-51: Enable usbtty serial console by default+0 -01 reply
13/13Nokia RX-51: Enable usbtty serial console by default+0 -00 replies

Reviews trailers per patch

11 of 16 patches have a Reviewed-by or Acked-by.

PatchPavel Machek
1/13R-b
2/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13
12/13
13/13
13/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it

This patch series fix usbtty code (serial console via USB peripheral mode), fix underlying musb peripheral code, fix compilation of CONFIG_USB_DEVICE (used by usbtty), remove unused Nokia RX-51 code to decrease size of U-Boot binary and finally enable usbtty serial console for Nokia RX-51.

With this patch series debugging of Nokia RX-51 can be done also via USB serial console.

On computer this serial console is accessible via /dev/ttyACM0 device.

With current implementation there is an issue in musb driver that it loose receiving bytes from USB bus when too many a characters are send over USB tty from computer. Typing on keyboard to kermit terminal connected to /dev/ttyACM0 is working fine. But pasting more more bytes to terminal cause data lost on receiving side. I do not know where is the issue or how to fix it (it looks like that data are lost at low level when reading them from msub FIFO hardware) but typing on keyboard is working fine. This is rather issue for sending files via x/y/z-modem or kermit protocol. Currently U-Boot is not able to receive any file via usbtty with musb driver due to this issue.

Pali Roh?r (13):
serial: usbtty: Fix puts function
usb: musb: Fix compilation of gadget code
usb: musb: Always clear the data toggle bit when configuring ep
usb: musb: Fix configuring FIFO for endpoints
usb: musb: Read value of PERI_RXCSR to 16bit variable
usb: musb: Fix transmission of bigger buffers
usb: gadget: Do not export usbd_device_* arrays
usb: gadget: Use dbg_ep0() macro instead of serial_printf()
arm: omap3: Compile lowlevel_init() function only when it is used
arm: omap3: Compile s_init() function only when it is used Nokia RX-51: Remove function set_muxconf_regs()
Nokia RX-51: Move content of rx51.h to rx51.c
Nokia RX-51: Enable usbtty serial console by default

 Makefile                                  |   1 +
 arch/arm/mach-omap2/omap3/board.c         |   3 +
 arch/arm/mach-omap2/omap3/lowlevel_init.S |   6 +-
 board/nokia/rx51/rx51.c                   |  28 +-
 board/nokia/rx51/rx51.h                   | 377 ----------------------
 configs/nokia_rx51_defconfig              |   6 +-
 doc/README.nokia_rx51                     |  15 +-
 drivers/serial/usbtty.c                   |   4 +-
 drivers/usb/gadget/core.c                 |  38 +--
 drivers/usb/gadget/ep0.c                  |  47 ++-
 drivers/usb/musb/musb_core.c              |  10 +-
 drivers/usb/musb/musb_udc.c               |  19 +-
 include/configs/nokia_rx51.h              |  16 +-
 include/usbdevice.h                       |  15 -
 14 files changed, 92 insertions(+), 493 deletions(-)
 delete mode 100644 board/nokia/rx51/rx51.h
Signature · 1 line
2.20.1