Skip to content

User creatable object property setting fixes

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4crypto: Move USER_CREATABLE to secret_common base classcrypto/secret.c crypto/secret_common.c crypto/secret_keyring.c+15 -280 replies
2/4crypto: Forbid broken unloading of secretscrypto/secret_common.c+3 -30 replies
3/4crypto: Fix memory leaks in set_loaded for tls-*crypto/tlscredsanon.c crypto/tlscredspsk.c crypto/tlscredsx509.c+3 -60 replies
4/4can-host: Fix crash when 'canbus' property is not setnet/can/can_host.c+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] User creatable object property setting fixes

While writing a QAPI schema for all user creatable QOM objects, I found a few problems in the existing property setting code of objects.

This series fixes some crashes and memory leaks related to property setting in user creatable objects.

There are many more problems of the sort that updating a property at runtime is allowed by most objects, but they aren't actually prepared to handle the update, so it doesn't result in the expected behaviour. I'm not trying to fix bugs of this class in this series.

Kevin Wolf (4):
crypto: Move USER_CREATABLE to secret_common base class
crypto: Forbid broken unloading of secrets
crypto: Fix memory leaks in set_loaded for tls-*
can-host: Fix crash when 'canbus' property is not set

 crypto/secret.c         | 14 --------------
 crypto/secret_common.c  | 21 ++++++++++++++++++---
 crypto/secret_keyring.c | 14 --------------
 crypto/tlscredsanon.c   |  3 +--
 crypto/tlscredspsk.c    |  3 +--
 crypto/tlscredsx509.c   |  3 +--
 net/can/can_host.c      |  5 +++++
 7 files changed, 26 insertions(+), 37 deletions(-)
Signature · 1 line
2.28.0