Skip to content

Several changes for UFS WriteBooster

Bean Huo linux-scsi lkml 7 versions – Applied

Status from this message: Applied patches 1-5 to 5.12/scsi-staging. Patch 6 didn't apply, please

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest6 patches 3 repliesApplied
  2. v66 patches 4 repliesSuperseded
  3. v57 patches 16 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v46 patches9 repliesSuperseded
v33 patches5 repliesSuperseded
v23 patches11 repliesSuperseded
v13 patches13 repliesSuperseded

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/6scsi: ufs: Add "wb_on" sysfs node to control WB on/offdrivers/scsi/ufs/ufs-sysfs.c drivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+49 -20 replies
2/6docs: ABI: Add wb_on documentation for new entry wb_onDocumentation/ABI/testing/sysfs-driver-ufs+11 -00 replies
3/6scsi: ufs: Changes comment in the function ufshcd_wb_probe()drivers/scsi/ufs/ufshcd.c+3 -40 replies
4/6scsi: ufs: Remove two WB related fields from struct ufs_dev_infodrivers/scsi/ufs/ufs.h drivers/scsi/ufs/ufshcd.c+6 -100 replies
5/6scsi: ufs: Group UFS WB related flags to struct ufs_dev_infodrivers/scsi/ufs/ufs-sysfs.c drivers/scsi/ufs/ufs.h drivers/scsi/ufs/ufshcd.c +1 more+28 -260 replies
6/6scsi: ufs: Cleanup WB buffer flush toggle implementationdrivers/scsi/ufs/ufshcd.c+21 -450 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchCan GuoStanley ChuAvri Altman
1/6R-b R-b
2/6
3/6R-b R-b
4/6R-b
5/6R-b A-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/6] Several changes for UFS WriteBooster

From: Bean Huo <[email protected]>

Changelog:

v6--v7:
1. Change wb_on sysfs documentation and add information that WriteBooster is already enabled after power-on/reset(Incorporate Adrian Hunter's suggestion)

v5--v6:
1. Remove original patch 7/7:
"scsi: ufs: Keep device active mode only fWriteBoosterBufferFlushDuringHibernate == 1"
2. Rebased patch onto 5.12/scsi-staging
3. Add protection of PM ops and err_handler for the wb_on entry access

V4--V5:
1. Add patch "docs: ABI: Add wb_on documentation for UFS sysfs"
2. Unify WB related flags with wb_* prefix (Stanley Chu)
3. Delete d_ext_ufs_feature_sup (Stanley Chu)
4. Incorporate Stanley's suggestion to patch 6/7
5. Replace scnprintf() with sysfs_emit() in 1/7 (Greg KH)

v3--v4:
1. Rebase patch on 5.11/scsi-staging
2. Add WB cleanup patches 3/6, 4/6 adn 5/6

v2--v3:
1. Change multi-line comments style in patch 1/3 (Can Guo)

v1--v2:
1. Take is_hibern8_wb_flush checkup out from function ufshcd_wb_need_flush() in patch 2/3
2. Add UFSHCD_CAP_CLK_SCALING checkup in patch 1/3. that means only for the platform, which doesn't support UFSHCD_CAP_CLK_SCALING, can control WB through "wb_on".

Bean Huo (6):
scsi: ufs: Add "wb_on" sysfs node to control WB on/off
docs: ABI: Add wb_on documentation for new entry wb_on
scsi: ufs: Changes comment in the function ufshcd_wb_probe()
scsi: ufs: Remove two WB related fields from struct ufs_dev_info
scsi: ufs: Group UFS WB related flags to struct ufs_dev_info
scsi: ufs: Cleanup WB buffer flush toggle implementation

 Documentation/ABI/testing/sysfs-driver-ufs |  11 +++
 drivers/scsi/ufs/ufs-sysfs.c               |  46 +++++++++
 drivers/scsi/ufs/ufs.h                     |  29 +++---
 drivers/scsi/ufs/ufshcd.c                  | 103 ++++++++-------------
 drivers/scsi/ufs/ufshcd.h                  |   6 +-
 5 files changed, 113 insertions(+), 82 deletions(-)
Signature · 1 line
2.17.1