SCSI result handling cleanup, part 1
Status from this message: Applied to 5.12/scsi-staging, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest posting 2/235 patches 3 repliesApplied
- v3 posting 1/235 patches 2 repliesSuperseded
- v237 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 34 patches | 33 replies | Superseded |
Changes in v3 from the cover letter
- Rebased to 5.12/scsi-queue
- Fixup kbuild failures
- Correct review tag from hch
Patches in v3 posting 2/2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/35 | scsi: drop gdth driverDocumentation/ Documentation/ Documentation/ +8 more | +1 | 1 reply | |
| 2/35 | 3w-xxxx: Whitespace cleanupdrivers/ drivers/ | +229 | 0 replies | |
| 3/35 | 3w-9xxx: Whitespace cleanupdrivers/ drivers/ | +113 | 0 replies | |
| 4/35 | 3w-sas: Whitespace cleanupdrivers/ drivers/ | +93 | 0 replies | |
| 5/35 | atp870u: Whitespace cleanupdrivers/ drivers/ | +258 | 0 replies | |
| 6/35 | aic7xxx,aic79xx: Whitespace cleanupdrivers/ drivers/ drivers/ +7 more | +208 | 0 replies | |
| 7/35 | aic7xxx,aic79xx: kill pointless forward declarationsdrivers/ drivers/ | +0 | 0 replies | |
| 8/35 | aic7xxx,aic79xxx: remove driver-defined SAM status definitionsdrivers/ drivers/ drivers/ +2 more | +21 | 0 replies | |
| 9/35 | bfa: drop driver-defined SCSI status codesdrivers/ drivers/ drivers/ | +2 | 0 replies | |
| 10/35 | acornscsi: use standard definesdrivers/ | +2 | 0 replies | |
| 11/35 | nsp32: fixup status handlingdrivers/ | +1 | 0 replies | |
| 12/35 | dc395: drop private SAM status code definitionsdrivers/ | +0 | 0 replies | |
| 13/35 | qla4xxx: use standard SAM status definitionsdrivers/ drivers/ | +1 | 0 replies | |
| 14/35 | zfcp: do not set COMMAND_COMPLETEdrivers/ | +0 | 0 replies | |
| 15/35 | aacraid: avoid setting message byte on completiondrivers/ | +64 | 0 replies | |
| 16/35 | hpsa: do not set COMMAND_COMPLETEdrivers/ | +1 | 0 replies | |
| 17/35 | stex: do not set COMMAND_COMPLETEdrivers/ | +13 | 0 replies | |
| 18/35 | nsp_cs: drop internal SCSI message definitiondrivers/ drivers/ | +6 | 0 replies | |
| 19/35 | aic7xxx,aic79xx: drop internal SCSI message definitiondrivers/ drivers/ drivers/ +3 more | +138 | 0 replies | |
| 20/35 | dc395x: drop internal SCSI message definitionsdrivers/ drivers/ drivers/ | +12 | 0 replies | |
| 21/35 | initio: drop internal SCSI message definitiondrivers/ drivers/ | +33 | 0 replies | |
| 22/35 | scsi_debug: do not set COMMAND_COMPLETEdrivers/ | +1 | 0 replies | |
| 23/35 | ufshcd: do not set COMMAND_COMPLETEdrivers/ | +1 | 0 replies | |
| 24/35 | atp870u: use standard definitionsdrivers/ | +30 | 0 replies | |
| 25/35 | mac53c94: Do not set invalid command resultdrivers/ | +0 | 0 replies | |
| 26/35 | dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR messagedrivers/ | +1 | 0 replies | |
| 27/35 | scsi: add 'set_status_byte()' accessorinclude/ | +5 | 0 replies | |
| 28/35 | esp_scsi: use host byte as last argument to esp_cmd_is_done()drivers/ | +10 | 0 replies | |
| 29/35 | esp_scsi: do not set SCSI message bytedrivers/ | +1 | 0 replies | |
| 30/35 | wd33c93: use SCSI statusdrivers/ | +3 | 0 replies | |
| 31/35 | ips: use correct command completion on errordrivers/ | +7 | 0 replies | |
| 32/35 | storvsc: Return DID_ERROR for invalid commandsdrivers/ | +1 | 0 replies | |
| 33/35 | qla2xxx: fc_remote_port_chkready() returns a SCSI result valuedrivers/ | +1 | 0 replies | |
| 34/35 | advansys: kill driver_defined status byte accessorsdrivers/ | +24 | 0 replies | |
| 35/35 | ncr53c8xx: Use SAM status valuesdrivers/ drivers/ | +46 | 0 replies |
Reviews trailers per patch
29 of 35 patches have a Reviewed-by or Acked-by.
| Patch | Bart Van Assche | Christoph Hellwig | Benjamin Block | Douglas Gilbert | Himanshu Madhani | Don Brace | Finn Thain |
|---|---|---|---|---|---|---|---|
| 1/35 | Cautiously-Acked-by | ||||||
| 2/35 | |||||||
| 3/35 | |||||||
| 4/35 | |||||||
| 5/35 | |||||||
| 6/35 | |||||||
| 7/35 | R-b | ||||||
| 8/35 | R-b | R-b | |||||
| 9/35 | R-b | R-b | |||||
| 10/35 | R-b | ||||||
| 11/35 | R-b | ||||||
| 12/35 | R-b | ||||||
| 13/35 | R-b | ||||||
| 14/35 | R-b | ||||||
| 15/35 | R-b | ||||||
| 16/35 | R-b | A-b | |||||
| 17/35 | R-b | ||||||
| 18/35 | R-b | ||||||
| 19/35 | R-b | ||||||
| 20/35 | R-b | ||||||
| 21/35 | R-b | ||||||
| 22/35 | R-b | A-b | |||||
| 23/35 | R-b | ||||||
| 24/35 | R-b | ||||||
| 25/35 | R-b | ||||||
| 26/35 | R-b | ||||||
| 27/35 | R-b | ||||||
| 28/35 | A-b | ||||||
| 29/35 | R-b | ||||||
| 30/35 | R-b | R-b | |||||
| 31/35 | R-b | ||||||
| 32/35 | R-b | ||||||
| 33/35 | R-b | R-b | |||||
| 34/35 | R-b | ||||||
| 35/35 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [PATCHv4 00/35] [PATCHv3 00/35] SCSI result handling cleanup, part 1
Hi all,
this is the first part of an attempt to clean up SCSI result handling. The patchset primarily cleans up various drivers by fixing up whitespaces or move to standard definitions.
It also fixes some minor issues in some drivers which set the wrong result values.
And, of course, another attempt to kill the gdth driver
I have a larger patchset based on this one to update the SCSI result handling for all drivers, but decided to split things in two to not overload reviewers
As usual, comments and reviews are welcome.
Changes to v1:
- Add reviews from Christoph
- Included review from Finn Thain
- Add set_status_byte() helper
- Add cleanup for dc395c
- Add additional patch for using SAM status values instead of the shifted linux versions
Changes to v2:
- Add Reviewed-by: tags
- Drop additional patches again
Changes to v3:
- Rebased to 5.12/scsi-queue
- Fixup kbuild failures
- Correct review tag from hch
Hannes Reinecke (35):
scsi: drop gdth driver
3w-xxxx: Whitespace cleanup
3w-9xxx: Whitespace cleanup
3w-sas: Whitespace cleanup
atp870u: Whitespace cleanup
aic7xxx,aic79xx: Whitespace cleanup
aic7xxx,aic79xx: kill pointless forward declarations aic7xxx,aic79xxx: remove driver-defined SAM status definitions
bfa: drop driver-defined SCSI status codes
acornscsi: use standard defines
nsp32: fixup status handling
dc395: drop private SAM status code definitions
qla4xxx: use standard SAM status definitions
zfcp: do not set COMMAND_COMPLETE
aacraid: avoid setting message byte on completion
hpsa: do not set COMMAND_COMPLETE
stex: do not set COMMAND_COMPLETE
nsp_cs: drop internal SCSI message definition aic7xxx,aic79xx: drop internal SCSI message definition
dc395x: drop internal SCSI message definitions
initio: drop internal SCSI message definition
scsi_debug: do not set COMMAND_COMPLETE
ufshcd: do not set COMMAND_COMPLETE
atp870u: use standard definitions
mac53c94: Do not set invalid command result
dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR message
scsi: add 'set_status_byte()' accessor
esp_scsi: use host byte as last argument to esp_cmd_is_done()
esp_scsi: do not set SCSI message byte
wd33c93: use SCSI status
ips: use correct command completion on error
storvsc: Return DID_ERROR for invalid commands
qla2xxx: fc_remote_port_chkready() returns a SCSI result value
advansys: kill driver_defined status byte accessors
ncr53c8xx: Use SAM status values
Documentation/kbuild/makefiles.rst | 4 +- Documentation/process/magic-number.rst | 2 - Documentation/scsi/scsi-parameters.rst | 3 - .../userspace-api/ioctl/ioctl-number.rst | 1 - drivers/s390/scsi/zfcp_fc.h | 1 - drivers/scsi/3w-9xxx.c | 56 +- drivers/scsi/3w-9xxx.h | 156 +- drivers/scsi/3w-sas.c | 52 +- drivers/scsi/3w-sas.h | 118 +- drivers/scsi/3w-xxxx.c | 251 +- drivers/scsi/3w-xxxx.h | 199 +- drivers/scsi/Kconfig | 15 +- drivers/scsi/Makefile | 2 - drivers/scsi/aacraid/aachba.c | 173 +- drivers/scsi/advansys.c | 84 +- drivers/scsi/aic7xxx/aic79xx.h | 36 +- drivers/scsi/aic7xxx/aic79xx_core.c | 257 +- drivers/scsi/aic7xxx/aic79xx_osm.c | 20 +- drivers/scsi/aic7xxx/aic79xx_osm.h | 37 +- drivers/scsi/aic7xxx/aic79xx_osm_pci.c | 6 +- drivers/scsi/aic7xxx/aic79xx_proc.c | 13 +- drivers/scsi/aic7xxx/aic7xxx_93cx6.c | 4 +- drivers/scsi/aic7xxx/aic7xxx_core.c | 263 +- drivers/scsi/aic7xxx/aic7xxx_osm.c | 88 +- drivers/scsi/aic7xxx/aic7xxx_osm.h | 39 +- drivers/scsi/aic7xxx/aic7xxx_proc.c | 15 +- drivers/scsi/aic7xxx/aiclib.h | 15 - drivers/scsi/aic7xxx/scsi_message.h | 41 - drivers/scsi/arm/acornscsi.c | 14 +- drivers/scsi/atp870u.c | 451 +- drivers/scsi/atp870u.h | 14 +- drivers/scsi/bfa/bfa_fc.h | 15 - drivers/scsi/bfa/bfa_fcpim.c | 2 +- drivers/scsi/bfa/bfad_im.c | 2 +- drivers/scsi/dc395x.c | 28 +- drivers/scsi/dc395x.h | 38 - drivers/scsi/dpt_i2o.c | 2 +- drivers/scsi/esp_scsi.c | 23 +- drivers/scsi/gdth.c | 4322 ----------------- drivers/scsi/gdth.h | 981 ---- drivers/scsi/gdth_ioctl.h | 251 - drivers/scsi/gdth_proc.c | 586 --- drivers/scsi/gdth_proc.h | 18 - drivers/scsi/hpsa.c | 4 +- drivers/scsi/initio.c | 64 +- drivers/scsi/initio.h | 25 - drivers/scsi/ips.c | 9 +- drivers/scsi/mac53c94.c | 1 - drivers/scsi/ncr53c8xx.c | 83 +- drivers/scsi/ncr53c8xx.h | 16 - drivers/scsi/nsp32.c | 2 +- drivers/scsi/pcmcia/nsp_cs.c | 12 +- drivers/scsi/pcmcia/nsp_cs.h | 11 - drivers/scsi/qla2xxx/qla_os.c | 2 +- drivers/scsi/qla4xxx/ql4_fw.h | 1 - drivers/scsi/qla4xxx/ql4_isr.c | 2 +- drivers/scsi/scsi_debug.c | 2 +- drivers/scsi/stex.c | 25 +- drivers/scsi/storvsc_drv.c | 2 +- drivers/scsi/ufs/ufshcd.c | 4 +- drivers/scsi/wd33c93.c | 6 +- include/scsi/scsi.h | 1 + include/scsi/scsi_cmnd.h | 5 + 63 files changed, 1307 insertions(+), 7668 deletions(-) delete mode 100644 drivers/scsi/gdth.c delete mode 100644 drivers/scsi/gdth.h delete mode 100644 drivers/scsi/gdth_ioctl.h delete mode 100644 drivers/scsi/gdth_proc.c delete mode 100644 drivers/scsi/gdth_proc.h
Signature · 1 line
2.29.2