Skip to content

fsnotify fixes and cleanups

Amir Goldstein linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7fsnotify: generalize handle_inode_event()fs/nfsd/filecache.c fs/notify/dnotify/dnotify.c fs/notify/fsnotify.c +4 more+31 -133 replies
2/7inotify: convert to handle_inode_event() interfacefs/notify/inotify/inotify.h fs/notify/inotify/inotify_fsnotify.c fs/notify/inotify/inotify_user.c+15 -484 replies
3/7fsnotify: fix events reported to watching parent and childfs/notify/fanotify/fanotify.c fs/notify/fsnotify.c include/linux/fsnotify_backend.h+51 -403 replies
4/7fsnotify: clarify object type argumentfs/notify/fanotify/fanotify_user.c fs/notify/group.c fs/notify/mark.c +1 more+27 -320 replies
5/7fsnotify: separate mark iterator type from object type enumfs/notify/fanotify/fanotify.c fs/notify/fsnotify.c fs/notify/mark.c +1 more+50 -270 replies
6/7fsnotify: optimize FS_MODIFY events with no ignored masksfs/notify/fanotify/fanotify_user.c fs/notify/fsnotify.c fs/notify/mark.c +1 more+45 -160 replies
7/7fsnotify: optimize merging of marks with no ignored masksfs/notify/fanotify/fanotify.c fs/notify/fsnotify.c include/linux/fsnotify_backend.h+27 -82 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] fsnotify fixes and cleanups

Jan,

I was working on some non urgent cleanups and stumbled on a bug, so flushing my patch queue as is.

Patches 1-2 are cleanups needed for the bug fix in patch 3. This [1] LTP test demonstrates the bug.

Patches 4-5 are pretty simple cleanups that you may or may not like to apply without the work that they build up to (I started this as prep work for subtree marks iterator).

Patches 6-7 are optimizations related to ignored mask which we discussed in the past. I have written them a while back and had put them aside because I have no means to run performance tests that will demonstrate the benefit, which is probably not huge.

Since you suggested those optimizations (at least the first one), I decided to post and let you choose what to do with them.

Thanks,
Amir.

[1] https://github.com/amir73il/ltp/commits/fsnotify-fixes

Amir Goldstein (7):
fsnotify: generalize handle_inode_event()
inotify: convert to handle_inode_event() interface
fsnotify: fix events reported to watching parent and child
fsnotify: clarify object type argument
fsnotify: separate mark iterator type from object type enum
fsnotify: optimize FS_MODIFY events with no ignored masks
fsnotify: optimize merging of marks with no ignored masks

 fs/nfsd/filecache.c                  |   2 +-
 fs/notify/dnotify/dnotify.c          |   2 +-
 fs/notify/fanotify/fanotify.c        |  16 +--
 fs/notify/fanotify/fanotify_user.c   |  44 +++++---
 fs/notify/fsnotify.c                 | 147 +++++++++++++++++----------
 fs/notify/group.c                    |   2 +-
 fs/notify/inotify/inotify.h          |   9 +-
 fs/notify/inotify/inotify_fsnotify.c |  47 ++-------
 fs/notify/inotify/inotify_user.c     |   7 +-
 fs/notify/mark.c                     |  30 +++---
 include/linux/fsnotify_backend.h     |  92 +++++++++++------
 kernel/audit_fsnotify.c              |   2 +-
 kernel/audit_tree.c                  |   2 +-
 kernel/audit_watch.c                 |   2 +-
 14 files changed, 233 insertions(+), 171 deletions(-)
Signature · 1 line
2.25.1