Skip to content

MSFT offloading support for advertisement monitor

Archie Pusaka linux-bluetooth lkml netdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 2 repliesIn review
  2. v55 patches 2 repliesSuperseded
  3. v45 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches7 repliesSuperseded
v25 patches3 repliesSuperseded
v15 patches7 repliesSuperseded

Changes in v6 from the cover letter

* New patch "advmon offload MSFT interleave scanning integration"
* New patch "disable advertisement filters during suspend"

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Bluetooth: advmon offload MSFT add rssi supportinclude/net/bluetooth/hci_core.h include/net/bluetooth/mgmt.h net/bluetooth/mgmt.c+178 -721 reply
2/7Bluetooth: advmon offload MSFT add monitorinclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c net/bluetooth/mgmt.c +2 more+356 -430 replies
3/7Bluetooth: advmon offload MSFT remove monitorinclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c net/bluetooth/mgmt.c +2 more+323 -500 replies
4/7Bluetooth: advmon offload MSFT handle controller resetnet/bluetooth/msft.c+71 -50 replies
5/7Bluetooth: advmon offload MSFT handle filter enablementnet/bluetooth/msft.c net/bluetooth/msft.h+73 -00 replies
6/7Bluetooth: advmon offload MSFT interleave scanning integrationnet/bluetooth/hci_request.c+11 -90 replies
7/7Bluetooth: disable advertisement filters during suspendinclude/net/bluetooth/hci_core.h net/bluetooth/hci_request.c net/bluetooth/msft.c +1 more+46 -50 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchMiao-chen ChouYun-Hao ChungAbhishek Pandit-SubediManish Mandlik
1/7R-b R-b R-b
2/7R-b R-b R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/7] MSFT offloading support for advertisement monitor

From: Archie Pusaka <[email protected]>

Hi linux-bluetooth,

This series of patches manages the hardware offloading part of MSFT extension API. The full documentation can be accessed by this link:
https://docs.microsoft.com/en-us/windows-hardware/drivers/bluetooth/microsoft-defined-bluetooth-hci-commands-and-events

Only four of the HCI commands are planned to be implemented:
HCI_VS_MSFT_Read_Supported_Features (implemented in previous patch), HCI_VS_MSFT_LE_Monitor_Advertisement, HCI_VS_MSFT_LE_Cancel_Monitor_Advertisement, and HCI_VS_MSFT_LE_Set_Advertisement_Filter_Enable.
These are the commands which would be used for advertisement monitor feature. Only if the controller supports the MSFT extension would these commands be sent. Otherwise, software-based monitoring would be performed in the user space instead.

Thanks in advance for your feedback!

Archie

Changes in v6:
* New patch "advmon offload MSFT interleave scanning integration"
* New patch "disable advertisement filters during suspend"

Changes in v5:
* Discard struct flags on msft_data and use it's members directly

Changes in v4:
* Change the logic of merging add_adv_patterns_monitor with rssi
* Aligning variable declaration on mgmt.h
* Replacing the usage of BT_DBG with bt_dev_dbg

Changes in v3:
* Flips the order of rssi and pattern_count on mgmt struct
* Fix return type of msft_remove_monitor

Changes in v2:
* Add a new opcode instead of modifying an existing one
* Also implement the new MGMT opcode and merge the functionality with the old one.

Archie Pusaka (6):
Bluetooth: advmon offload MSFT add rssi support
Bluetooth: advmon offload MSFT add monitor
Bluetooth: advmon offload MSFT remove monitor
Bluetooth: advmon offload MSFT handle controller reset
Bluetooth: advmon offload MSFT handle filter enablement
Bluetooth: advmon offload MSFT interleave scanning integration

Howard Chung (1):
Bluetooth: disable advertisement filters during suspend

 include/net/bluetooth/hci_core.h |  36 ++-
 include/net/bluetooth/mgmt.h     |  16 ++
 net/bluetooth/hci_core.c         | 174 +++++++++---
 net/bluetooth/hci_request.c      |  49 +++-
 net/bluetooth/mgmt.c             | 391 +++++++++++++++++++-------
 net/bluetooth/msft.c             | 460 ++++++++++++++++++++++++++++++-
 net/bluetooth/msft.h             |  30 ++
 7 files changed, 1015 insertions(+), 141 deletions(-)
Signature · 1 line
2.30.0.280.ga3ce27912f-goog