Skip to content

vnc: support some new extensions.

Gerd Hoffmann qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 5 repliesIn review
  2. v29 patches 13 repliesSuperseded
  3. v19 patches 17 repliesSuperseded

Changes in v3 from the cover letter

- dropped cursor patches (already merged).
- fix client initialization (reply to update request not set encoding).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3vnc: move check into vnc_cursor_defineui/vnc.c+6 -62 replies
2/3vnc: move initialization to framebuffer_update_requestui/vnc.c+4 -71 reply
3/3vnc: add support for extended desktop resizeui/vnc.c ui/vnc.h+65 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMarc-André LureauDaniel P. Berrangé
1/3R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] vnc: support some new extensions.

The rfb standard keeps envolving. While the official spec is kind of frozen since a decade or so the community maintains an updated version of the spec at:
https://github.com/rfbproto/rfbproto/

This series adds support for two new extensions from that spec: alpha cursor and extended desktop resize.

alpha cursor allows a full alpha channel for the cursor image (unlike the rich cursor extension which has only a bitmask for transparency).

extended desktop resize makes the desktop-resize work both ways, i.e. we can not only signal guest display resolution changes to the vnc client but also vnc client window size changes to the guest.

Tested with tigervnc.

Support for gtk-vnc is in progress.

v3:
- dropped cursor patches (already merged).
- fix client initialization (reply to update request not set encoding).

v2:
- dropped qxl bits (will be a separate patch series).
- use error codes for desktop resize responses.
- little tweaks here and there.
- pick up some review tags.

Gerd Hoffmann (3):
vnc: move check into vnc_cursor_define
vnc: move initialization to framebuffer_update_request
vnc: add support for extended desktop resize

 ui/vnc.h |  2 ++
 ui/vnc.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++---------
 2 files changed, 74 insertions(+), 13 deletions(-)
Signature · 1 line
2.29.2