Skip to content

block: Fix block_resize deadlock with iothreads

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block: Simplify qmp_block_resize() error pathsblockdev.c+3 -42 replies
2/3block: Fix locking in qmp_block_resize()blockdev.c+4 -12 replies
3/3block: Fix deadlock in bdrv_co_yield_to_drain()block/io.c+24 -172 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-Ogievskiy
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] block: Fix block_resize deadlock with iothreads

The conversion of qmp_block_resize() to coroutines exposed a preexisting locking bug in the drain implementation that can cause deadlocks.

As it happens, fixing this bug reveals in turn that the locking in qmp_block_resize() itself is incomplete, too.

Kevin Wolf (3):
block: Simplify qmp_block_resize() error paths
block: Fix locking in qmp_block_resize()
block: Fix deadlock in bdrv_co_yield_to_drain()

 block/io.c | 41 ++++++++++++++++++++++++-----------------
 blockdev.c | 12 +++++++-----
 2 files changed, 31 insertions(+), 22 deletions(-)
Signature · 1 line
2.28.0