block: Fix block_resize deadlock with iothreads
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | block: Simplify qmp_block_resize() error pathsblockdev.c | +3 | 2 replies | |
| 2/3 | block: Fix locking in qmp_block_resize()blockdev.c | +4 | 2 replies | |
| 3/3 | block: Fix deadlock in bdrv_co_yield_to_drain()block/ | +24 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] block: Fix block_resize deadlock with iothreads
The conversion of qmp_block_resize() to coroutines exposed a preexisting locking bug in the drain implementation that can cause deadlocks.
As it happens, fixing this bug reveals in turn that the locking in qmp_block_resize() itself is incomplete, too.
Kevin Wolf (3):
block: Simplify qmp_block_resize() error paths
block: Fix locking in qmp_block_resize()
block: Fix deadlock in bdrv_co_yield_to_drain()
block/io.c | 41 ++++++++++++++++++++++++----------------- blockdev.c | 12 +++++++----- 2 files changed, 31 insertions(+), 22 deletions(-)
Signature · 1 line
2.28.0