Skip to content

Common:fdt: Check for error return

Hongwei Zhang u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 1 patch 0 repliesNew

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [u-boot,v2019.04-aspeed, v1 0/1] Common:fdt: Check for error return

Thanks Joel,

Quoted 15 lines

From: Joel Stanley <[email protected]>
Sent: Wednesday, December 2, 2020 9:17 PM
To: Hongwei Zhang

Hello Hongwei,

Quoted 7 lines · Hongwei Zhang

Hello Reviewer,

Check for negative return value of fdt_noffset from calling boot_get_fdt_fit(). Otherwise, when fdt subimage is corrupted, the u-boot report bad hash value but continue loading kernel image and get hanged later.

Quoted 6 lines

I can see from your subject line that you intended this to go to Aspeed's fork of u-boot. That's fine, but you shouldn't cc the upstream maintainers as they don't care for these changes.

If the bug exists in mainline u-boot, you should certainly send the fix there and ask for it to be backported to the aspeed fork.

I think this issue existing in mainline u-boot, however, I have difficulty to include 'master' branch of u-boot in openbmc project, to acturaly test it. There are compiling errors.

Also, I'm not sure for mainline u-boot, which branch should I use to test and verification? is it 'master', or 'next' branch?

--Hongwei

Quoted 15 lines

Cheers,

Joel

Quoted 10 lines

Hongwei Zhang (1):
Common:fdt: Check for error return value

 common/image-fdt.c | 3 +++
 1 file changed, 3 insertions(+)

--
2.17.1