Skip to content

Display glitches fixes

Anshuman Gupta intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1drm/i915/dp: optimize pps_lock wherever requireddrivers/gpu/drm/i915/display/intel_dp.c+45 -22 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Intel-gfx] [PATCH 0/1] Display glitches fixes

TGL chrome-OS platform has observed display glitches while display brightness is being changed rapidly.
It creates a scenario where brightness is being changed simultaneously with display flips updates in different threads.

Brightness update requires pps_lock, current pps_lock implementation requires to get AUX power domain, which triggers DC3CO disallow/allow sequence being async with display flips.

This triggers a race between dc3co exit delay and display flip, and potentially causing a display glitch due to some display register being programmed before completing dc3co exit delay. Exactly which register programming causing this glitch is still being work in progressed.

This patch adds a optimization to avoid unnecessary "DC off" power well enable/disable(D3CO disallow/allow) noise around brightness update.

This patch helps to remove the display glitch in case of simultaneous brightness update and display flips.

Anshuman Gupta (1):
drm/i915/dp: optimize pps_lock wherever required

 drivers/gpu/drm/i915/display/intel_dp.c | 47 +++++++++++++++++++++++--
 1 file changed, 45 insertions(+), 2 deletions(-)
Signature · 6 lines
2.26.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx