Skip to content

Fanotify cleanup and test for v5.9 regression

Amir Goldstein ltp 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5syscalls/fanotify: Generalize check for FAN_REPORT_FID supporttestcases/kernel/syscalls/fanotify/fanotify.h testcases/kernel/syscalls/fanotify/fanotify01.c testcases/kernel/syscalls/fanotify/fanotify13.c +2 more+34 -222 replies
2/5syscalls/fanotify: Use generic checks for fanotify_init flagstestcases/kernel/syscalls/fanotify/fanotify10.c testcases/kernel/syscalls/fanotify/fanotify11.c testcases/kernel/syscalls/fanotify/fanotify16.c+21 -402 replies
3/5syscalls/fanotify09: Read variable length eventstestcases/kernel/syscalls/fanotify/fanotify09.c+60 -284 replies
3/5syscalls/fanotify09: Read variable length eventstestcases/kernel/syscalls/fanotify/fanotify09.c+1 -01 reply
3/5syscalls/fanotify09: Read variable length eventstestcases/kernel/syscalls/fanotify/fanotify09.c+1 -01 reply
4/5syscalls/fanotify09: Add test case with two non-dir childrentestcases/kernel/syscalls/fanotify/fanotify09.c+28 -102 replies
5/5syscalls/fanotify09: Add test case for events with filename infotestcases/kernel/syscalls/fanotify/fanotify09.c+42 -72 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchPetr VorelJan Kara
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
3/5R-b R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [LTP] [PATCH 0/5] Fanotify cleanup and test for v5.9 regression

Hi Petr,

Here are my followup patches to your great cleanup and a new test for a bug fix that is already included in v5.9.y.

Note that I resurrected the helper from your V5 patches that you turned into a macro following Cyril's comment. I hope you both find the result satisfying.

There are no direct calls to fanotify_init() after those cleanups (except for the intended use in fanotify14).

FYI, I have another test (inotify) for another v5.9 regression. The fix is queued for upstream, but did reach upstream yet, so I will post that test later.

Thanks,
Amir.

Amir Goldstein (5):
syscalls/fanotify: Generalize check for FAN_REPORT_FID support syscalls/fanotify: Use generic checks for fanotify_init flags syscalls/fanotify09: Read variable length events syscalls/fanotify09: Add test case with two non-dir children syscalls/fanotify09: Add test case for events with filename info

 testcases/kernel/syscalls/fanotify/fanotify.h |  46 +++--
 .../kernel/syscalls/fanotify/fanotify01.c     |   4 +-
 .../kernel/syscalls/fanotify/fanotify09.c     | 167 +++++++++++++-----
 .../kernel/syscalls/fanotify/fanotify10.c     |  26 ++-
 .../kernel/syscalls/fanotify/fanotify11.c     |  21 +--
 .../kernel/syscalls/fanotify/fanotify13.c     |   2 +-
 .../kernel/syscalls/fanotify/fanotify15.c     |   2 +-
 .../kernel/syscalls/fanotify/fanotify16.c     |  14 +-
 8 files changed, 180 insertions(+), 102 deletions(-)
Signature · 1 line
2.25.1