Skip to content

Apply COR-filter to the block-stream permanently

Vladimir Sementsov-Ogievskiy qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v15 Latest13 patches 14 repliesApplied
  2. v1413 patches 23 repliesSuperseded

Changes in v15 from the cover letter · 25 lines

02: s/ = / = /
add Max's r-b
03: add Max's r-b
04: since: 6.0
indent comment
add Max's r-b
05: changed commit msg
wording
document the default
since: 6.0
use bdrv_find_node(), fix errp overwriting
freeze the chain
check bottom is not filter
ref bottom_bs
06: limit to qcow2 to not care
use qemu-img rebase -u -b ''
07: use assert instead of abort
add Max's r-b
08: add Max's r-b
09: changed commit msg (was "stream: skip filters when writing backing file name to QCOW2 header")
keep mostly same logic for the case when backing-file is specified, don't do bdrv_find_backing_image()
10: don't restrict backing-file for now
11: add Max's r-b
12: add Max's r-b
13: chain is now frozen in filter, so the logic changed around add/remove fitlter

Patches in v15 Applied

#Subject and filesSizeRepliesApplied
1/13copy-on-read: support preadv/pwritev_part functionsblock/copy-on-read.c+16 -120 replies
2/13block: add API function to insert a nodeblock.c include/block/block.h+27 -00 replies
3/13copy-on-read: add filter drop functionblock/copy-on-read.c block/copy-on-read.h+88 -00 replies
4/13qapi: add filter-node-name to block-streamblock/monitor/block-hmp-cmds.c block/stream.c blockdev.c +2 more+20 -51 reply
5/13qapi: copy-on-read filter: add 'bottom' optionblock/copy-on-read.c qapi/block-core.json+115 -30 replies
6/13iotests: add #310 to test bottom node in COR drivertests/qemu-iotests/310 tests/qemu-iotests/310.out tests/qemu-iotests/group+132 -00 replies
7/13block: include supported_read_flags into BDS structureblock/io.c include/block/block_int.h+12 -20 replies
8/13copy-on-read: skip non-guest reads if no copy neededblock/copy-on-read.c include/block/block.h+15 -70 replies
9/13stream: rework backing-file changingblock/stream.c blockdev.c+6 -113 replies
10/13qapi: block-stream: add "bottom" argumentblock/monitor/block-hmp-cmds.c block/stream.c blockdev.c +2 more+94 -314 replies
11/13iotests: 30: prepare to COR filter insertion by stream jobtests/qemu-iotests/030+3 -10 replies
12/13block/stream: add s->target_bsblock/stream.c+10 -130 replies
13/13block: apply COR-filter to block-stream jobsblock/stream.c tests/qemu-iotests/030 tests/qemu-iotests/141.out +1 more+80 -554 replies

Reviews trailers per patch

11 of 13 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyMax Reitz
1/13R-b
2/13R-b R-b
3/13R-b R-b
4/13R-b R-b
5/13
6/13
7/13R-b
8/13R-b R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v15 thread

Cover letter [PATCH v15 00/13] Apply COR-filter to the block-stream permanently

Hi all!

Here is a new version of cor-filter in block-stream series. Main change is freezing the chain in cor-filter itself.

v15:
02: s/ = / = /
add Max's r-b
03: add Max's r-b
04: since: 6.0
indent comment
add Max's r-b
05: changed commit msg
wording
document the default
since: 6.0
use bdrv_find_node(), fix errp overwriting
freeze the chain
check bottom is not filter
ref bottom_bs
06: limit to qcow2 to not care
use qemu-img rebase -u -b ''
07: use assert instead of abort
add Max's r-b
08: add Max's r-b
09: changed commit msg (was "stream: skip filters when writing backing file name to QCOW2 header")
keep mostly same logic for the case when backing-file is specified, don't do bdrv_find_backing_image()
10: don't restrict backing-file for now
11: add Max's r-b
12: add Max's r-b
13: chain is now frozen in filter, so the logic changed around add/remove fitlter

Andrey Shinkevich (10):
copy-on-read: support preadv/pwritev_part functions
block: add API function to insert a node
copy-on-read: add filter drop function
qapi: add filter-node-name to block-stream
qapi: copy-on-read filter: add 'bottom' option
iotests: add #310 to test bottom node in COR driver
block: include supported_read_flags into BDS structure
copy-on-read: skip non-guest reads if no copy needed
stream: rework backing-file changing
block: apply COR-filter to block-stream jobs

Vladimir Sementsov-Ogievskiy (3):
qapi: block-stream: add "bottom" argument
iotests: 30: prepare to COR filter insertion by stream job block/stream: add s->target_bs

 qapi/block-core.json           |  38 ++++++-
 block/copy-on-read.h           |  32 ++++++
 include/block/block.h          |  10 +-
 include/block/block_int.h      |  12 ++-
 block.c                        |  25 +++++
 block/copy-on-read.c           | 184 +++++++++++++++++++++++++++++---
 block/io.c                     |  10 +-
 block/monitor/block-hmp-cmds.c |   7 +-
 block/stream.c                 | 185 ++++++++++++++++++++-------------
 blockdev.c                     |  69 +++++++++---
 tests/qemu-iotests/030         |  12 ++-
 tests/qemu-iotests/141.out     |   2 +-
 tests/qemu-iotests/245         |  20 ++--
 tests/qemu-iotests/310         | 116 +++++++++++++++++++++
 tests/qemu-iotests/310.out     |  15 +++
 tests/qemu-iotests/group       |   1 +
 16 files changed, 608 insertions(+), 130 deletions(-)
 create mode 100644 block/copy-on-read.h
 create mode 100755 tests/qemu-iotests/310
 create mode 100644 tests/qemu-iotests/310.out
Signature · 1 line
2.25.4