Skip to content

RFC Reduce worst-case scanning of runqueues in select_idle_sibling

Mel Gorman linux-arm-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sched/fair: Remove SIS_AVG_CPUkernel/sched/fair.c kernel/sched/features.h+0 -410 replies
2/4sched/fair: Do not replace recent_used_cpu with the new targetkernel/sched/fair.c+1 -32 replies
3/4sched/fair: Return an idle cpu if one is found after a failed search for an idle corekernel/sched/fair.c+7 -11 reply
4/4sched/fair: Avoid revisiting CPUs multiple times during select_idle_siblingkernel/sched/fair.c+29 -110 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchVincent Guittot
1/4
2/4
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/4] Reduce worst-case scanning of runqueues in select_idle_sibling

This is a minimal series to reduce the amount of runqueue scanning in select_idle_sibling in the worst case.

Patch 1 removes SIS_AVG_CPU because it's unused.

Patch 2 improves the hit rate of p->recent_used_cpu to reduce the amount
of scanning. It should be relatively uncontroversial

Patch 3-4 scans the runqueues in a single pass for select_idle_core()
and select_idle_cpu() so runqueues are not scanned twice. It's a tradeoff because it benefits deep scans but introduces overhead for shallow scans.

Even if patch 3-4 is rejected to allow more time for Aubrey's idle cpu mask approach to stand on its own, patches 1-2 should be fine. The main decision with patch 4 is whether select_idle_core() should do a full scan when searching for an idle core, whether it should be throttled in some other fashion or whether it should be just left alone.

Signature · 1 line
2.26.2