Additional CCS feature support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest24 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | ccs: Add digital gain supportdrivers/ | +16 | 0 replies | |
| 2/24 | ccs: Add support for old-style SMIA digital gaindrivers/ drivers/ | +33 | 0 replies | |
| 3/24 | ccs: Remove analogue gain fielddrivers/ drivers/ | +6 | 0 replies | |
| 4/24 | ccs: Only add analogue gain control if the device supports itdrivers/ | +10 | 0 replies | |
| 5/24 | v4l: uapi: Add user control base for CCS controlsinclude/ | +5 | 0 replies | |
| 6/24 | Documentation: ccs: Add user documentation for the CCS driverDocumentation/ Documentation/ MAINTAINERS | +61 | 0 replies | |
| 7/24 | v4l: uapi: ccs: Add controls for analogue gain constantsDocumentation/ MAINTAINERS include/ | +40 | 0 replies | |
| 7/24 | v4l: uapi: ccs: Add controls for analogue gain constantsDocumentation/ MAINTAINERS include/ | +40 | 0 replies | |
| 8/24 | ccs: Add support for analogue gain coefficient controlsdrivers/ | +36 | 0 replies | |
| 9/24 | v4l: uapi: ccs: Add controls for CCS alternative analogue gainDocumentation/ include/ | +15 | 0 replies | |
| 10/24 | ccs: Add support for alternate analogue global gaindrivers/ | +55 | 0 replies | |
| 11/24 | ccs: Add debug prints for MSR registersdrivers/ | +8 | 0 replies | |
| 12/24 | v4l: uapi: ccs: Add CCS controls for shading correctionDocumentation/ include/ | +15 | 0 replies | |
| 13/24 | ccs: Add shading correction and luminance correction level controlsdrivers/ drivers/ | +47 | 0 replies | |
| 14/24 | ccs: Get the endpoint by port rather than any next endpointdrivers/ | +2 | 0 replies | |
| 15/24 | ccs: Don't change the I²C address just for software resetdrivers/ | +0 | 0 replies | |
| 16/24 | ccs: Only do software reset if we have no hardware resetdrivers/ | +6 | 0 replies | |
| 17/24 | ccs: Wait until software reset is donedrivers/ | +15 | 2 replies | |
| 18/24 | ccs: Hardware requires a delay after starting the clock of lifting resetdrivers/ | +16 | 0 replies | |
| 19/24 | ccs: Add a sanity check for external clock frequencydrivers/ | +5 | 0 replies | |
| 20/24 | ccs: Support and default to auto PHY controldrivers/ | +43 | 0 replies | |
| 21/24 | Documentation: Include CCS PLL calculator to CCS driver documentationDocumentation/ | +13 | 0 replies | |
| 22/24 | ccs-pll: Switch from standard integer types to kernel onesdrivers/ drivers/ | +100 | 0 replies | |
| 23/24 | ccs: Switch from standard integer types to kernel onesdrivers/ drivers/ drivers/ | +14 | 0 replies | |
| 24/24 | Revert "media: ccs-pll: Fix MODULE_LICENSE"drivers/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/24] Additional CCS feature support
Hello everyone,
Here's a set of patches that turn the existing SMIA driver into a MIPI CCS driver while maintaining SMIA support. A number of bugs in the existing code are fixed in this set, too.
The changes at this point are primarily focused on dealing with new mandatory driver features related to PLL configuration (as CCS allows for much more variation there) and things such as integer conversion from U16.U16 format instead of float. There are some other new features as well such as digital gain and support for getting device specific analogue gain coefficients.
A new feature in CCS is CCS static data which makes it possible to obtain sensor's capabilities and limits from a file chosen based on sensor identification. CCS static data is used also for storing MSR registers so supporting new, CCS compliant devices requires no driver changes.
Also DT bindings are updated accordingly and converted to YAML format.
More information on MIPI CCS can be found here:
<URL:https://www.mipi.org/specifications/camera-command-set>
Comments are welcome.
since the big, big patchset (v2):
- Split into more easily reviewable chunks (this is the first of maybe three). The cover page describes the entire big set. This set contains support for additional configurability, more bugfixes, power sequence alignment with CCS and other tasks postponed in earlier patches.
- Added more documentation (driver, controls, PLL calculator).
- Switch from C99 integer types to Linux types.
- Fix file order in MAINTAINERS.
- Revert MODULE_LICENSE change to "GPL" -> "GPL v2"
- Support automatic PHY control, and default to it instead of using UI-based control.
- Remove V4L2_CID_CCS_LUMINANCE_SHADING_CORRECTION and V4L2_CID_CCS_SHADING_CORRECTION_CAPABILITY controls. This way we don't tell all the device capabilities to the user but it's unlikely anyone will really want to know this part precisely.
- Align with CCS power-on sequence.
- Don't do software reset if we have a reset GPIO.
- Bail out in probe if the external clock frequency is zero.
- Activate the luminance control only when shading correction is enabled.
Sakari Ailus (24):
ccs: Add digital gain support
ccs: Add support for old-style SMIA digital gain
ccs: Remove analogue gain field
ccs: Only add analogue gain control if the device supports it
v4l: uapi: Add user control base for CCS controls
Documentation: ccs: Add user documentation for the CCS driver
v4l: uapi: ccs: Add controls for analogue gain constants
ccs: Add support for analogue gain coefficient controls
v4l: uapi: ccs: Add controls for CCS alternative analogue gain
ccs: Add support for alternate analogue global gain
ccs: Add debug prints for MSR registers
v4l: uapi: ccs: Add CCS controls for shading correction
ccs: Add shading correction and luminance correction level controls
ccs: Get the endpoint by port rather than any next endpoint
ccs: Don't change the I²C address just for software reset
ccs: Only do software reset if we have no hardware reset
ccs: Wait until software reset is done
ccs: Hardware requires a delay after starting the clock of lifting
reset
ccs: Add a sanity check for external clock frequency
ccs: Support and default to auto PHY control
Documentation: Include CCS PLL calculator to CCS driver documentation
ccs-pll: Switch from standard integer types to kernel ones
ccs: Switch from standard integer types to kernel ones Revert "media: ccs-pll: Fix MODULE_LICENSE"
.../driver-api/media/drivers/ccs/ccs.rst | 13 + .../userspace-api/media/drivers/ccs.rst | 110 ++++++ .../userspace-api/media/drivers/index.rst | 1 + MAINTAINERS | 2 + drivers/media/i2c/ccs-pll.c | 116 +++---- drivers/media/i2c/ccs-pll.h | 86 ++--- drivers/media/i2c/ccs/ccs-core.c | 318 +++++++++++++++--- drivers/media/i2c/ccs/ccs-reg-access.c | 29 +- drivers/media/i2c/ccs/ccs.h | 8 +- drivers/media/i2c/ccs/smiapp-reg-defs.h | 2 + include/uapi/linux/ccs.h | 18 + include/uapi/linux/v4l2-controls.h | 5 + 12 files changed, 549 insertions(+), 159 deletions(-) create mode 100644 Documentation/userspace-api/media/drivers/ccs.rst create mode 100644 include/uapi/linux/ccs.h
Signature · 1 line
2.29.2