video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
Get series with b4
b4 am 20201208161630.GP32272@bill-the-catVersions newest first
- v1 Latest0 of 6 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 6 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter FW: [PATCH 0/6] video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME
Quoted 87 lines · Patrick DELAUNAY
Hi Soeren,
Quoted 11 lines
From: Soeren Moch <[email protected]> Sent: dimanche 6 d?cembre 2020 20:59 On
Quoted 8 lines · Patrick Delaunay
I propose this serie to remove the vidconsole work-around, activated with the 2 options
VIDCONSOLE_AS_LCDandVIDCONSOLE_AS_NAMEand cleanup the associated code inconsole.c(under #ifdefCONFIG_VIDCONSOLE_AS_LCD) This options are now obsolete and they was planned to be removed around the end of 2020. I propose this patchset for v2021.04 even if I don't test this serie on real boards.Quoted 2 lines
I really would like to keep this code for now.
I propose to remove these options because they are indicated obsolete in the config description
in
drivers/video/Kconfig(I see it during code review):"This option will be removed around the end of 2020"
But I have no issue to kept it.
Quoted 6 lines
On the tbs2910 board this workaround was introduced in the last u-boot release (v2020.10), so there was almost no time for end users to notice the warning and to update there environment. Not every end user installs every new u-boot release, so we really should give more time for this change.
I agree that for your project, with migration to
DM_VIDEOit is a really short notice.??? commit
645d39aea367064868dcdd30c411806f4403b67b??? board: tbs2910: Fix video output with existing environments
=> only integrated in v2020.10-rc2, sorry to miss it
Quoted 7 lines
This workaround is self-contained, small, easy to maintain, and strictly opt-in. So this workaround hurts nobody, but removing this will let users alone without any HDMI output. So on this board (without included serial console port), this will result in unhappy users, especially since without any console output there is no chance to get any idea what is going wrong.
Initially, I proposed this patch to cleanup the
console.ccode with 2 other series:1) http://patchwork.ozlabs.org/project/uboot/list/?series=218309
??? "console: remove #ifdef CONFIG when it is possible"
2) http://patchwork.ozlabs.org/project/uboot/list/?series=218089
??? "console: cosmetics: remove #if 0"
And I just want just to remove the remaining "#ifdef
CONFIG_...."? inconsole.cBut I agree that I need to change my proposal to remove this workaround code
(it is only use to help the DM VIDEO migration for existing board)
and change the release target.
I propose to :
- remove patch 1/6 of the serie for your board
- no more remove the options in 6/6 but add warning in
Makefilewhen the option is activated? and change target in config desciption
ifeq ($(CONFIG_VIDCONSOLE_AS_LCD),y)
??? @echo >&2 "===================== WARNING ======================" ??? @echo >&2 "This board does useCONFIG_VIDCONSOLE_AS_LCDworkaround." ??? @echo >&2 "Please update the existing user defined environments before " ??? @echo >&2 "v2022.01 release."
??? @echo >&2 "Failure to update by the deadline may result in video console"
Quoted 5 lines
@echo >&2 "issue when this woarkaround will be removed." ??? @echo >&2 "====================================================" endif
=> open point: which acceptable target to remove this feature ? v2022.01 ?
This sounds like a good plan and reasonable date to me. Anatolij? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201208/f2a19038/attachment.sig>