Skip to content

fixes and refactoring changes for bnxt

Ajit Khaparde dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17net/bnxt: fix RX rings in RSS redirection tabledrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c+14 -30 replies
2/17net/bnxt: fix VNIC config on Rx queue stopdrivers/net/bnxt/bnxt_rxq.c+21 -50 replies
3/17net/bnxt: remove unused fielddrivers/net/bnxt/bnxt.h+0 -10 replies
4/17net/bnxt: release hwrm lock in the error casedrivers/net/bnxt/bnxt_hwrm.c+1 -00 replies
5/17net/bnxt: remove references to Thordrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_hwrm.c +6 more+70 -690 replies
6/17net/bnxt: fix to return error when fw command failsdrivers/net/bnxt/bnxt_ethdev.c+4 -40 replies
7/17net/bnxt: fix cleanup on mutex init failuredrivers/net/bnxt/bnxt_ethdev.c+3 -10 replies
8/17net/bnxt: fix format specifier for unsigned intdrivers/net/bnxt/tf_core/tf_core.c+1 -10 replies
9/17net/bnxt: fix max rings computationdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_rxq.c +1 more+34 -180 replies
10/17net/bnxt: support for 236 queues in NS3drivers/net/bnxt/bnxt.h+1 -20 replies
11/17net/bnxt: use the right function to free mbufdrivers/net/bnxt/bnxt_reps.c+1 -10 replies
12/17net/bnxt: remove function declarationdrivers/net/bnxt/bnxt_hwrm.h+0 -22 replies
13/17net/bnxt: fix vnic RSS configure functiondrivers/net/bnxt/bnxt_hwrm.c+20 -220 replies
14/17net/bnxt: fix PF resource querydrivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_hwrm.c+35 -80 replies
15/17net/bnxt: changes to indentation and coding styledrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_reps.c +1 more+8 -100 replies
16/17net/bnxt: add missing commentsdrivers/net/bnxt/bnxt.h drivers/net/bnxt/tf_ulp/ulp_template_db_act.c drivers/net/bnxt/tf_ulp/ulp_template_db_class.c+17 -00 replies
17/17net/bnxt: modify ring index logicdrivers/net/bnxt/bnxt_cpr.h drivers/net/bnxt/bnxt_hwrm.c drivers/net/bnxt/bnxt_reps.c +9 more+180 -1360 replies

Reviews trailers per patch

8 of 17 patches have a Reviewed-by or Acked-by.

PatchAjit KhapardeLance RichardsonSomnath KoturVenkat DuvvuruKalesh AP
1/17R-b
2/17R-b R-b R-b
3/17
4/17R-b R-b
5/17
6/17R-b R-b
7/17
8/17
9/17R-b
10/17R-b
11/17
12/17
13/17R-b R-b
14/17R-b R-b R-b
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH 00/17] fixes and refactoring changes for bnxt

Some fixes and refactoring changes for bnxt PMD.

Ajit Khaparde (9):
net/bnxt: remove unused field
net/bnxt: remove references to Thor net/bnxt: fix cleanup on mutex init failure net/bnxt: fix format specifier for unsigned int net/bnxt: use the right function to free mbuf net/bnxt: remove function declaration net/bnxt: changes to indentation and coding style net/bnxt: add missing comments
net/bnxt: modify ring index logic

Kalesh AP (3):
net/bnxt: release hwrm lock in the error case net/bnxt: fix to return error when fw command fails net/bnxt: fix vnic RSS configure function

Rahul Gupta (1):
net/bnxt: support for 236 queues in NS3

Samik Gupta (2):
net/bnxt: fix RX rings in RSS redirection table
net/bnxt: fix VNIC config on Rx queue stop

Somnath Kotur (1):
net/bnxt: fix PF resource query

Sriharsha Basavapatna (1):
net/bnxt: fix max rings computation

 drivers/net/bnxt/bnxt.h                       |  75 +++++++----
 drivers/net/bnxt/bnxt_cpr.h                   |  10 +-
 drivers/net/bnxt/bnxt_ethdev.c                |  78 ++++++-----
 drivers/net/bnxt/bnxt_hwrm.c                  | 127 +++++++++++-------
 drivers/net/bnxt/bnxt_hwrm.h                  |   2 -
 drivers/net/bnxt/bnxt_reps.c                  |   8 +-
 drivers/net/bnxt/bnxt_ring.c                  |  50 +++----
 drivers/net/bnxt/bnxt_ring.h                  |  40 ++++--
 drivers/net/bnxt/bnxt_rxq.c                   |  35 +++--
 drivers/net/bnxt/bnxt_rxr.c                   | 122 +++++++++--------
 drivers/net/bnxt/bnxt_rxr.h                   |   6 +-
 drivers/net/bnxt/bnxt_rxtx_vec_common.h       |  16 +--
 drivers/net/bnxt/bnxt_rxtx_vec_neon.c         |  16 +--
 drivers/net/bnxt/bnxt_rxtx_vec_sse.c          |  16 +--
 drivers/net/bnxt/bnxt_txq.c                   |   2 +-
 drivers/net/bnxt/bnxt_txr.c                   |  51 ++++---
 drivers/net/bnxt/bnxt_txr.h                   |   6 +-
 drivers/net/bnxt/bnxt_vnic.c                  |   4 +-
 drivers/net/bnxt/tf_core/tf_core.c            |   2 +-
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c            |   2 +-
 drivers/net/bnxt/tf_ulp/ulp_template_db_act.c |   5 +
 .../net/bnxt/tf_ulp/ulp_template_db_class.c   |   6 +
 22 files changed, 403 insertions(+), 276 deletions(-)
Signature · 15 lines
2.21.1 (Apple Git-122.3)


-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.