fix rx packets dropped issue
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest22 patches 4 repliesIn review
- v322 patches 12 repliesSuperseded
- v222 patches 14 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 12 patches | 3 replies | Superseded |
Changes in v4 from the cover letter
- moved mtu assignment to the same if-true-block of jumbo frame;
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | ethdev: fix MTU size exceeds max rx packet lengthlib/ | +22 | 0 replies | |
| 2/22 | app/testpmd: fix max rx packet length for VLAN packetsapp/ app/ app/ +1 more | +21 | 3 replies | |
| 3/22 | net/dpaa: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +5 | 0 replies | |
| 4/22 | net/dpaa2: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +5 | 0 replies | |
| 5/22 | net/e1000: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ drivers/ | +4 | 0 replies | |
| 6/22 | net/hns3: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +2 | 0 replies | |
| 7/22 | net/i40e: fix the jumbo frame flag conditiondrivers/ drivers/ drivers/ +2 more | +12 | 0 replies | |
| 8/22 | net/iavf: fix the jumbo frame flag conditiondrivers/ drivers/ | +6 | 0 replies | |
| 9/22 | net/ice: fix the jumbo frame flag conditiondrivers/ drivers/ drivers/ +1 more | +11 | 0 replies | |
| 10/22 | net/ipn3ke: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +2 | 0 replies | |
| 11/22 | net/octeontx: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +2 | 0 replies | |
| 12/22 | net/octeontx2: fix the jumbo frame flag condition for mtudrivers/ drivers/ | +3 | 0 replies | |
| 13/22 | net/qede: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +2 | 0 replies | |
| 14/22 | net/sfc: fix the jumbo frame flag condition for mtu setdrivers/ | +1 | 0 replies | |
| 15/22 | net/thunderx: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +2 | 0 replies | |
| 16/22 | net/ixgbe: fix the jumbo frame flag conditiondrivers/ drivers/ drivers/ | +5 | 0 replies | |
| 17/22 | net/cxgbe: fix the jumbo frame flag conditiondrivers/ drivers/ | +6 | 0 replies | |
| 18/22 | net/axgbe: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +7 | 0 replies | |
| 19/22 | net/enetc: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +5 | 0 replies | |
| 20/22 | net/hinic: fix the jumbo frame flag condition for mtu setdrivers/ | +4 | 0 replies | |
| 21/22 | net/nfp: fix the jumbo frame flag condition for mtu setdrivers/ | +1 | 0 replies | |
| 22/22 | net/liquidio: fix the jumbo frame flag condition for mtu setdrivers/ drivers/ | +4 | 0 replies |
Reviews trailers per patch
9 of 22 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Hemant Agrawal | Jeff Guo | Lijun Ou | Rosen Xu | Harman Kalra | Nithin Dabilpuram | Ferruh Yigit |
|---|---|---|---|---|---|---|---|
| Series | R-b | ||||||
| 1/22 | |||||||
| 2/22 | |||||||
| 3/22 | A-b | ||||||
| 4/22 | A-b | ||||||
| 5/22 | A-b | ||||||
| 6/22 | A-b | ||||||
| 7/22 | A-b | ||||||
| 8/22 | |||||||
| 9/22 | |||||||
| 10/22 | R-b | ||||||
| 11/22 | A-b | ||||||
| 12/22 | A-b | ||||||
| 13/22 | |||||||
| 14/22 | |||||||
| 15/22 | |||||||
| 16/22 | A-b | ||||||
| 17/22 | |||||||
| 18/22 | |||||||
| 19/22 | |||||||
| 20/22 | |||||||
| 21/22 | |||||||
| 22/22 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [dpdk-dev] [PATCH v4 00/22] fix rx packets dropped issue
The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, this fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead.
When the MTU(1500) set, the frame type of rx packet will be different if used different overhead, it will cause the consistency issue, and the normal packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU' can avoid this issue.
Like,
app -> max_rx_pkt_len = 1500/*mtu*/ + 22/*overhead*/ = 1522 ethdev -> 1522 > 1518/*MAX*/; max_rx_pkt_len = 1518 driver -> MTU = 1518 - 22 = 1496
Packets with size 1497-1500 are dropped although intention is to be able to send/receive them.
Following scopes will be changed:
- 'rte_ethdev'
- 'app', e.g.: 'test-pmd';
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e;
Following scopes perhaps will be impacted:
- the cases of jumbo frame related;
- the logic of 'max_rx_pkt_len' and 'mtu' related;
- the using place of 'RTE_ETHER_MAX_LEN';
---
v4:
- moved mtu assignment to the same if-true-block of jumbo frame;
v3:
- removed redundant if-conditions in rte_ethdev and testpmd;
- adjusted the alignment style;
- added offload check before updating mtu;
v2:
- defined the 'RTE_ETHER_MTU + overhead' to 'driver_ETH_MAX_LEN';
- changed the 'mtu > RTE_ETHER_MTU' to 'frame_size > driver_ETH_MAX_LEN';
---
Steve Yang (22):
ethdev: fix MTU size exceeds max rx packet length app/testpmd: fix max rx packet length for VLAN packets net/dpaa: fix the jumbo frame flag condition for mtu set net/dpaa2: fix the jumbo frame flag condition for mtu set net/e1000: fix the jumbo frame flag condition for mtu set net/hns3: fix the jumbo frame flag condition for mtu set net/i40e: fix the jumbo frame flag condition net/iavf: fix the jumbo frame flag condition net/ice: fix the jumbo frame flag condition net/ipn3ke: fix the jumbo frame flag condition for mtu set net/octeontx: fix the jumbo frame flag condition for mtu set net/octeontx2: fix the jumbo frame flag condition for mtu net/qede: fix the jumbo frame flag condition for mtu set net/sfc: fix the jumbo frame flag condition for mtu set net/thunderx: fix the jumbo frame flag condition for mtu set net/ixgbe: fix the jumbo frame flag condition net/cxgbe: fix the jumbo frame flag condition net/axgbe: fix the jumbo frame flag condition for mtu set net/enetc: fix the jumbo frame flag condition for mtu set net/hinic: fix the jumbo frame flag condition for mtu set net/nfp: fix the jumbo frame flag condition for mtu set net/liquidio: fix the jumbo frame flag condition for mtu set
app/test-pmd/cmdline.c | 6 ------ app/test-pmd/config.c | 2 +- app/test-pmd/parameters.c | 7 ++----- app/test-pmd/testpmd.c | 18 ++++++++++++++++ drivers/net/axgbe/axgbe_ethdev.c | 2 +- drivers/net/axgbe/axgbe_ethdev.h | 6 ++++++ drivers/net/cxgbe/cxgbe.h | 4 ++++ drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++-- drivers/net/dpaa/dpaa_ethdev.c | 2 +- drivers/net/dpaa/dpaa_ethdev.h | 4 ++++ drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_ethdev.h | 4 ++++ drivers/net/e1000/e1000_ethdev.h | 2 +- drivers/net/e1000/em_ethdev.c | 5 ++--- drivers/net/e1000/igb_ethdev.c | 2 +- drivers/net/enetc/enetc.h | 4 ++++ drivers/net/enetc/enetc_ethdev.c | 2 +- drivers/net/hinic/hinic_pmd_ethdev.c | 5 ++++- drivers/net/hns3/hns3_ethdev.c | 2 +- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_ethdev_vf.c | 10 ++++----- drivers/net/i40e/i40e_fdir.c | 2 +- drivers/net/i40e/i40e_rxtx.c | 8 ++++---- drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_ethdev.c | 10 ++++----- drivers/net/ice/ice_dcf_ethdev.c | 8 ++++---- drivers/net/ice/ice_ethdev.c | 2 +- drivers/net/ice/ice_ethdev.h | 1 + drivers/net/ice/ice_rxtx.c | 10 ++++----- drivers/net/ipn3ke/ipn3ke_ethdev.h | 1 + drivers/net/ipn3ke/ipn3ke_representor.c | 2 +- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- drivers/net/ixgbe/ixgbe_ethdev.h | 3 +++ drivers/net/ixgbe/ixgbe_pf.c | 2 +- drivers/net/liquidio/lio_ethdev.c | 2 +- drivers/net/liquidio/lio_ethdev.h | 3 +++ drivers/net/nfp/nfp_net.c | 2 +- drivers/net/octeontx/octeontx_ethdev.c | 2 +- drivers/net/octeontx/octeontx_ethdev.h | 1 + drivers/net/octeontx2/otx2_ethdev.h | 2 ++ drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- drivers/net/qede/qede_ethdev.c | 2 +- drivers/net/qede/qede_rxtx.h | 1 + drivers/net/sfc/sfc_ethdev.c | 2 +- drivers/net/thunderx/base/nicvf_hw_defs.h | 1 + drivers/net/thunderx/nicvf_ethdev.c | 2 +- lib/librte_ethdev/rte_ethdev.c | 25 ++++++++++++++++++++--- 49 files changed, 132 insertions(+), 65 deletions(-)
Signature · 1 line
2.17.1